Skip to content

Commit 526660a

Browse files
Update to reflect newest versions of Skyscanner linting configurations (#78)
1 parent 7b1b10d commit 526660a

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

packages/react-scripts/migrating-from-v6-to-v7.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,18 @@ Like any major release, `backpack-react-scripts@7` contains a few breaking chang
1414

1515
We have decoupled ESLint and Stylelint from this release. This is because the rate at which our configs (`eslint-config-skyscanner` and `stylelint-config-skyscanner`) change is much faster than the underlying functionality of `create-react-app`, causing unecessary churn.
1616

17-
That means that your `npm run lint:js` and `npm run lint:scss` scripts will no longer work. To fix this, install them yourself using:
17+
That means that your `npm run lint:js` and `npm run lint:scss` scripts will no longer work if on `eslint-config-skyscanner@^4` or `stylelint-config-skyscanner@^1`.
18+
19+
If on these older versions of our Skyscanner linting configurations and you do not wish to upgrade in this change you will need to install their peer dependencies. It is however recommended to upgrade to the latest of each, where not only will this not be a problem but you will benefit from the latest linting features and improvements.
20+
21+
If you do not wish to upgrade then you can install the required peer dependencies using:
1822

1923
ESLint
2024

21-
**Note:** If your codebase uses `eslint-config-skyscanner-with-prettier` then you don't need to do anything.
25+
**Note:** `eslint-config-skyscanner-with-prettier` does not require peer dependencies, but has been deprecated in favour of `eslint-config-skyscanner` coming with Prettier inbuild by default from [`v5`](https://github.com/Skyscanner/eslint-config-skyscanner/blob/master/CHANGELOG.md).
2226

2327
```
24-
npx install-peerdeps --dev eslint-config-skyscanner@^3
28+
npx install-peerdeps --dev eslint-config-skyscanner@^4
2529
```
2630

2731
Stylelint

0 commit comments

Comments
 (0)