Skip to content

Commit 9cd3c7e

Browse files
authored
Merge pull request #1 from ajones513/iconv-fix
Fix iconv loader
2 parents ad4c053 + 83e5434 commit 9cd3c7e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

packages/react-scripts/config/webpack.config.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -345,6 +345,7 @@ module.exports = function(webpackEnv) {
345345
],
346346
},
347347
module: {
348+
noParse: /iconv-loader\.js$/, // https://github.com/webpack/webpack/issues/3078#issuecomment-400697407
348349
strictExportPresence: true,
349350
rules: [
350351
// Disable require.ensure as it's not a standard language feature.

packages/react-scripts/config/webpack.config.ssr.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,7 @@ module.exports = function(webpackEnv) {
350350
],
351351
},
352352
module: {
353+
noParse: /iconv-loader\.js$/, // https://github.com/webpack/webpack/issues/3078#issuecomment-400697407
353354
strictExportPresence: true,
354355
rules: [
355356
// Disable require.ensure as it's not a standard language feature.
@@ -616,7 +617,6 @@ module.exports = function(webpackEnv) {
616617
],
617618
},
618619
plugins: [
619-
new webpack.IgnorePlugin(/\/iconv-loader$/), // https://github.com/webpack/webpack/issues/3078#issuecomment-400697407
620620
useHardSourceWebpackPlugin &&
621621
new HardSourceWebpackPlugin({ environmentHash }),
622622
useHardSourceWebpackPlugin &&

0 commit comments

Comments
 (0)