Simplifying isSmol check by removing useless npc checks

benjilmao · benjilmao · commit 198be4942224 · 2025-05-06T22:42:58.000+01:00
diff --git a/src/main/kotlin/gg/skytils/skytilsmod/mixins/hooks/entity/EntityLivingBaseHook.kt b/src/main/kotlin/gg/skytils/skytilsmod/mixins/hooks/entity/EntityLivingBaseHook.kt
@@ -48,9 +48,7 @@ class EntityLivingBaseHook(val entity: EntityLivingBase) {
     }
 
     val isSmol by lazy {
-        Utils.inSkyblock && entity is EntityPlayer && (
-                (entity is EntityPlayerSP && SuperSecretSettings.smolMe) ||
-                (SuperSecretSettings.smolPeople && entity.uniqueID.version() == 4) || isBreefing)
+        Utils.inSkyblock && entity is EntityPlayer && ((entity is EntityPlayerSP && SuperSecretSettings.smolMe) || (SuperSecretSettings.smolPeople && entity.uniqueID.version() == 4) || isBreefing)
     }
 
     fun modifyPotionActive(potionId: Int, cir: CallbackInfoReturnable<Boolean>) {

Original file line number	Diff line number	Diff line change
`@@ -48,9 +48,7 @@ class EntityLivingBaseHook(val entity: EntityLivingBase) {`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`val isSmol by lazy {`
`51`		`- Utils.inSkyblock && entity is EntityPlayer && (`
`52`		`- (entity is EntityPlayerSP && SuperSecretSettings.smolMe) \|\|`
`53`		`- (SuperSecretSettings.smolPeople && entity.uniqueID.version() == 4) \|\| isBreefing)`
	`51`	`+ Utils.inSkyblock && entity is EntityPlayer && ((entity is EntityPlayerSP && SuperSecretSettings.smolMe) \|\| (SuperSecretSettings.smolPeople && entity.uniqueID.version() == 4) \|\| isBreefing)`
`54`	`52`	`}`
`55`	`53`
`56`	`54`	`fun modifyPotionActive(potionId: Int, cir: CallbackInfoReturnable<Boolean>) {`