fix: normalize mixin targets to a format that RPMod/remap can read

Cherry-pick from d0e3abfc2f903c9b6bd80c356b0523ffd442e2f1 on Skytils/Skytils

Author: My-Name-Is-Jeff

src/main/java/gg/skytils/skytilsmod/mixins/transformers/MixinMinecraft.java

@@ -44,11 +44,11 @@ public abstract class MixinMinecraft implements Executor {
     @Shadow
     public abstract ListenableFuture<Object> addScheduledTask(Runnable runnableToSchedule);
 
-    @Inject(method = "clickMouse()V", at = @At(value = "INVOKE", target = "net/minecraft/client/entity/EntityPlayerSP.swingItem()V", shift = At.Shift.AFTER))
+    @Inject(method = "clickMouse()V", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/entity/EntityPlayerSP;swingItem()V", shift = At.Shift.AFTER))
     private void clickMouse(CallbackInfo info) {
         if (!Utils.INSTANCE.getInSkyblock()) return;
 
-        ItemStack item = thePlayer.getHeldItem();
+        ItemStack item = this.thePlayer.getHeldItem();
         if (item != null) {
             NBTTagCompound extraAttr = ItemUtil.getExtraAttributes(item);
             String itemId = ItemUtil.getSkyBlockItemID(extraAttr);

src/main/java/gg/skytils/skytilsmod/mixins/transformers/crash/MixinCrashReport.java

@@ -42,12 +42,12 @@ public abstract class MixinCrashReport {
     @Unique
     private final CrashReportHook hook = new CrashReportHook((CrashReport) (Object) this);
 
-    @Inject(method = "getCompleteReport", at = @At(value = "INVOKE", target = "Ljava/lang/StringBuilder;append(Ljava/lang/String;)Ljava/lang/StringBuilder;", args = "ldc=---- Minecraft Crash Report ----\n;captureargs=true", shift = At.Shift.AFTER, remap = false, ordinal = 0), locals = LocalCapture.CAPTURE_FAILHARD)
+    @Inject(method = "getCompleteReport", at = @At(value = "INVOKE", target = "Ljava/lang/StringBuilder;append(Ljava/lang/String;)Ljava/lang/StringBuilder;", shift = At.Shift.AFTER, remap = false, ordinal = 0), locals = LocalCapture.CAPTURE_FAILHARD)
     private void thereIsNoOtherWay(CallbackInfoReturnable<String> cir, StringBuilder stringbuilder) {
         hook.checkSkytilsCrash(cir, stringbuilder);
     }
 
-    @ModifyArg(method = "getCompleteReport", at = @At(value = "INVOKE", target = "Ljava/lang/StringBuilder;append(Ljava/lang/String;)Ljava/lang/StringBuilder;", remap = false, ordinal = 10, args = "matches=method::getCauseStackTraceOrString"))
+    @ModifyArg(method = "getCompleteReport", at = @At(value = "INVOKE", target = "Ljava/lang/StringBuilder;append(Ljava/lang/String;)Ljava/lang/StringBuilder;", remap = false, ordinal = 10))
     private String otherReplaceCauseForLauncher(String theCauseStackTraceOrString) {
         return hook.generateCauseForLauncher(theCauseStackTraceOrString);
     }
@@ -60,6 +60,6 @@ private String replaceWittyComment(String comment) {
 
     @Inject(method = "populateEnvironment", at = @At("RETURN"))
     private void addDataToCrashReport(CallbackInfo ci) {
-        hook.addDataToCrashReport(theReportCategory);
+        hook.addDataToCrashReport(this.theReportCategory);
     }
 }

src/main/java/gg/skytils/skytilsmod/mixins/transformers/renderer/MixinRenderEntityItem.java

@@ -28,7 +28,7 @@
 
 @Mixin(RenderEntityItem.class)
 public abstract class MixinRenderEntityItem {
-    @Inject(method = "doRender", at = @At(value = "INVOKE", target = "net/minecraft/client/renderer/GlStateManager.pushMatrix()V", shift = At.Shift.AFTER, ordinal = 1))
+    @Inject(method = "doRender", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/renderer/GlStateManager;pushMatrix()V", shift = At.Shift.AFTER, ordinal = 1))
     private void scaleItemDrop(EntityItem entity, double x, double y, double z, float entityYaw, float partialTicks, CallbackInfo ci) {
         RenderEntityItemHookKt.scaleItemDrop(entity, x, y, z, entityYaw, partialTicks, ci);
     }

src/main/java/gg/skytils/skytilsmod/mixins/transformers/renderer/MixinRenderItem.java

@@ -40,7 +40,7 @@ private void renderItemOverlayPost(FontRenderer fr, ItemStack stack, int xPositi
         RenderItemHookKt.renderItemOverlayPost(fr, stack, xPosition, yPosition, text, ci);
     }
 
-    @Inject(method = "renderItem(Lnet/minecraft/item/ItemStack;Lnet/minecraft/client/resources/model/IBakedModel;)V", at = @At(value = "INVOKE", target = "net/minecraft/client/renderer/GlStateManager.scale(FFF)V", shift = At.Shift.AFTER))
+    @Inject(method = "renderItem(Lnet/minecraft/item/ItemStack;Lnet/minecraft/client/resources/model/IBakedModel;)V", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/renderer/GlStateManager;scale(FFF)V", shift = At.Shift.AFTER))
     private void renderItemPre(ItemStack stack, IBakedModel model, CallbackInfo ci) {
         RenderItemHookKt.renderItemPre(stack, model, ci);
     }