refactor: Reuse already computed values on CataclysmicMap

Author: My-Name-Is-Jeff

src/main/kotlin/gg/skytils/skytilsmod/features/impl/dungeons/cataclysmicmap/core/CataclysmicMapElement.kt

@@ -166,8 +166,8 @@ object CataclysmicMapElement : GuiElement(name = "Dungeon Map", x = 0, y = 0) {
             if (CataclysmicMapConfig.mapRoomSecrets == 2 && hasSecrets) {
                 GlStateManager.pushMatrix()
                 GlStateManager.translate(
-                    xOffsetCheck + (MapUtils.mapRoomSize shr 1).toFloat(),
-                    yOffsetCheck + 2 + (MapUtils.mapRoomSize shr 1).toFloat(),
+                    xOffsetCheck + DungeonMapColorParser.halfRoom.toFloat(),
+                    yOffsetCheck + 2 + DungeonMapColorParser.halfRoom.toFloat(),
                     0f
                 )
                 GlStateManager.scale(2f, 2f, 1f)

src/main/kotlin/gg/skytils/skytilsmod/features/impl/dungeons/cataclysmicmap/handlers/DungeonMapColorParser.kt

@@ -81,8 +81,8 @@ object DungeonMapColorParser {
         val index = arrayY * 11 + arrayX
         val cached = cachedTiles.getOrElse(index) { return Unknown(0, 0) }
         if (cached == null) {
-            val xPos = DungeonScanner.startX + arrayX * (DungeonScanner.roomSize shr 1)
-            val zPos = DungeonScanner.startZ + arrayY * (DungeonScanner.roomSize shr 1)
+            val xPos = DungeonScanner.startX + arrayX * halfRoom
+            val zPos = DungeonScanner.startZ + arrayY * halfRoom
             cachedTiles[index] = scanTile(arrayX, arrayY, xPos, zPos)
         }
         return cachedTiles[index] ?: Unknown(0, 0)

src/main/kotlin/gg/skytils/skytilsmod/features/impl/dungeons/cataclysmicmap/handlers/DungeonScanner.kt

@@ -58,8 +58,8 @@ object DungeonScanner {
         for (x in 0..10) {
             for (z in 0..10) {
                 // Translates the grid index into world position.
-                val xPos = startX + x * (roomSize shr 1)
-                val zPos = startZ + z * (roomSize shr 1)
+                val xPos = startX + x * DungeonMapColorParser.halfRoom
+                val zPos = startZ + z * DungeonMapColorParser.halfRoom
 
                 if (!mc.theWorld.getChunkFromChunkCoords(xPos shr 4, zPos shr 4).isLoaded) {
                     // The room being scanned has not been loaded in.