DD#main: refactor: bring plugin generator interface in line with other methods

Author: Demoli

README.md

@@ -44,12 +44,12 @@ Create or update a plugin class.
 
 You can update an existing plugin to add new methods.
 
-`magegen make:plugin [<subject> [<method> [<class> [<type> [<area>]]]]]`
+`magegen make:plugin [<module> [<subject> [<method> [<class> [<type> [<area>]]]]]]`
 
+* module - The module name, e.g. MyCompany_MyModule
 * subject - The plugin subject class or interface, e.g \Magento\Checkout\Api\PaymentInformationManagementInterface
 * method - The plugin subject method e.g. savePaymentInformationAndPlaceOrder
-* class - The fully qualified class name for your plugin class, e.g.
-  \MyCompany\MyModule\Plugin\Model\PaymentInformationPlugin
+* class - The class path and name relative to modules Plugin directory, e.g Model\PaymentInformationPlugin
 * type - The plugin type, before, around, after.
 * area - The plugin area, global, frontend, adminhtml, etc.
 

src/MakePluginCommand.php

@@ -11,6 +11,7 @@
 
 namespace MageGen;
 
+use MageGen\Autocomplete\ModuleAutocomplete;
 use MageGen\Generator\DiGenerator;
 use MageGen\Writer\ClassFile;
 use Nette\PhpGenerator\ClassType;
@@ -54,9 +55,10 @@ public function __construct(Environment $twig, string $name = null)
     protected function configure(): void
     {
         parent::configure();
+        $this->addArgument('module', InputArgument::OPTIONAL, 'Module name');
         $this->addArgument('subject', InputArgument::OPTIONAL, 'Plugin subject / target');
         $this->addArgument('method', InputArgument::OPTIONAL, 'Subject method');
-        $this->addArgument('class', InputArgument::OPTIONAL, 'Plugin class name');
+        $this->addArgument('class', InputArgument::OPTIONAL, 'Plugin class name relative to module Plugin/');
         $this->addArgument('type', InputArgument::OPTIONAL, "before, around, after");
         $this->addArgument(
             'area',
@@ -74,6 +76,17 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $io = new SymfonyStyle($input, $output);
 
+        $module = $input->getArgument('module');
+        if (!$module) {
+            $module = $io->askQuestion(
+                (new Question('Module'))->setAutocompleterValues(
+                    (new ModuleAutocomplete())->getAutocompleteValues(
+                        $input->getOption('magepath')
+                    )
+                )
+            );
+        }
+
         $subject = $input->getArgument('subject');
         if (!$subject) {
             $subject = $io->askQuestion(
@@ -86,11 +99,20 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 new Question('method')
             );
         }
-        $classFqn = $input->getArgument('class');
-        if (!$classFqn) {
-            $classFqn = $io->askQuestion(new Question('Class'));
+        $className = $input->getArgument('class');
+        if (!$className) {
+            $className = $io->askQuestion(new Question('Class'));
         }
 
+        $classFqn = implode(
+            '\\',
+            [
+                str_replace('_', '\\', $module),
+                'Plugin',
+                $className,
+            ]
+        );
+
         $type = $input->getArgument('type');
         if (!$type) {
             $type = $io->choice('Type', ['before', 'around', 'after']);