Skip to content

Commit 0756a93

Browse files
committed
Correctly do this catch
1 parent 2b9cebc commit 0756a93

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"magento/magento-composer-installer": "*"
77
},
88
"type": "magento2-module",
9-
"version": "0.1.3",
9+
"version": "0.1.4",
1010
"autoload": {
1111
"files": [
1212
"src/registration.php"

src/Controller/Router.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,13 +113,15 @@ public function __construct(
113113
*/
114114
public function match(\Magento\Framework\App\RequestInterface $request)
115115
{
116+
$identifier = $this->requestHelper->getSlug($request);
116117

117118
foreach ($this->_matchers as $action => $method) {
119+
$isMatch = false;
118120
try {
119121
$isMatch = call_user_func([$this, $method], $identifier);
120122
}
121123
catch (ApiException $exception) {
122-
return false;
124+
// swallow the error as most likely a 404
123125
}
124126

125127
if ($isMatch) {

src/etc/module.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0"?>
22
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
3-
<module name="Skywire_WordpressApi" setup_version="0.1.3">
3+
<module name="Skywire_WordpressApi" setup_version="0.1.4">
44
</module>
55
</config>

0 commit comments

Comments
 (0)