Do not load service names which are class or interfaces themselves (#23)

Author: Slamdunk

phpstan.neon

@@ -1,8 +1,8 @@
 includes:
-    - phar://phpstan.phar/conf/config.levelmax.neon
     - vendor/phpstan/phpstan-phpunit/extension.neon
 
 parameters:
+    level: max
     paths:
         - src/
         - tests/

src/Type/Laminas/ServiceManagerGetDynamicReturnTypeExtension.php

@@ -82,6 +82,10 @@ public function getTypeFromMethodCall(
             return new NeverType();
         }
 
+        if (\class_exists($serviceName) || \interface_exists($serviceName)) {
+            return new ObjectServiceManagerType($serviceName, $serviceName);
+        }
+
         $service = $serviceManager->get($serviceName);
         if (\is_object($service)) {
             return new ObjectServiceManagerType(\get_class($service), $serviceName);

tests/LaminasIntegration/data/serviceManagerDynamicReturn-0.json

@@ -1,12 +1,12 @@
 [
     {
         "message": "The service \"bar\" was not configured in Laminas\\ServiceManager\\ServiceLocatorInterface.",
-        "line": 23,
+        "line": 24,
         "ignorable": true
     },
     {
         "message": "The service \"foobar\" was not configured in ViewHelperManager nor the class \"foobar\" exists.",
-        "line": 31,
+        "line": 32,
         "ignorable": true
     }
 ]

tests/LaminasIntegration/data/serviceManagerDynamicReturn-2.json

@@ -1,12 +1,17 @@
 [
     {
         "message": "Call to an undefined method LaminasPhpStan\\TestAsset\\CssService::isCssWut().",
-        "line": 29,
+        "line": 30,
+        "ignorable": true
+    },
+    {
+        "message": "Call to an undefined method LaminasPhpStan\\TestAsset\\HeavyService::bar().",
+        "line": 36,
         "ignorable": true
     },
     {
         "message": "Cannot access property $foo on array<string, string>.",
-        "line": 39,
+        "line": 44,
         "ignorable": true
     }
 ]

tests/LaminasIntegration/data/serviceManagerDynamicReturn-3.json

@@ -1,7 +1,7 @@
 [
     {
         "message": "Offset 'xyz' does not exist on array('foo' => 'bar').",
-        "line": 38,
+        "line": 43,
         "ignorable": true
     }
 ]

tests/LaminasIntegration/data/serviceManagerDynamicReturn.php

@@ -5,6 +5,7 @@
 namespace LaminasPhpStan\Tests\LaminasIntegration\data;
 
 use Laminas\ServiceManager\ServiceLocatorInterface;
+use LaminasPhpStan\TestAsset\HeavyService;
 
 final class serviceManagerDynamicReturn
 {
@@ -29,6 +30,10 @@ public function getDynamicType(): void
         $viewHelperManager->get('css')->isCssWut();
 
         $viewHelperManager->get('foobar')->isCss();
+
+        $heavyService = $this->serviceManager->get(HeavyService::class);
+        $heavyService->foo();
+        $heavyService->bar();
     }
 
     public function nonObjectServices(): void

tests/LaminasIntegration/servicemanagerloader.php

@@ -3,9 +3,11 @@
 declare(strict_types=1);
 
 use Laminas\ModuleManager\Feature\ConfigProviderInterface;
+use Laminas\ServiceManager\Factory\InvokableFactory;
 use LaminasPhpStan\TestAsset\BarService;
 use LaminasPhpStan\TestAsset\CssService;
 use LaminasPhpStan\TestAsset\FooService;
+use LaminasPhpStan\TestAsset\HeavyService;
 use LaminasPhpStan\TestAsset\Route66;
 use LaminasPhpStan\TestAsset\XyzController;
 
@@ -28,6 +30,9 @@ public function getConfig()
                                 'foo' => 'bar',
                             ],
                         ],
+                        'factories' => [
+                            HeavyService::class => InvokableFactory::class,
+                        ],
                     ],
                     'controllers' => [
                         'invokables' => [

tests/TestAsset/HeavyService.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace LaminasPhpStan\TestAsset;
+
+final class HeavyService
+{
+    public function __construct()
+    {
+        throw new \RuntimeException('Too heavy to load for Static Analysis');
+    }
+
+    public function foo(): bool
+    {
+        return true;
+    }
+}