Skip to content

Commit 4959ba2

Browse files
author
SlavaRa
committed
Minor...
1 parent cf3149c commit 4959ba2

File tree

4 files changed

+13
-21
lines changed

4 files changed

+13
-21
lines changed

QuickNavigate/Forms/ClassHierarchyForm.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,7 @@ public ClassHierarchyForm([NotNull] ClassModel model, [NotNull] Settings setting
7171
RefreshTree();
7272
}
7373

74-
[CanBeNull]
75-
public TypeNode SelectedNode => tree.SelectedNode as TypeNode;
74+
public override TypeNode SelectedNode => tree.SelectedNode as TypeNode;
7675

7776
void InitializeTree()
7877
{

QuickNavigate/Forms/ClassModelExplorerForm.cs

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
using System;
22
using System.Diagnostics;
33
using System.Drawing;
4-
using System.Linq;
54
using System.Windows.Forms;
65
using ASCompletion.Model;
76
using JetBrains.Annotations;
@@ -27,6 +26,8 @@ public ClassModelExplorerForm([NotNull] Settings settings)
2726
InitializeContextMenu();
2827
}
2928

29+
[CanBeNull] public virtual TypeNode SelectedNode => null;
30+
3031
protected override void Dispose(bool disposing)
3132
{
3233
if (disposing)
@@ -67,41 +68,33 @@ protected virtual void ShowContextMenu(Point position)
6768
protected void OnGotoLineOrPosition(object sender, EventArgs e)
6869
{
6970
Debug.Assert(GotoPositionOrLine != null, "GotoPositionOrLine != null");
70-
GotoPositionOrLine(this, GetModelFromSelectedNode());
71+
GotoPositionOrLine(this, SelectedNode?.Model);
7172
}
7273

7374
protected void OnShowInQuickOutline(object sender, EventArgs e)
7475
{
7576
Debug.Assert(ShowInQuickOutline != null, "ShowInQuickOutline != null");
76-
ShowInQuickOutline(this, GetModelFromSelectedNode());
77+
ShowInQuickOutline(this, SelectedNode?.Model);
7778
}
7879

7980
protected void OnShowInClassHierarchy(object sender, EventArgs e)
8081
{
8182
Debug.Assert(ShowInClassHierarchy != null, "ShowInClassHierarchy != null");
82-
ShowInClassHierarchy(this, GetModelFromSelectedNode());
83+
ShowInClassHierarchy(this, SelectedNode?.Model);
8384
}
8485

8586
protected void OnShowInProjectManager(object sender, EventArgs e)
8687
{
8788
Debug.Assert(ShowInProjectManager != null, "ShowInProjectManager != null");
88-
ShowInProjectManager(this, GetModelFromSelectedNode());
89+
ShowInProjectManager(this, SelectedNode?.Model);
8990
}
9091

9192
protected void OnShowInFileExplorer(object sender, EventArgs e)
9293
{
9394
Debug.Assert(ShowInFileExplorer != null, "ShowInFileExplorer != null");
94-
ShowInFileExplorer(this, GetModelFromSelectedNode());
95+
ShowInFileExplorer(this, SelectedNode?.Model);
9596
}
9697

97-
TreeView GetTreeView()
98-
{
99-
var tree = ContextMenuStrip.SourceControl as TreeView;
100-
return tree ?? ContextMenuStrip.SourceControl.Controls.OfType<TreeView>().FirstOrDefault();
101-
}
102-
103-
ClassModel GetModelFromSelectedNode() => ((TypeNode) GetTreeView().SelectedNode).Model;
104-
10598
#region Event Handlers
10699

107100
protected virtual void OnTreeNodeMouseClick(object sender, TreeNodeMouseClickEventArgs e)

QuickNavigate/Forms/TypeExplorerForm.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ Button CurrentFilter
7878
}
7979
}
8080

81-
[CanBeNull] public TypeNode SelectedNode => tree.SelectedNode as TypeNode;
81+
public override TypeNode SelectedNode => tree.SelectedNode as TypeNode;
8282

8383
protected override void Dispose(bool disposing)
8484
{

QuickNavigate/PluginMain.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ void InitBasics()
133133
{
134134
var dataPath = Path.Combine(PathHelper.DataDir, Name);
135135
if (!Directory.Exists(dataPath)) Directory.CreateDirectory(dataPath);
136-
settingFilename = Path.Combine(dataPath, "Settings.fdb");
136+
settingFilename = Path.Combine(dataPath, $"{nameof(Settings)}.fdb");
137137
}
138138

139139
/// <summary>
@@ -143,7 +143,7 @@ void LoadSettings()
143143
{
144144
Settings = new Settings();
145145
if (!File.Exists(settingFilename)) SaveSettings();
146-
else Settings = (Settings)ObjectSerializer.Deserialize(settingFilename, Settings);
146+
else Settings = (Settings) ObjectSerializer.Deserialize(settingFilename, Settings);
147147
}
148148

149149
/// <summary>
@@ -203,7 +203,7 @@ void ShowRecentFiles()
203203
var form = new OpenRecentFilesForm((Settings) Settings);
204204
form.KeyUp += OnFormKeyUp;
205205
if (form.ShowDialog() != DialogResult.OK) return;
206-
var plugin = (ProjectManager.PluginMain)PluginBase.MainForm.FindPlugin(FormHelper.ProjectManagerGUID);
206+
var plugin = (ProjectManager.PluginMain) PluginBase.MainForm.FindPlugin(FormHelper.ProjectManagerGUID);
207207
form.SelectedItems.ForEach(plugin.OpenFile);
208208
}
209209

@@ -252,7 +252,7 @@ void ShowTypeExplorer()
252252
disabledTip = "Show all(Alt+E or left click)";
253253
form.AddFilter(PluginUI.ICON_TYPE, FlagType.Enum, Keys.E, enabledTip, disabledTip);
254254
}
255-
// Abstracts
255+
// TODO: Abstracts
256256
form.GotoPositionOrLine += GotoPositionOrLine;
257257
form.ShowInQuickOutline += ShowQuickOutline;
258258
form.ShowInClassHierarchy += ShowClassHierarchy;

0 commit comments

Comments
 (0)