Add loose tests for invariants (#149)

* Add loose tests for invariants

* Fix that causes bailout in nested rule to stop validation altogether

Author: SleeplessByte

CHANGELOG.md

@@ -1,19 +1,23 @@
 # Changelog
 
+## 2.3.2
+
+- Fix that causes bailout in nested rule to stop validation altogether
+
 ## 2.3.1
 
- - Fix build issue that caused debian package to be empty
+- Fix build issue that caused debian package to be empty
 
 ## 2.3.0
 
- - Add ability to define multiple versions using one block.
- - Add `index` attribute type that automatically generates a link list compatible with media_types-serialization.
- - Add support for `collection` to automatically look up a previously defined schema when passing a view.
- - Add ability to mark certain attributes as optional when validating with `loose: true` and required otherwise.
+- Add ability to define multiple versions using one block.
+- Add `index` attribute type that automatically generates a link list compatible with media_types-serialization.
+- Add support for `collection` to automatically look up a previously defined schema when passing a view.
+- Add ability to mark certain attributes as optional when validating with `loose: true` and required otherwise.
 
 ## 2.2.0
 
- - Change dependencies and build output to be debian compatible
+- Change dependencies and build output to be debian compatible
 
 ## 2.1.1
 

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    media_types (2.1.1)
+    media_types (2.3.2)
 
 GEM
   remote: https://rubygems.org/

lib/media_types/scheme.rb

@@ -383,7 +383,7 @@ def collection(key, scheme = nil, view: nil, allow_empty: false, expected_type:
     #
     def index(optional: false)
       collection(:_links, optional: optional) do
-        link :_self  
+        link :_self
       end
     end
 

lib/media_types/scheme/rules_exhausted_guard.rb

@@ -48,11 +48,13 @@ def iterate(mark)
 
           mark.call(key)
 
-          rules.get(key).validate!(
-            value,
-            options.trace(key),
-            context: context
-          )
+          catch(:end) do
+            rules.get(key).validate!(
+              value,
+              options.trace(key),
+              context: context
+            )
+          end
         end
       end
 

lib/media_types/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MediaTypes
-  VERSION = '2.3.1'
+  VERSION = '2.3.2'
 end

test/media_types/loose_validation_test.rb

@@ -16,11 +16,24 @@ def self.organisation
 
     # default attribute (=hash object)
     validations do
+
       attribute :foo do
         attribute :bar, Numeric, optional: :loose
       end
-      assert_pass '{"foo":{}}', loose: true
-      assert_fail '{"foo":{}}', loose: false
+
+      attribute :baz, String
+
+      # Loose keys don't need to be present in loose mode
+      assert_pass '{"foo":{}, "baz": "hello world"}', loose: true
+
+      # Loose keys must be present in normal mode
+      assert_fail '{"foo":{}, "baz": "hello world"}', loose: false
+
+      # All required keys must be present
+      assert_fail '{"foo":{}}', loose: true
+
+      # Extra keys not allowed (unless not-strict)
+      assert_fail '{"foo":{}, "nope": "unknown"}', loose: true
     end
   end