Skip to content

Commit 9dd1b78

Browse files
committed
BUG: Fix upload of macOS extensions to the Girder-based extension manager server
This commit fixes the error reported below ensuring the python client is running with the proper local (en_US.UTF-8 instead of C) on the macOS factory machine. This is required because the build script are executed using cronjob that only has a minimal environment where the LANG= variable is not set to UTF-8. References: http://click.pocoo.org/6/python3/#python-3-surrogate-handling Error: RuntimeError: Click will abort further execution because Python 3 was configured to use ASCII as encoding for the environment. Consult http://click.pocoo.org/python3/for mitigation steps. This system lists a couple of UTF-8 supporting locales that you can pick from. The following suitable locales where discovered: [...] git-svn-id: http://svn.slicer.org/Slicer4/trunk@26938 3bd1e089-480b-0410-8dfb-8563597acbee
1 parent 37d8162 commit 9dd1b78

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

Extensions/CMake/SlicerExtensionPackageAndUploadTarget.cmake

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,9 +306,13 @@ Check that:
306306
(2) your email and api key are correct")
307307
endif()
308308

309+
message("Uploading [${package_name}] to [${SLICER_EXTENSION_MANAGER_URL}]")
309310
get_filename_component(package_directory ${p} DIRECTORY)
310311
set(error_file ${package_directory}/slicer_extension_server_upload_errors.txt)
311312
execute_process(COMMAND
313+
${CMAKE_COMMAND} -E env
314+
LC_ALL=en_US.UTF-8
315+
LANG=en_US.UTF-8
312316
${SLICER_EXTENSION_MANAGER_CLIENT_EXECUTABLE}
313317
--api-url ${SLICER_EXTENSION_MANAGER_URL}/api/v1
314318
--api-key ${SLICER_EXTENSION_MANAGER_API_KEY}

0 commit comments

Comments
 (0)