From c7b926085394531178744df0a808fcdb981106ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jon=20Haitz=20Legarreta=20Gorro=C3=B1o?= Date: Wed, 22 Nov 2023 20:09:14 -0500 Subject: [PATCH] COMP: Fix unused parameter warnings in `vtkParallelTransportTest1.cxx` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix unused parameter warnings in `vtkParallelTransportTest1.cxx`: - Remove the unused `lineDirection` variable. - Make use of the `tangentsArray` variable by querying its contents using the index and print them. Fixes: ``` /usr/src/Slicer-build/vtkAddon/Testing/vtkParallelTransportTest1.cxx: In function ‘int vtkParallelTransportTest1(int, char**)’: /usr/src/Slicer-build/vtkAddon/Testing/vtkParallelTransportTest1.cxx:100:21: warning: unused variable ‘tangentsArray’ [-Wunused-variable] vtkDoubleArray* tangentsArray = vtkDoubleArray::SafeDownCast(pointData->GetArray("Tangents")); ^~~~~~~~~~~~~ /usr/src/Slicer-build/vtkAddon/Testing/vtkParallelTransportTest1.cxx:38:10: warning: unused variable ‘lineDirection’ [-Wunused-variable] double lineDirection[3] = { 0.0, 0.0, 1.0 }; ^~~~~~~~~~~~~ ``` https://github.com/Slicer/Slicer/actions/runs/6950843491/job/18911721210#step:4:2749 --- Testing/vtkParallelTransportTest1.cxx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Testing/vtkParallelTransportTest1.cxx b/Testing/vtkParallelTransportTest1.cxx index 0d31af6..e7d97d9 100644 --- a/Testing/vtkParallelTransportTest1.cxx +++ b/Testing/vtkParallelTransportTest1.cxx @@ -35,7 +35,6 @@ int vtkParallelTransportTest1(int vtkNotUsed(argc), char* vtkNotUsed(argv)[]) // Test computation with a straight line input (zero curvature) - double lineDirection[3] = { 0.0, 0.0, 1.0 }; vtkNew line; line->SetPoint1(10,20,30); line->SetPoint1(30,70,-80); @@ -106,6 +105,8 @@ int vtkParallelTransportTest1(int vtkNotUsed(argc), char* vtkNotUsed(argv)[]) normalsArray->GetTypedTuple(tupleIndex, normal); double binormal[3] = { 0.0, 0.0, 0.0 }; binormalsArray->GetTypedTuple(tupleIndex, binormal); + double tangents[3] = { 0.0, 0.0, 0.0 }; + tangentsArray->GetTypedTuple(tupleIndex, tangents); double pointPosition[3]; points->GetPoint(tupleIndex, pointPosition); @@ -117,6 +118,7 @@ int vtkParallelTransportTest1(int vtkNotUsed(argc), char* vtkNotUsed(argv)[]) std::cout << "Circle point [" << tupleIndex << "]" << std::endl; std::cout << " normal: " << normal[0] << ", " << normal[1] << ", " << normal[2] << std::endl; std::cout << " binormal: " << binormal[0] << ", " << binormal[1] << ", " << binormal[2] << std::endl; + std::cout << " tangents: " << tangents[0] << ", " << tangents[1] << ", " << tangents[2] << std::endl; std::cout << " radial: " << radialDirection[0] << ", " << radialDirection[1] << ", " << radialDirection[2] << std::endl; }