The data displayed by placeholder and /sf stats is different

[LOURENT4462]

❗ Checklist

• I am using the official english version of Slimefun and did not modify the jar.
• I downloaded the official version from the new build site Blob Builds.
• I am using an up to date "DEV" (not "RC") version of Slimefun.
• I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
• I searched for similar open issues and could not find an existing bug report on this.

📍 Description

The percentage shown by the placeholder and /sf stats is different.

I tested with a player who just opened 1 slimefun item, the placeholder shows his research progress is 0.32% while the /sf stats show 0.35%

possible causes

There are some slimefun items that I disabled.

The data displayed by the placeholder %slimefun_researches_percentage_researches_unlocked% displays data from all slimefun items (including the disabled ones)

while the /sf stats displays data from all slimefun items (except the disabled ones)

📑 Reproduction Steps

1. Unlock some slimefun items
2. Check placeholder %slimefun_researches_percentage_researches_unlocked%
3. Check /sf stats (Research progress)

The percentages displayed will be different

💡 Expected Behavior

The percentage displayed should be the same

📷 Screenshots / Videos

📜 Server Log

No response

📂 /error-reports/ folder

No response

💻 Server Software

Paper

🎮 Minecraft Version

1.20.x

⭐ Slimefun version

Slimefun vDev - 1157

🧭 Other plugins

No response

[DereC4]

hm

[DereC4]

It looks like the discrepancy is the researches_percentage_researches_unlocked conditional counts all researches, including those with no enabled items (e.g., disabled ones), which is not how /sf stats works. I'll take a look

[DereC4]

Created a PR for it