fix(1.8): map modern icon materials to legacy substitutes instead of STONE

Author: intisy

src/main/java/io/ncbpfluffybear/fluffymachines/utils/MaterialCompat.java

@@ -18,6 +18,46 @@ private MaterialCompat() {}
     @Nonnull
     public static Material safe(@Nonnull XMaterial material) {
         Material resolved = material.parseMaterial();
+        if (resolved == null) {
+            resolved = substitute(material);
+        }
         return resolved != null ? resolved : Material.STONE;
     }
+
+    // Sensible legacy substitutes for materials that don't exist on older servers (e.g. on 1.8),
+    // so an icon resolves to something recognisable instead of STONE.
+    private static final java.util.Map<XMaterial, XMaterial> LEGACY_SUBSTITUTES = buildLegacySubstitutes();
+
+    private static java.util.Map<XMaterial, XMaterial> buildLegacySubstitutes() {
+        java.util.Map<XMaterial, XMaterial> m = new java.util.EnumMap<>(XMaterial.class);
+        m.put(XMaterial.NETHERITE_BLOCK, XMaterial.DIAMOND_BLOCK);
+        m.put(XMaterial.NETHERITE_INGOT, XMaterial.DIAMOND);
+        m.put(XMaterial.NETHERITE_SCRAP, XMaterial.IRON_NUGGET);
+        m.put(XMaterial.ANCIENT_DEBRIS, XMaterial.NETHERRACK);
+        m.put(XMaterial.BEEHIVE, XMaterial.DISPENSER);
+        m.put(XMaterial.BEE_NEST, XMaterial.DISPENSER);
+        m.put(XMaterial.HONEY_BLOCK, XMaterial.SLIME_BLOCK);
+        m.put(XMaterial.BARREL, XMaterial.CHEST);
+        m.put(XMaterial.BLAST_FURNACE, XMaterial.FURNACE);
+        m.put(XMaterial.SMOKER, XMaterial.FURNACE);
+        m.put(XMaterial.CAMPFIRE, XMaterial.NETHERRACK);
+        m.put(XMaterial.SMITHING_TABLE, XMaterial.CRAFTING_TABLE);
+        m.put(XMaterial.CARTOGRAPHY_TABLE, XMaterial.CRAFTING_TABLE);
+        m.put(XMaterial.FLETCHING_TABLE, XMaterial.CRAFTING_TABLE);
+        m.put(XMaterial.LOOM, XMaterial.CRAFTING_TABLE);
+        m.put(XMaterial.STONECUTTER, XMaterial.CRAFTING_TABLE);
+        m.put(XMaterial.GRINDSTONE, XMaterial.ANVIL);
+        m.put(XMaterial.LANTERN, XMaterial.GLOWSTONE);
+        m.put(XMaterial.COMPOSTER, XMaterial.CHEST);
+        m.put(XMaterial.MAGMA_BLOCK, XMaterial.NETHERRACK);
+        m.put(XMaterial.LODESTONE, XMaterial.IRON_BLOCK);
+        m.put(XMaterial.BLACKSTONE, XMaterial.COBBLESTONE);
+        m.put(XMaterial.OBSERVER, XMaterial.PISTON);
+        return m;
+    }
+
+    private static Material substitute(XMaterial xMaterial) {
+        XMaterial sub = LEGACY_SUBSTITUTES.get(xMaterial);
+        return sub != null ? sub.parseMaterial() : null;
+    }
 }