fix(compat): null-guard SmartFactory recipe reduction; bump core to gh-v5.2.4.6

Author: intisy

build.gradle.kts

@@ -44,7 +44,7 @@ dependencies {
     githubImplementation("Slimefun5:SlimefunMetrics:v1.0.0")
     compileOnly("org.spigotmc:spigot-api:1.16.5-R0.1-SNAPSHOT")
     compileOnly("com.google.code.findbugs:jsr305:3.0.2")
-    githubCompileOnly("Slimefun5:Slimefun5:gh-v5.2.4.5")
+    githubCompileOnly("Slimefun5:Slimefun5:gh-v5.2.4.6")
     compileOnly("com.gmail.nossr50.mcMMO:mcMMO:2.1.149") {
         exclude(group = "org.jetbrains", module = "annotations")
         exclude(group = "com.sk89q.worldguard")

src/main/java/io/ncbpfluffybear/fluffymachines/machines/SmartFactory.java

@@ -83,13 +83,24 @@ public SmartFactory(ItemGroup itemGroup, SlimefunItemStack item, RecipeType reci
         super(itemGroup, item, recipeType, recipe);
 
         for (SlimefunItemStack sfItem : ACCEPTED_ITEMS) {
+            SlimefunItem resolved = sfItem.getItem();
+            if (resolved == null) {
+                // Not registered on this build (e.g. removed/renamed item); skip instead of crashing
+                continue;
+            }
+
             List<ItemStack[]> variationList = new ArrayList<>();
-            variationList.add(collectRawRecipe(sfItem.getItem()));
-            ITEM_RECIPES.put(sfItem.getItem(), variationList);
+            variationList.add(collectRawRecipe(resolved));
+            ITEM_RECIPES.put(resolved, variationList);
         }
 
         for (SlimefunItemStack alternative : MAGMA_ALTERNATIVES) {
-            ItemStack[] original = ITEM_RECIPES.get(alternative.getItem()).get(0);
+            SlimefunItem resolvedAlternative = alternative.getItem();
+            if (resolvedAlternative == null || !ITEM_RECIPES.containsKey(resolvedAlternative)) {
+                continue;
+            }
+
+            ItemStack[] original = ITEM_RECIPES.get(resolvedAlternative).get(0);
             ItemStack[] variation = new ItemStack[original.length];
             for (int i = 0; i < original.length; i++) {
                 if (original[i].getType() == MaterialCompat.safe(XMaterial.NETHERRACK) && original[i].getAmount() % 16 == 0) {
@@ -99,7 +110,7 @@ public SmartFactory(ItemGroup itemGroup, SlimefunItemStack item, RecipeType reci
                 }
             }
 
-            List<ItemStack[]> variations = ITEM_RECIPES.get(alternative.getItem());
+            List<ItemStack[]> variations = ITEM_RECIPES.get(resolvedAlternative);
             variations.add(variation);
         }
 
@@ -341,6 +352,10 @@ private Pair<HashMap<Material, Integer>, HashMap<SlimefunItem, Integer>> reduceR
         HashMap<Material, Integer> rawVanilla = new HashMap<>();
         HashMap<SlimefunItem, Integer> rawSlimefun = new HashMap<>();
 
+        if (key == null) {
+            return new Pair<>(rawVanilla, rawSlimefun);
+        }
+
         ItemStack[] recipe = key.getRecipe();
         if (key == SlimefunItems.COPPER_WIRE.getItem()) {
             recipe = new ItemStack[] {SlimefunItems.COPPER_DUST.item()};