Issue #284: Upload occurs even if build fails.

This patch makes upload handle to check if build completed successfully.
Since there is no standard way to do this, we just check if current
project has and CDT build errors or not.

This patch also fixes an error when an error dialog was raised from a
non-UI thread.

Author: infthi

it.baeyens.arduino.core/src/it/baeyens/arduino/actions/UploadProjectHandler.java

@@ -3,10 +3,13 @@
 import java.net.URL;
 
 import org.eclipse.cdt.core.model.CoreModel;
+import org.eclipse.cdt.core.model.ICModelMarker;
 import org.eclipse.core.commands.AbstractHandler;
 import org.eclipse.core.commands.ExecutionEvent;
 import org.eclipse.core.commands.ExecutionException;
+import org.eclipse.core.resources.IMarker;
 import org.eclipse.core.resources.IProject;
+import org.eclipse.core.resources.IResource;
 import org.eclipse.core.resources.IncrementalProjectBuilder;
 import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.IProgressMonitor;
@@ -34,6 +37,21 @@ public UploadJobHandler(IProject buildProject) {
 		super(Messages.ArduinoUploadProjectHandler_Upload_for_project + buildProject.getName());
 		this.myBuildProject = buildProject;
 	}
+	
+	/**
+	 * Checks if build completed successfully.
+	 * @return true iff project was not built successfully last time.
+	 * @throws CoreException if current project does not exist or is not open.
+	 */
+	private boolean hasBuildErrors() throws CoreException {
+		IMarker[] markers = this.myBuildProject.findMarkers(ICModelMarker.C_MODEL_PROBLEM_MARKER, true, IResource.DEPTH_INFINITE);
+		for (IMarker marker: markers) {
+			if (marker.getAttribute(IMarker.SEVERITY, IMarker.SEVERITY_INFO) == IMarker.SEVERITY_ERROR) {
+				return true;
+			}
+		}
+		return false;
+	}
 
 	@Override
 	protected IStatus run(IProgressMonitor monitor) {
@@ -62,12 +80,20 @@ protected IStatus run(IProgressMonitor _monitor) {
 				};
 				job.setPriority(Job.DECORATE);
 				job.schedule();
+				if (hasBuildErrors()) {
+					throw new CoreException(new Status(IStatus.ERROR, Const.CORE_PLUGIN_ID, "Build completed with errors."));
+				}
 			} catch (CoreException e) {
-				Shell theShell = PlatformUI.getWorkbench().getActiveWorkbenchWindow().getShell();
-				MessageBox dialog = new MessageBox(theShell, SWT.ICON_QUESTION | SWT.OK);
-				dialog.setText(Messages.ArduinoUploadProjectHandler_Build_failed);
-				dialog.setMessage(Messages.ArduinoUploadProjectHandler_Build_failed_so_no_upload);
-				dialog.open();
+				Display.getDefault().asyncExec(new Runnable() {
+					@Override
+					public void run() {
+						Shell theShell = PlatformUI.getWorkbench().getActiveWorkbenchWindow().getShell();
+						MessageBox dialog = new MessageBox(theShell, SWT.ICON_QUESTION | SWT.OK);
+						dialog.setText(Messages.ArduinoUploadProjectHandler_Build_failed);
+						dialog.setMessage(Messages.ArduinoUploadProjectHandler_Build_failed_so_no_upload);
+						dialog.open();
+					}
+				});
 				return Status.OK_STATUS;
 			}
 		}