Moving remind logic to web site

Also fixed 2 warning issue

Author: jantje

Eclipse update site/WebContent/index.shtml

@@ -39,7 +39,7 @@
         <p>This is about a free, open source, <b>Eclipse</b> plug-in to ease your development efforts!<br>
           As you only need the Arduino IDE, Eclipse and this plug-in this represents a completely free and open Arduino IDE alternative.
         </p>
-        <p>[!!!V3 will be released the 1the of April: only the product download is needed!!!!](http://blog.baeyens.it/#post26)</p>
+        <p><a href="http://blog.baeyens.it/#post26">!!!V3 will be released the 1the of April: only the product download is needed!!!!</a></p>
         <p>Welcome to a next stage for your Arduino projects!</p>
         <p>
         	<a href="learn.shtml" class="btn btn-primary btn-lg" role="button">Learn more &raquo;</a>

Eclipse update site/WebContent/remind.php

@@ -0,0 +1 @@
+<?php include 'remind3_0.html';?>

Eclipse update site/WebContent/remind3_0.html

@@ -9,14 +9,14 @@
 <div id="header">
   <a href="http://www.eclipse.org/"><img src="http://download.eclipse.org/eclipse/eclipse.org-common/stylesheets/header_logo.gif" width="163" height="68" border="0" alt="Eclipse Logo" class="logo" /></a>           
 </div>
+<div>
 <h1>So, you think Jantje and the contributors did a great job?</h1> 
 <h2><a href="https://www.patreon.com/jantje?ty=h">Why don't you show it?</a></h2>
-<div>
-  <a href="http://goo.gl/forms/pxHR7XrCuA"><img src="http://en.ancestris.org/images/0/0a/We_need_you.jpg" style="float:right"></a>
-  <h3>"V3 needs testers!"</h3>
-  <h4>If you are willing to dedicate some testing time to the project, please consider membership of <a href="https://groups.google.com/forum/#!forum/arduino-eclipse-plugin">plugin testers</a></h4>
-  <h3>"Feel like contributing?"</h3>
-  <h4>If you are willing to dedicate some java development time to the project, please send a mail with subject "subscribe" to <a href="mailto:[email protected]?SUBJECT=subscribe">[email protected]</a></h4>
+<p>Or simply clik the button below!</p>
+<a href="https://www.patreon.com/bePatron?u=798640&redirect_uri=http%3A%2F%2Fpatron.baeyens.it%2Fthanks.php">
+    <img height="40" width="204" src="https://s3-us-west-1.amazonaws.com/widget-images/become-patron-widget-medium%402x.png">
+</a>
+<p>Note that 1 dollar a month makes a world of difference to us.</p>
 </div>
 
 <div>

it.baeyens.arduino.common/src/it/baeyens/arduino/common/Activator.java

@@ -51,7 +51,7 @@ public static Activator getDefault() {
     private static final String uploadflag = "F" + "u" + "S" + "t" + "a" + "t" + "u" + "s"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ //$NON-NLS-5$ //$NON-NLS-6$ //$NON-NLS-7$ //$NON-NLS-8$
     private static final String buildflag = "F" + "u" + "S" + "t" + "a" + "t" + "u" + "b"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ //$NON-NLS-5$ //$NON-NLS-6$ //$NON-NLS-7$ //$NON-NLS-8$
     private static final String Localflag = "l" + flagStart; //$NON-NLS-1$
-    private static final String helploc = "http://www.baeyens.it/eclipse/remind3_0.html"; //$NON-NLS-1$
+    private static final String helploc = "http://www.baeyens.it/eclipse/remind.php"; //$NON-NLS-1$
 
     /**
      * The constructor
@@ -63,7 +63,8 @@ public Activator() {
     /*
      * (non-Javadoc)
      * 
-     * @see org.eclipse.ui.plugin.AbstractUIPlugin#start(org.osgi.framework.BundleContext )
+     * @see org.eclipse.ui.plugin.AbstractUIPlugin#start(org.osgi.framework.
+     * BundleContext )
      */
     @Override
     public void start(BundleContext context) throws Exception {
@@ -86,8 +87,8 @@ static void remind() {
 	    protected IStatus run(IProgressMonitor monitor) {
 
 		IEclipsePreferences myScope = InstanceScope.INSTANCE.getNode(Const.NODE_ARDUINO);
-		int curFsiStatus = myScope.getInt(flagStart, 0) + myScope.getInt(flagMonitor, 0) + myScope.getInt(uploadflag, 0)
-			+ myScope.getInt(buildflag, 0);
+		int curFsiStatus = myScope.getInt(flagStart, 0) + myScope.getInt(flagMonitor, 0)
+			+ myScope.getInt(uploadflag, 0) + myScope.getInt(buildflag, 0);
 		int lastFsiStatus = myScope.getInt(Localflag, 0);
 		if ((curFsiStatus - lastFsiStatus) > 50) {
 		    if (isInternetReachable()) {
@@ -113,7 +114,8 @@ protected IStatus run(IProgressMonitor monitor) {
     /*
      * (non-Javadoc)
      * 
-     * @see org.eclipse.ui.plugin.AbstractUIPlugin#stop(org.osgi.framework.BundleContext )
+     * @see org.eclipse.ui.plugin.AbstractUIPlugin#stop(org.osgi.framework.
+     * BundleContext )
      */
     @Override
     public void stop(BundleContext context) throws Exception {

it.baeyens.arduino.common/src/it/baeyens/arduino/common/PleaseHelp.java

@@ -14,6 +14,7 @@
 import org.eclipse.swt.widgets.Control;
 import org.eclipse.swt.widgets.Shell;
 import org.eclipse.ui.PlatformUI;
+import org.osgi.framework.FrameworkUtil;
 
 public class PleaseHelp extends Dialog {
 
@@ -61,7 +62,14 @@ public void completed(ProgressEvent event) {
 
 	this.buttonBar = createButtonBar(parent);
 
-	this.browser.setUrl(myhelpLocation + "?os=" + Platform.getOS() + ";arch=" + Platform.getOSArch()); //$NON-NLS-1$ //$NON-NLS-2$
+	org.osgi.framework.Version version = FrameworkUtil.getBundle(getClass()).getVersion();
+	String url = myhelpLocation + "?os=" + Platform.getOS(); //$NON-NLS-1$
+	url += ";arch=" + Platform.getOSArch(); //$NON-NLS-1$
+	url += ";majorVersion=" + version.getMajor(); //$NON-NLS-1$
+	url += ";minorVersion=" + version.getMinor(); //$NON-NLS-1$
+	url += ";microVersion=" + version.getMicro(); //$NON-NLS-1$
+	url += ";qualifierVersion=" + version.getQualifier(); //$NON-NLS-1$
+	this.browser.setUrl(url);
 
 	return parent;
 

it.baeyens.arduino.core/src/it/baeyens/arduino/toolchain/ArduinoLanguageProvider.java

@@ -175,7 +175,7 @@ protected String getCompilerCommand(String languageId) {
 	    if (op2 != null) {
 		compilerCommand = compilerCommand + ' ' + op2.getValue();
 	    }
-	    compilerCommand = compilerCommand + " -D" + Const.DEFINE_IN_ECLIPSE + "=1"; //$NON-NLS-1$
+	    compilerCommand = compilerCommand + " -D" + Const.DEFINE_IN_ECLIPSE + "=1"; //$NON-NLS-1$ //$NON-NLS-2$
 	} else if (languageId.equals("org.eclipse.cdt.core.g++")) { //$NON-NLS-1$
 	    try {
 		compilerCommand = envManager.getVariable(Const.ENV_KEY_recipe_cpp_o_pattern, confDesc, true).getValue()
@@ -193,7 +193,7 @@ protected String getCompilerCommand(String languageId) {
 	    if (op2 != null) {
 		compilerCommand = compilerCommand + ' ' + op2.getValue();
 	    }
-	    compilerCommand = compilerCommand + " -D" + Const.DEFINE_IN_ECLIPSE + "=1"; //$NON-NLS-1$
+	    compilerCommand = compilerCommand + " -D" + Const.DEFINE_IN_ECLIPSE + "=1"; //$NON-NLS-1$ //$NON-NLS-2$
 	} else {
 	    ManagedBuilderCorePlugin.error(
 		    "Unable to find compiler command for language " + languageId + " in toolchain=" + getToolchainId()); //$NON-NLS-1$ //$NON-NLS-2$