Added method to remove all "old platforms"

understand old platforms as platforms for which a newer version is
installed.
This is currently only used for the unit testing.
I don't see any other real usage for now

Author: jantje

io.sloeber.core/src/io/sloeber/core/api/BoardsManager.java

@@ -11,7 +11,6 @@
 import java.util.TreeMap;
 import java.util.TreeSet;
 
-import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.IPath;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.IStatus;
@@ -53,10 +52,10 @@ public static String getUpdateJasonFilesKey() {
 	}
 
 	/**
-	 * Gets the board id based on the information provided. If
-	 * jsonFileName="local" the board is assumend not to be installed by the
+	 * Gets the board descriptor based on the information provided. If
+	 * jsonFileName="local" the board is assumed not to be installed by the
 	 * boards manager. Otherwise the boardsmanager is queried to find the board
-	 * ID. In this case the latest installed board will be returned
+	 * descriptor. In this case the latest installed board will be returned
 	 *
 	 * @param jsonFileName
 	 *            equals to "local" or the name of the json file used by the
@@ -75,7 +74,7 @@ public static String getUpdateJasonFilesKey() {
 	 *            boards.txt file)
 	 * @return The class BoardDescriptor or null
 	 */
-	static public BoardDescriptor getBoardID(String jsonFileName, String packageName, String platformName,
+	static public BoardDescriptor getBoardDescriptor(String jsonFileName, String packageName, String platformName,
 			String boardID, Map<String, String> options) {
 		if (jsonFileName.equals("local")) { //$NON-NLS-1$
 			return BoardDescriptor.makeBoardDescriptor(new File(packageName), boardID, options);
@@ -87,22 +86,18 @@ static private BoardDescriptor getNewestBoardIDFromBoardsManager(String jsonFile
 			String platformName, String boardID, Map<String, String> options) {
 
 		List<Board> boards = null;
-		try {
-			Package thePackage = Manager.getPackage(jsonFileName, packageName);
-			if (thePackage == null) {
-				// fail("failed to find package:" + this.mPackageName);
-				return null;
-			}
-			ArduinoPlatform platform = thePackage.getLatestPlatform(platformName);
-			if (platform == null) {
-				// fail("failed to find platform " + this.mPlatform + " in
-				// package:" + this.mPackageName);
-				return null;
-			}
-			boards = platform.getBoards();
-		} catch (CoreException e1) {
-			e1.printStackTrace();
+		Package thePackage = Manager.getPackage(jsonFileName, packageName);
+		if (thePackage == null) {
+			// fail("failed to find package:" + this.mPackageName);
+			return null;
 		}
+		ArduinoPlatform platform = thePackage.getLatestPlatform(platformName);
+		if (platform == null) {
+			// fail("failed to find platform " + this.mPlatform + " in
+			// package:" + this.mPackageName);
+			return null;
+		}
+		boards = platform.getBoards();
 		if (boards == null) {
 			// fail("No boards found");
 			return null;
@@ -161,8 +156,8 @@ public static void setBoardsPackageURL(String[] newBoardJsonUrls) {
 		Manager.setBoardsPackageURL(newBoardJsonUrls);
 	}
 
-	public static String getBoardsPackageURLs() {
-		return Manager.getBoardsPackageURLs();
+	public static String getDefaultBoardsPackageURLs() {
+		return Manager.getDefaultBoardsPackageURLs();
 	}
 
 	public static boolean isReady() {
@@ -694,7 +689,7 @@ public static String getPrivateHardwarePathsString() {
 	 *
 	 * @return
 	 */
-	public static Set<String> getAllManuNames() {
+	public static Set<String> getAllMenuNames() {
 		Set<String> ret = new TreeSet<>(String.CASE_INSENSITIVE_ORDER);
 		String[] boardFiles = getAllBoardsFiles();
 		for (String curBoardFile : boardFiles) {
@@ -714,4 +709,12 @@ public static TreeMap<String, String> getAllmenus() {
 		return ret;
 	}
 
+	/**
+	 * Remove all packages that have a more recent version
+	 */
+	public static void onlyKeepLatestPlatforms() {
+		Manager.onlyKeepLatestPlatforms();
+
+	}
+
 }

io.sloeber.core/src/io/sloeber/core/common/Const.java

@@ -9,7 +9,6 @@
 @SuppressWarnings("nls")
 public class Const {
 	// java stuff so I do not have to add all the time $NON-NLS-1$
-	public static final String EMPTY_STRING = "";
 	public static final String DOT = ".";
 	public static final String SLACH = "/";
 	public static final String COLON = ":";
@@ -78,9 +77,6 @@ public class Const {
 	public static final String ENV_KEY_JANTJE_PLATFORM_FILE = ENV_KEY_JANTJE_START + "PLATFORM_FILE";
 	public static final String ENV_KEY_JANTJE_CORE_REFERENCED_PLATFORM = ERASE_START + ENV_KEY_JANTJE_START
 			+ "CORE.REFERENCED.PLATFORM"; //$NON-NLS-1$
-	public static final String ENV_KEY_JANTJE_UPLOAD_PORT = ENV_KEY_JANTJE_START + "COM_PORT";
-	public static final String ENV_KEY_JANTJE_BOARD_NAME = ENV_KEY_JANTJE_START + "BOARD_NAME";
-	public static final String ENV_KEY_JANTJE_PROJECT_NAME = ENV_KEY_JANTJE_START + "PROJECT_NAME";
 
 	public static final String ENV_KEY_JANTJE_ADDITIONAL_COMPILE_OPTIONS = ENV_KEY_JANTJE_START + "EXTRA.COMPILE";
 	public static final String ENV_KEY_JANTJE_ADDITIONAL_C_COMPILE_OPTIONS = ENV_KEY_JANTJE_START + "EXTRA.C.COMPILE";

io.sloeber.core/src/io/sloeber/core/managers/Manager.java

@@ -902,4 +902,11 @@ private static void myCopy(URL url, File localFile) {
 		}
 	}
 
+	public static void onlyKeepLatestPlatforms() {
+		List<Package> allPackages = getPackages();
+		for (Package curPackage : allPackages) {
+			curPackage.onlyKeepLatestPlatforms();
+		}
+	}
+
 }

io.sloeber.core/src/io/sloeber/core/managers/Package.java

@@ -163,4 +163,13 @@ public int compareTo(Package other) {
 		return this.name.compareTo(other.name);
 	}
 
+	public void onlyKeepLatestPlatforms() {
+		Collection<ArduinoPlatform> latestPlatforms = getLatestPlatforms();
+		for (ArduinoPlatform curplatform : this.platforms) {
+			if (!latestPlatforms.contains(curplatform)) {
+				curplatform.remove(null);
+			}
+		}
+	}
+
 }

io.sloeber.core/src/io/sloeber/core/tools/uploaders/SSHUpload.java

@@ -20,7 +20,6 @@
 import cc.arduino.packages.ssh.SSHPwdSetup;
 import io.sloeber.core.api.PasswordManager;
 import io.sloeber.core.common.Common;
-import io.sloeber.core.common.Const;
 
 public class SSHUpload implements IRealUpload {
 
@@ -87,7 +86,7 @@ public boolean uploadUsingPreferences(IFile hexFile, boolean usingProgrammer, IP
 
 		} catch (JSchException e) {
 			String message = e.getMessage();
-			String errormessage = Const.EMPTY_STRING;
+			String errormessage = new String();
 			if (Messages.Upload_auth_cancel.equals(message) || Messages.Upload_auth_fail.equals(message)) {
 				errormessage = new String(Messages.Upload_error_auth_fail) + this.myHost;
 				// TODO add to ask if if the user wants to remove the password

io.sloeber.ui/src/io/sloeber/ui/preferences/ThirdPartyHardwareSelectionPage.java

@@ -44,7 +44,7 @@ public boolean performOk() {
     @Override
     protected void performDefaults() {
 	super.performDefaults();
-	this.urlsText.setText(BoardsManager.getBoardsPackageURLs());
+	this.urlsText.setText(BoardsManager.getDefaultBoardsPackageURLs());
     }
 
     @Override