Skip to content

Commit 1fed945

Browse files
author
jantje
committed
fix TODO's
1 parent d1edd47 commit 1fed945

File tree

2 files changed

+1
-12
lines changed

2 files changed

+1
-12
lines changed

io.sloeber.core/src/io/sloeber/core/api/Serial.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -301,9 +301,6 @@ public void setRTS(boolean state) {
301301
}
302302
}
303303

304-
// TODO Remove unused code found by UCDetector
305-
// public void setup() {// JABA is not going to add code
306-
// }
307304

308305
// needed to fill viewers in jfases
309306
@Override

io.sloeber.core/src/io/sloeber/core/tools/ExternalCommandLauncher.java

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -151,15 +151,7 @@ public ExternalCommandLauncher(String command) {
151151
this.myRunLock = this;
152152
String[] commandParts = command
153153
.split(" +(?=([^\"]*\"[^\"]*\")*[^\"]*$)"); //$NON-NLS-1$
154-
//TODO do we really want to remove the quotes?
155-
// for (int curCommand = 0; curCommand < commandParts.length; curCommand++) {
156-
// if (commandParts[curCommand].startsWith("\"") //$NON-NLS-1$
157-
// && commandParts[curCommand].endsWith("\"")) { //$NON-NLS-1$
158-
// commandParts[curCommand] = commandParts[curCommand].substring(1,
159-
// commandParts[curCommand].length() - 1);
160-
// }
161-
//
162-
// }
154+
163155
myProcessBuilder = new ProcessBuilder(Arrays.asList(commandParts));
164156
myProcessBuilder.redirectErrorStream(true);
165157
}

0 commit comments

Comments
 (0)