performance improvements

instead of looking for all installable libraries I only look for the
once I need.

Author: jantje

io.sloeber.core/src/io/sloeber/core/api/LibraryManager.java

@@ -366,4 +366,16 @@ public static Map<String, io.sloeber.core.managers.Library> getAllInstallableLib
 		return ret;
 	}
 
+	public static Map<String, io.sloeber.core.managers.Library> getLatestInstallableLibraries(
+			Set<String> libnames) {
+		Set<String> remainingLibNames=new TreeSet<>(libnames);
+		Map<String, Library> ret = new HashMap<>();
+		for (LibraryIndex libraryIndex : libraryIndices) {
+			 ret.putAll(libraryIndex.getLatestInstallableLibraries(remainingLibNames));
+			 remainingLibNames.removeAll(ret.keySet());
+		}
+
+		return ret;
+	}
+
 }

io.sloeber.core/src/io/sloeber/core/managers/Library.java

@@ -17,6 +17,7 @@
 import org.eclipse.core.runtime.Status;
 
 import io.sloeber.core.Activator;
+import io.sloeber.core.common.Common;
 import io.sloeber.core.common.ConfigurationPreferences;
 import io.sloeber.core.tools.FileModifiers;
 
@@ -159,6 +160,26 @@ public boolean isInstalled() {
 		return getInstallPath().toFile().exists();
 	}
 
+	/**
+	 * checks if any version of this library is installed. Can popup a window if
+	 * there is something wrong with the folder structure
+	 *
+	 * @return false if any version is installed. true in case of error and in case
+	 *         no version is installed
+	 */
+	public boolean isAVersionInstalled() {
+		if (!getInstallPath().getParent().toFile().exists()) {
+			return false;
+		}
+		if (getInstallPath().getParent().toFile().isFile()) {
+			// something is wrong here
+			Common.log(new Status(IStatus.ERROR, Activator.getId(),
+					getInstallPath().getParent() + " is a file but it should be a directory.")); //$NON-NLS-1$
+			return false;
+		}
+		return getInstallPath().getParent().toFile().list().length > 0;
+	}
+
 	public IStatus install(IProgressMonitor monitor) {
 		monitor.setTaskName("Downloading and installing " + getName() + " library."); //$NON-NLS-1$ //$NON-NLS-2$
 		if (isInstalled()) {
@@ -215,9 +236,9 @@ public int compareTo(Library other) {
 	}
 
 	/**
-	 * delete the library This will delete all installed versions of the
-	 * library. Normally only 1 version can be installed so deleting all
-	 * versions should be delete 1 version
+	 * delete the library This will delete all installed versions of the library.
+	 * Normally only 1 version can be installed so deleting all versions should be
+	 * delete 1 version
 	 *
 	 * @param monitor
 	 * @return Status.OK_STATUS if delete is successful otherwise IStatus.ERROR

io.sloeber.core/src/io/sloeber/core/managers/LibraryIndex.java

@@ -94,15 +94,23 @@ public Map<String, Library> getLatestLibraries() {
 		return this.latestLibs;
 	}
 
+	/**
+	 * get all the latest versions of alll libraries that can be installed but are
+	 * not yet installed To do so I find all latest libraries and I remove the once
+	 * that are installed.
+	 *
+	 * @return
+	 */
 	public Map<String, Library> getLatestInstallableLibraries() {
 		Map<String, Library> ret = new HashMap<>();
 		for (Entry<String, Library> curLibrary : this.latestLibs.entrySet()) {
-			if (getInstalledLibrary(curLibrary.getKey())==null) {
+			if (!curLibrary.getValue().isAVersionInstalled()) {
 				ret.put(curLibrary.getKey(), curLibrary.getValue());
 			}
 		}
 		return ret;
 	}
+
 	public Collection<Library> getLibraries(String category) {
 		Set<String> categoryLibs = this.categories.get(category);
 		if (categoryLibs == null) {
@@ -131,4 +139,26 @@ public void setJsonFile(File packageFile) {
 	public String getName() {
 		return this.jsonFileName;
 	}
+
+	/**
+	 * get all the latest versions of alll the libraries provided that can be
+	 * installed but are not yet installed To do so I find all latest libraries and
+	 * I remove the once that are installed.
+	 *
+	 * @return
+	 */
+	public Map<String, Library> getLatestInstallableLibraries(Set<String> libNames) {
+		Map<String, Library> ret = new HashMap<>();
+		if (libNames.isEmpty()) {
+			return ret;
+		}
+		for (Entry<String, Library> curLibrary : this.latestLibs.entrySet()) {
+			if (libNames.contains(curLibrary.getKey())) {
+				if (!curLibrary.getValue().isAVersionInstalled()) {
+					ret.put(curLibrary.getKey(), curLibrary.getValue());
+				}
+			}
+		}
+		return ret;
+	}
 }

io.sloeber.core/src/io/sloeber/core/tools/Libraries.java

@@ -401,8 +401,9 @@ public static void checkLibraries(IProject affectedProject) {
 					uninstalledIncludedHeaders.removeAll(installedLibs.keySet());
 					if(!uninstalledIncludedHeaders.isEmpty()) {
 						//some libraries may need to be installed
-						Map<String, Library> availableLibs = LibraryManager.getAllInstallableLibraries();
-						availableLibs.keySet().retainAll(uninstalledIncludedHeaders);
+
+						Map<String, Library>	availableLibs=LibraryManager.getLatestInstallableLibraries(uninstalledIncludedHeaders);
+
 						if(!availableLibs.isEmpty()) {
 							//We now know which libraries to install
 							//TODO for now I just install but there should be some user
@@ -421,7 +422,13 @@ public static void checkLibraries(IProject affectedProject) {
 								+ affectedProject.getName() + ": " + installedLibs.keySet().toString())); //$NON-NLS-1$
 						addLibrariesToProject(affectedProject, configurationDescription, installedLibs);
 						try {
+							//TODO remove this logging code if this code is not causing the disrupts
+							long startTime = System.nanoTime();
 							mngr.setProjectDescription(affectedProject, projectDescription, true, null);
+							long duration = (System.nanoTime() - startTime)/ 1000000; //in miliseconds
+							if (duration>45000) {
+								Common.log(new Status(IStatus.WARNING, Const.CORE_PLUGIN_ID,"setProjectDescription took "+duration+" miliseconds!!!")); //$NON-NLS-1$ //$NON-NLS-2$
+							}
 						} catch (CoreException e) {
 							// this can fail because the project may already
 							// be