handle some TODO and TOFIX tasks

Author: jantje

io.sloeber.core/src/cc/arduino/packages/PreferencesMap.java

@@ -22,10 +22,6 @@
 package cc.arduino.packages;
 
 import java.io.File;
-import java.io.FileInputStream;
-import java.io.FileNotFoundException;
-import java.io.IOException;
-import java.io.InputStream;
 import java.util.LinkedHashMap;
 import java.util.Map;
 import java.util.SortedSet;
@@ -38,41 +34,13 @@ public PreferencesMap(Map<String, String> table) {
     super(table);
   }
 
-  /**
-   * Create a PreferencesMap and load the content of the file passed as
-   * argument.
-   *
-   * Is equivalent to:
-   *
-   * <pre>
-   * PreferencesMap map = new PreferencesMap();
-   * map.load(file);
-   * </pre>
-   *
-   * @param file
-   * @throws IOException
-   */
-  public PreferencesMap(File file) throws IOException {
-    super();
-    load(file);
-  }
+
 
   public PreferencesMap() {
     super();
   }
 
-  /**
-   * Parse a property list file and put kev/value pairs into the Map
-   *
-   * @param file
-   * @throws FileNotFoundException
-   * @throws IOException
-   */
-  public void load(File file) throws IOException {
-    try(FileInputStream fileInputStream = new FileInputStream(file);) {
-      load(fileInputStream);
-    }
-  }
+
 
   @SuppressWarnings("static-method")
 protected String processPlatformSuffix(String key, String suffix, boolean isCurrentPlatform) {
@@ -88,33 +56,7 @@ protected String processPlatformSuffix(String key, String suffix, boolean isCurr
     return key.substring(0, key.length() - suffix.length());
   }
 
-  /**
-   * Parse a property list stream and put key/value pairs into the Map
-   *
-   * @param input
-   * @throws IOException
-   */
-  public void load(InputStream input) throws IOException {
-	  //TOFIX see wether this code is used and if so what to do with it
-//    String[] lines = PApplet.loadStrings(input);
-//    for (String line : lines) {
-//      if (line.length() == 0 || line.charAt(0) == '#')
-//        continue;
-//
-//      int equals = line.indexOf('=');
-//      if (equals != -1) {
-//        String key = line.substring(0, equals).trim();
-//        String value = line.substring(equals + 1).trim();
-//
-//        key = processPlatformSuffix(key, ".linux", OSUtils.isLinux());
-//        key = processPlatformSuffix(key, ".windows", OSUtils.isWindows());
-//        key = processPlatformSuffix(key, ".macosx", OSUtils.isMacOS());
-//
-//        if (key != null)
-//          put(key, value);
-//      }
-//    }
-  }
+
 
   /**
    * Create a new PreferenceMap that contains all the top level pairs of the

io.sloeber.core/src/cc/arduino/packages/discoverers/NetworkDiscovery.java

@@ -165,7 +165,6 @@ public void stop() {
 			try {
 				this.jmdns.close();
 			} catch (IOException e) {
-				// TODO Auto-generated catch block
 				e.printStackTrace();
 			}
 		}

io.sloeber.core/src/io/sloeber/core/api/SloeberProject.java

@@ -812,7 +812,6 @@ public static synchronized SloeberProject getSloeberProject(IProject project, bo
                         return ret;
                     }
                 } catch (CoreException e) {
-                    // TODO Auto-generated catch block
                     e.printStackTrace();
                 }
                 if (!allowNull) {

io.sloeber.core/src/io/sloeber/core/common/ConfigurationPreferences.java

@@ -162,7 +162,7 @@ public static File getPostProcessingBoardsFile() {
 	}
 
 	public static String getJsonURLs() {
-		// TODO I added some code here to get easier from V3 to V4
+        // I added some code here to get easier from V3 to V4
 		// the library json url is now managed as the boards url's so it also
 		// needs to be added to the json url's
 		// this is doen in the default but people who have installed other

io.sloeber.core/src/io/sloeber/core/managers/InternalPackageManager.java

@@ -145,7 +145,6 @@ static public synchronized IStatus downloadAndInstall(ArduinoPlatform platform,
 		try {
 			Files.copy(packageFile.toPath(), copyToFile.toPath(), StandardCopyOption.REPLACE_EXISTING);
 		} catch (IOException e) {
-			// TODO Auto-generated catch block
 			e.printStackTrace();
 		}
 

io.sloeber.core/src/io/sloeber/core/tools/Helpers.java

@@ -257,7 +257,6 @@ public static void removeCodeFolder(IProject project, String LinkName) {
             try {
                 link.delete(true, null);
             } catch (CoreException e) {
-                // TODO Auto-generated catch block
                 e.printStackTrace();
             }
         }

io.sloeber.core/src/io/sloeber/core/tools/PdePreprocessor.java

@@ -154,7 +154,6 @@ public static void writeDummySloeberInoCPPFile(IProject iProject) {
                 }
             }
         } catch (CoreException e) {
-            // TODO Auto-generated catch block
             e.printStackTrace();
         }
     }

io.sloeber.core/src/io/sloeber/core/tools/uploaders/arduinoUploader.java

@@ -71,7 +71,7 @@ public boolean uploadUsingPreferences(IFile hexFile, BoardDescription boardDescr
             return false;
         }
 
-        // TODO see whether this is still needed
+        // due needs a restart after upload
         if (boardDescr.getBoardName().startsWith("Arduino Due ")) { //$NON-NLS-1$
             ArduinoSerial.reset_Arduino_by_baud_rate(boardDescr.getUploadPort(), 115200, 100);
         }

io.sloeber.tests/src/io/sloeber/core/Shared.java

@@ -269,7 +269,6 @@ public static String getProjectName(CodeDescription codeDescriptor, Examples exa
     }
 
     public static String getLastFailMessage() {
-        // TODO Auto-generated method stub
         return myLastFailMessage;
     }
 

io.sloeber.ui/src/io/sloeber/ui/Import_Libraries_Page.java

@@ -27,6 +27,7 @@
 import org.eclipse.ui.dialogs.WizardResourceImportPage;
 
 import io.sloeber.core.api.Sketch;
+import io.sloeber.core.common.Const;
 
 public class Import_Libraries_Page extends WizardResourceImportPage {
 
@@ -112,12 +113,12 @@ protected ITreeContentProvider getFolderProvider() {
 		return null;
 	}
 
+	@SuppressWarnings("restriction")
 	public boolean PerformFinish() {
 		// check if there is a incompatibility in the library folder name
 		// windows only
 		if (Platform.getOS().equals(Platform.OS_WIN32)) {
-			// TODO libraries should not be hardcoded here
-			IFolder folder = this.myProject.getFolder("libraries"); //$NON-NLS-1$
+			IFolder folder = this.myProject.getFolder(Const.LIBRARY_PATH_SUFFIX);
 			if (!folder.exists()) {
 				try {
 					folder.create(false, true, null);