Skip to content

Commit 3dff14f

Browse files
author
jantje
committed
Fix some warnings
1 parent a6682f9 commit 3dff14f

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

io.sloeber.ui/src/io/sloeber/ui/preferences/LibrarySelectionPage.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,10 @@
44
import org.eclipse.core.runtime.IStatus;
55
import org.eclipse.core.runtime.MultiStatus;
66
import org.eclipse.core.runtime.jobs.Job;
7-
import org.eclipse.jface.layout.TreeColumnLayout;
87
import org.eclipse.jface.preference.PreferencePage;
98
import org.eclipse.jface.viewers.CellLabelProvider;
109
import org.eclipse.jface.viewers.CheckboxTreeViewer;
1110
import org.eclipse.jface.viewers.ColumnViewerToolTipSupport;
12-
import org.eclipse.jface.viewers.ColumnWeightData;
1311
import org.eclipse.jface.viewers.ICheckStateProvider;
1412
import org.eclipse.jface.viewers.ITreeContentProvider;
1513
import org.eclipse.jface.viewers.TreeViewer;
@@ -255,8 +253,10 @@ public static String getColumnText(Object element, int col) {
255253
switch (col) {
256254
case 0:
257255
if (element instanceof LibraryTree.Library) {
258-
return ((LibraryTree.Library) element).getName() + " (" + ((LibraryTree.Library) element).getIndexName() + ")";
259-
}
256+
return ((LibraryTree.Library) element).getName() + " (" //$NON-NLS-1$
257+
+ ((LibraryTree.Library) element).getIndexName() + ")"; //$NON-NLS-1$
258+
}
259+
return emptyString;
260260
case 1:
261261
if (element instanceof LibraryTree.Library) {
262262
return ((LibraryTree.Library) element).getVersion();
@@ -287,10 +287,11 @@ public int getToolTipTimeDisplayed(Object object) {
287287
public void update(ViewerCell cell) {
288288
if (cell.getColumnIndex() == 0) {
289289
if (cell.getElement() instanceof LibraryTree.Library) {
290-
cell.setText(((LibraryTree.Library) cell.getElement()).getName() + " (" + ((LibraryTree.Library) cell.getElement()).getIndexName() + ")");
291-
} else {
292-
cell.setText(((Node) cell.getElement()).getName());
293-
}
290+
cell.setText(((LibraryTree.Library) cell.getElement()).getName() + " (" //$NON-NLS-1$
291+
+ ((LibraryTree.Library) cell.getElement()).getIndexName() + ")"); //$NON-NLS-1$
292+
} else {
293+
cell.setText(((Node) cell.getElement()).getName());
294+
}
294295
} else if (cell.getElement() instanceof LibraryTree.Library) {
295296
cell.setText(((LibraryTree.Library) cell.getElement()).getVersion());
296297
} else {

0 commit comments

Comments
 (0)