Handle multiple versions better (use latest) and report the situation

Author: jantje

io.sloeber.core/src/io/sloeber/core/tools/Libraries.java

@@ -108,9 +108,15 @@ public static Map<String, IPath> findAllArduinoManagerLibraries() {
 
 					String[] versions = Lib_root.toFile().list();
 					if (versions != null) {
-						if (versions.length == 1) {// There can only be 1
+						if (versions.length == 1) {// There should only be 1
 							// version of a lib
 							ret.put(curLib, Lib_root.append(versions[0]));
+						} else {// If there is more than 1 take the latest and
+								// drop a warning
+							int highestVersion = Version.getHighestVersionn(versions);
+							ret.put(curLib, Lib_root.append(versions[highestVersion]));
+							Common.log(new Status(IStatus.WARNING, Const.CORE_PLUGIN_ID,
+									Messages.MultipleVersionsOfLib.replace("${LIB}", curLib))); //$NON-NLS-1$
 						}
 					}
 				}

io.sloeber.core/src/io/sloeber/core/tools/Messages.java

@@ -4,6 +4,7 @@
 
 public class Messages extends NLS {
 	private static final String BUNDLE_NAME = "io.sloeber.core.tools.messages"; //$NON-NLS-1$
+	public static String MultipleVersionsOfLib;
 	public static String Boards_Failed_to_read_boards;
 	public static String Boards_Get_menu_item_name_from_id_did_not_find;
 	public static String Boards_name;

io.sloeber.core/src/io/sloeber/core/tools/Version.java

@@ -55,4 +55,25 @@ public static int compare(String version1, String version2) {
 		return 0;
 	}
 
+	/**
+	 * Given a list of version strings returns the index of the highest version
+	 * If the highest version is multiple times in the list the result will
+	 * point to one of those but the result may be different for each call
+	 *
+	 * @param versions
+	 *            a string list of version numbers
+	 *
+	 * @return the index to the highest version
+	 */
+	public static int getHighestVersionn(String[] versions) {
+		int returnIndex = 0;
+		for (int curVersion = 1; curVersion < versions.length; curVersion++) {
+			if (compare(versions[returnIndex], versions[curVersion]) == -1) {
+				returnIndex = curVersion;
+			}
+
+		}
+		return returnIndex;
+	}
+
 }

io.sloeber.core/src/io/sloeber/core/tools/messages.properties

@@ -30,3 +30,4 @@ import_lib_failed=Failed to import library
 security_login=login
 security_password=password
 getMenuItemIDFromMenuItemName=getMenuItemIDFromMenuItemName did not find menu item with name "${MENUITEMNAME}" for menu ID "${MENUID}" and for boardID "${BOARDID}"!
+MultipleVersionsOfLib=Multiple versions of Library ${LIB} exist on disk. This is not supported.