Moved some stuff away from Const

Working on getting rid of the const class. 
I know not the right time but I couldn't stop myself

Author: jantje

io.sloeber.core/src/io/sloeber/common/Common.java

@@ -24,7 +24,11 @@
 
 import io.sloeber.core.Activator;
 
+@SuppressWarnings("nls")
 public class Common extends Const {
+	private static final String ENV_PATTERN = "PATTERN";
+	private static final String ENV_PROTOCOL = "PROTOCOL";
+	protected static final String ENV_TOOL = "TOOL";
 
 	/**
 	 * This method makes sure that a string can be used as a file or folder name
@@ -282,4 +286,52 @@ public static void setBuildEnvironmentVariable(ICConfigurationDescription confde
 		setBuildEnvironmentVariable(contribEnv, confdesc, key, value);
 	}
 
+	/**
+	 * given a action return the environment key that matches it's protocol
+	 *
+	 * @param action
+	 * @return the environment variable key to find the protocol
+	 */
+	public static String get_ENV_KEY_PROTOCOL(String action) {
+		return ERASE_START + action.toUpperCase() + DOT + ENV_PROTOCOL;
+	}
+
+	/**
+	 * given a action return the environment key that matches it's tool
+	 *
+	 * @param action
+	 * @return the environment variable key to find the tool
+	 */
+	public static String get_ENV_KEY_TOOL(String action) {
+		return ERASE_START + action.toUpperCase() + DOT + ENV_TOOL;
+	}
+
+	/**
+	 * given a action return the environment key that matches it's recipe
+	 *
+	 * @param action
+	 * @return he environment variable key to find the recipe
+	 */
+	public static String get_ENV_KEY_RECIPE(String action) {
+		return ERASE_START + action.toUpperCase() + DOT + ENV_PATTERN;
+	}
+
+	public static String get_Jantje_KEY_PROTOCOL(String action) {
+		return ENV_KEY_JANTJE_START + action.toUpperCase() + DOT + ENV_PROTOCOL;
+	}
+
+	public static String get_Jantje_KEY_RECIPE(String action) {
+		return ENV_KEY_JANTJE_START + action.toUpperCase() + DOT + ENV_PATTERN;
+	}
+
+	/**
+	 * given a action and a tool return the environment key that matches it's
+	 * recipe
+	 *
+	 * @param action
+	 * @return he environment variable key to find the recipe
+	 */
+	public static String get_ENV_KEY_RECIPE(String tool, String action) {
+		return ERASE_START + "TOOLS" + DOT + tool.toUpperCase() + DOT + action.toUpperCase() + DOT + ENV_PATTERN; //$NON-NLS-1$
+	}
 }

io.sloeber.core/src/io/sloeber/common/ConfigurationPreferences.java

@@ -22,6 +22,8 @@
 import org.eclipse.core.runtime.preferences.IEclipsePreferences;
 import org.osgi.service.prefs.BackingStoreException;
 
+import io.sloeber.core.Activator;
+
 /**
  * Items on the Configuration level are linked to the ConfigurationScope
  * (=eclipse install base).
@@ -42,7 +44,7 @@ public class ConfigurationPreferences {
 	private static final String DEFAULT_JSON_URLS = "http://downloads.arduino.cc/packages/package_index.json" //$NON-NLS-1$
 			+ System.lineSeparator() + "http://arduino.esp8266.com/stable/package_esp8266com_index.json"; //$NON-NLS-1$
 	// preference nodes
-	public static final String NODE_ARDUINO = Const.PLUGIN_START + "arduino"; //$NON-NLS-1$
+	public static final String NODE_ARDUINO = Activator.NODE_ARDUINO;
 
 	private ConfigurationPreferences() {
 	}
@@ -139,7 +141,7 @@ public static String getDefaultBoardsPackageURLs() {
 	}
 
 	public static String[] getBoardsPackageURLList() {
-		return getBoardsPackageURLs().replaceAll(Const.RETURN, Const.EMPTY_STRING).split(stringSplitter);
+		return getBoardsPackageURLs().replace("\r", Const.EMPTY_STRING).split(stringSplitter); //$NON-NLS-1$
 	}
 
 	public static String getBoardsPackageKey() {

io.sloeber.core/src/io/sloeber/common/Const.java

@@ -16,14 +16,10 @@ public class Const {
 	public static final String SPACE = " ";
 	public static final String FALSE = "FALSE";
 	public static final String TRUE = "TRUE";
-	public static final String NEWLINE = "\n";
-	public static final String RETURN = "\r";
 	public static final String MENU = "menu";
 
 	// General stuff
-	public static final String PLUGIN_START = "io.sloeber.";
-	public static final String CORE_PLUGIN_ID = PLUGIN_START + "arduino.core";
-	protected static final String ENV_PATTERN = "PATTERN"; //$NON-NLS-1$
+	public static final String CORE_PLUGIN_ID = "io.sloeber.arduino.core";
 
 	// Actions
 	public static final String ACTION_UPLOAD = "UPLOAD";
@@ -39,10 +35,6 @@ public class Const {
 	public static final String UPLOAD_CLASS = "UPLOAD_CLASS";
 	public static final String UPLOAD_CLASS_DEFAULT = "arduinoUploader";
 
-	// Describers
-	private static final String ENV_PROTOCOL = "PROTOCOL";
-	protected static final String ENV_TOOL = "TOOL";
-
 	// properties keys
 
 	public static final String KEY_LAST_USED_EXAMPLES = "Last used Examples";
@@ -111,44 +103,6 @@ public class Const {
 
 	static final String EXAMPLE_FOLDER_NAME = "examples";
 
-	public static final String ARDUINO_NATURE_ID = PLUGIN_START + "arduinonature";
-
-	/**
-	 * given a action return the environment key that matches it's protocol
-	 *
-	 * @param action
-	 * @return the environment variable key to find the protocol
-	 */
-	public static String get_ENV_KEY_PROTOCOL(String action) {
-		return ERASE_START + action.toUpperCase() + DOT + ENV_PROTOCOL;
-	}
-
-	/**
-	 * given a action return the environment key that matches it's tool
-	 *
-	 * @param action
-	 * @return the environment variable key to find the tool
-	 */
-	public static String get_ENV_KEY_TOOL(String action) {
-		return ERASE_START + action.toUpperCase() + DOT + ENV_TOOL;
-	}
-
-	/**
-	 * given a action return the environment key that matches it's recipe
-	 *
-	 * @param action
-	 * @return he environment variable key to find the recipe
-	 */
-	public static String get_ENV_KEY_RECIPE(String action) {
-		return ERASE_START + action.toUpperCase() + DOT + ENV_PATTERN;
-	}
-
-	public static String get_Jantje_KEY_PROTOCOL(String action) {
-		return ENV_KEY_JANTJE_START + action.toUpperCase() + DOT + ENV_PROTOCOL;
-	}
-
-	public static String get_Jantje_KEY_RECIPE(String action) {
-		return ENV_KEY_JANTJE_START + action.toUpperCase() + DOT + ENV_PATTERN;
-	}
+	public static final String ARDUINO_NATURE_ID = "io.sloeber.arduinonature";
 
 }