Fixing warnings cause by eclipse upgrade

Author: jantje

io.sloeber.core/src/io/sloeber/core/Activator.java

@@ -6,6 +6,7 @@
 import java.io.InputStream;
 import java.net.MalformedURLException;
 import java.net.URL;
+import java.nio.charset.Charset;
 
 import org.apache.commons.io.IOUtils;
 import org.eclipse.cdt.core.CCorePlugin;
@@ -415,7 +416,7 @@ static boolean isPatron() {
 
 		try {
 			URL url = new URL(HELP_LOC + "?systemhash=" + systemhash);
-			String content= IOUtils.toString( url);
+			String content= IOUtils.toString( url, Charset.defaultCharset());
 			isPatron = new Boolean(content.length() < 1000);
 
 		} catch ( Exception e) {

io.sloeber.core/src/io/sloeber/core/common/IndexHelper.java

@@ -2,6 +2,7 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.nio.charset.Charset;
 
 import org.apache.commons.io.FileUtils;
 import org.eclipse.cdt.core.CCorePlugin;
@@ -34,7 +35,7 @@ private static String findParameterInFunction(IIndexName[] names, String functio
 			String codeFileName = name.getFileLocation().getFileName();
 			String rawCodeFileContent;
 			try {
-				rawCodeFileContent = FileUtils.readFileToString(new File(codeFileName));
+				rawCodeFileContent = FileUtils.readFileToString(new File(codeFileName), Charset.defaultCharset());
 			} catch (IOException e) {
 				return defaultValue;
 			}

io.sloeber.core/src/io/sloeber/core/tools/FileModifiers.java

@@ -2,6 +2,7 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.nio.charset.Charset;
 import java.nio.file.FileVisitResult;
 import java.nio.file.Files;
 import java.nio.file.Paths;
@@ -29,8 +30,8 @@ public class FileModifiers {
 	 * @throws IOException
 	 */
 	public static void appendString(File input, String addString) throws IOException {
-		String fileString = FileUtils.readFileToString(input)  +addString;
-		FileUtils.write(input, fileString);
+		String fileString = FileUtils.readFileToString(input, Charset.defaultCharset())  +addString;
+		FileUtils.write(input, fileString, Charset.defaultCharset());
 	}
 
 	/**
@@ -95,14 +96,14 @@ public FileVisitResult visitFileFailed(java.nio.file.Path file, IOException exc)
 
 	public static void replaceInFile(File file, boolean regex, String find, String replace) {
 		try {
-			String textFromFile = FileUtils.readFileToString(file);
+			String textFromFile = FileUtils.readFileToString(file, Charset.defaultCharset());
 
 			if (regex) {
 				textFromFile = textFromFile.replaceAll(find, replace);
 			} else {
 				textFromFile = textFromFile.replace(find, replace);
 			}
-			FileUtils.write(file, textFromFile);
+			FileUtils.write(file, textFromFile, Charset.defaultCharset());
 		} catch (IOException e) {
 			Common.log(new Status(IStatus.WARNING, Activator.getId(),
 					"Failed to replace "+find+" with "+replace+" in file "+file.toString(), e)); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$

io.sloeber.core/src/io/sloeber/core/tools/PdePreprocessor.java

@@ -21,6 +21,7 @@
 
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
+import java.nio.charset.Charset;
 import java.text.SimpleDateFormat;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -145,7 +146,7 @@ private static void writeTheGeneratedFile(IProject iProject, String content) thr
 		String currentFileContent = null;
 		try {
 			currentFileContent = FileUtils
-					.readFileToString(iProject.getFile(new Path(generatedFile)).getLocation().toFile());
+					.readFileToString(iProject.getFile(new Path(generatedFile)).getLocation().toFile(), Charset.defaultCharset());
 		} catch (IOException e) {
 			// This happens when the generated file does not yet exist
 		}

io.sloeber.core/src/io/sloeber/core/tools/ShouldHaveBeenInCDT.java

@@ -19,7 +19,6 @@
 import org.eclipse.cdt.managedbuilder.internal.core.Configuration;
 import org.eclipse.cdt.managedbuilder.internal.core.ManagedBuildInfo;
 import org.eclipse.cdt.managedbuilder.internal.core.ManagedProject;
-import org.eclipse.cdt.managedbuilder.internal.core.ToolChain;
 import org.eclipse.core.resources.IProject;
 import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.IProgressMonitor;
@@ -69,7 +68,7 @@ public static ICProjectDescription setCProjectDescription(IProject project,
 		for (ConfigurationDescriptor curConfDesc : alCfgs) {
 			IToolChain tcs = ManagedBuildManager.getExtensionToolChain(curConfDesc.ToolchainID);
 
-			Configuration cfg = new Configuration(mProj, (ToolChain) tcs,
+			Configuration cfg = new Configuration(mProj, tcs,
 					ManagedBuildManager.calculateChildId(curConfDesc.ToolchainID, null), curConfDesc.configName);
 			if (enableParallelBuild) {
 				cfg.setParallelDef(true);

io.sloeber.ui/src/io/sloeber/ui/monitor/views/SerialMonitor.java

@@ -2,6 +2,7 @@
 
 import java.io.File;
 import java.net.URL;
+import java.nio.charset.Charset;
 import java.util.ArrayList;
 import java.util.LinkedHashMap;
 import java.util.List;
@@ -322,7 +323,7 @@ public void mouseDown(MouseEvent e) {
                                 String activeConfigName= activeCfg.getName();
                                 IPath buildFolder=selectedProject.findMember(activeConfigName).getLocation();
                                 File dumpFile=buildFolder.append("serialdump.txt").toFile(); //$NON-NLS-1$
-                                FileUtils.writeStringToFile(dumpFile, selectedText);
+                                FileUtils.writeStringToFile(dumpFile, selectedText, Charset.defaultCharset());
                             } catch (Exception e1) {
                                 // ignore
                                 e1.printStackTrace();