replaced EMPTY_STRING by new String()

Author: jantje

io.sloeber.ui/src/io/sloeber/ui/PasswordDialog.java

@@ -17,85 +17,84 @@
 import org.eclipse.swt.widgets.Text;
 
 public class PasswordDialog extends Dialog {
-    private static String EMPTY_STRING = ""; //$NON-NLS-1$
-    private Text txtUser;
-    private Text txtPassword;
-    private String myUser = EMPTY_STRING;
-    private String myPassword = EMPTY_STRING;
-    private String myHost = Messages.error_no_host_name;
-
-    public PasswordDialog(Shell parentShell) {
-	super(parentShell);
-    }
-
-    @Override
-    protected Control createDialogArea(Composite parent) {
-	parent.getShell().setText(Messages.ui_sec_login_and_password + this.myHost);
-	Composite container = (Composite) super.createDialogArea(parent);
-	GridLayout layout = new GridLayout(2, false);
-	layout.marginRight = 5;
-	layout.marginLeft = 10;
-	container.setLayout(layout);
-
-	Label lblUser = new Label(container, SWT.NONE);
-	lblUser.setText(Messages.ui_sec_login + ':');
-
-	this.txtUser = new Text(container, SWT.BORDER);
-	this.txtUser.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, true, false, 1, 1));
-	this.txtUser.setText(this.myUser);
-
-	Label lblPassword = new Label(container, SWT.NONE);
-	GridData gd_lblNewLabel = new GridData(SWT.LEFT, SWT.CENTER, false, false, 1, 1);
-	gd_lblNewLabel.horizontalIndent = 1;
-	lblPassword.setLayoutData(gd_lblNewLabel);
-	lblPassword.setText(Messages.ui_sec_password + ':');
-
-	this.txtPassword = new Text(container, SWT.BORDER);
-	this.txtPassword.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, true, false, 1, 1));
-	this.txtPassword.setText(this.myPassword);
-
-	return container;
-    }
-
-    // override method to use "Login" as label for the OK button
-    @Override
-    protected void createButtonsForButtonBar(Composite parent) {
-	createButton(parent, IDialogConstants.OK_ID, Messages.ui_sec_login, true);
-	createButton(parent, IDialogConstants.CANCEL_ID, IDialogConstants.CANCEL_LABEL, false);
-    }
-
-    @Override
-    protected Point getInitialSize() {
-	return new Point(450, 300);
-    }
-
-    @Override
-    protected void okPressed() {
-	// Copy data from SWT widgets into fields on button press.
-	// Reading data from the widgets later will cause an SWT
-	// widget disposed exception.
-	this.myUser = this.txtUser.getText();
-	this.myPassword = this.txtPassword.getText();
-	super.okPressed();
-    }
-
-    public String getUser() {
-	return this.myUser;
-    }
-
-    public void setUser(String user) {
-	this.myUser = user;
-    }
-
-    public String getPassword() {
-	return this.myPassword;
-    }
-
-    public void setPassword(String password) {
-	this.myPassword = password;
-    }
-
-    public void sethost(String host) {
-	this.myHost = host;
-    }
+	private Text txtUser;
+	private Text txtPassword;
+	private String myUser = new String();
+	private String myPassword = new String();
+	private String myHost = Messages.error_no_host_name;
+
+	public PasswordDialog(Shell parentShell) {
+		super(parentShell);
+	}
+
+	@Override
+	protected Control createDialogArea(Composite parent) {
+		parent.getShell().setText(Messages.ui_sec_login_and_password + this.myHost);
+		Composite container = (Composite) super.createDialogArea(parent);
+		GridLayout layout = new GridLayout(2, false);
+		layout.marginRight = 5;
+		layout.marginLeft = 10;
+		container.setLayout(layout);
+
+		Label lblUser = new Label(container, SWT.NONE);
+		lblUser.setText(Messages.ui_sec_login + ':');
+
+		this.txtUser = new Text(container, SWT.BORDER);
+		this.txtUser.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, true, false, 1, 1));
+		this.txtUser.setText(this.myUser);
+
+		Label lblPassword = new Label(container, SWT.NONE);
+		GridData gd_lblNewLabel = new GridData(SWT.LEFT, SWT.CENTER, false, false, 1, 1);
+		gd_lblNewLabel.horizontalIndent = 1;
+		lblPassword.setLayoutData(gd_lblNewLabel);
+		lblPassword.setText(Messages.ui_sec_password + ':');
+
+		this.txtPassword = new Text(container, SWT.BORDER);
+		this.txtPassword.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, true, false, 1, 1));
+		this.txtPassword.setText(this.myPassword);
+
+		return container;
+	}
+
+	// override method to use "Login" as label for the OK button
+	@Override
+	protected void createButtonsForButtonBar(Composite parent) {
+		createButton(parent, IDialogConstants.OK_ID, Messages.ui_sec_login, true);
+		createButton(parent, IDialogConstants.CANCEL_ID, IDialogConstants.CANCEL_LABEL, false);
+	}
+
+	@Override
+	protected Point getInitialSize() {
+		return new Point(450, 300);
+	}
+
+	@Override
+	protected void okPressed() {
+		// Copy data from SWT widgets into fields on button press.
+		// Reading data from the widgets later will cause an SWT
+		// widget disposed exception.
+		this.myUser = this.txtUser.getText();
+		this.myPassword = this.txtPassword.getText();
+		super.okPressed();
+	}
+
+	public String getUser() {
+		return this.myUser;
+	}
+
+	public void setUser(String user) {
+		this.myUser = user;
+	}
+
+	public String getPassword() {
+		return this.myPassword;
+	}
+
+	public void setPassword(String password) {
+		this.myPassword = password;
+	}
+
+	public void sethost(String host) {
+		this.myHost = host;
+	}
 }