Skip to content

Commit f2fa83e

Browse files
author
jantje
committed
#497 I now assume that a reset is not needed when using a programmer
1 parent 303ee91 commit f2fa83e

File tree

2 files changed

+19
-10
lines changed

2 files changed

+19
-10
lines changed

it.baeyens.arduino.core/src/it/baeyens/arduino/tools/uploaders/UploadSketchWrapper.java

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -157,21 +157,27 @@ public UploadJobWrapper(String name, IProject project, String cConf, IRealUpload
157157
@Override
158158
protected IStatus run(IProgressMonitor monitor) {
159159
boolean WeStoppedTheComPort = false;
160-
String myComPort = Const.EMPTY_STRING;
160+
String comPort = Const.EMPTY_STRING;
161161
try {
162-
monitor.beginTask(Messages.Upload_uploading + " \"" + this.myProject.getName() + "\" " + this.myNAmeTag, //$NON-NLS-1$//$NON-NLS-2$
163-
2);
164-
myComPort = Common.getBuildEnvironmentVariable(this.myProject, this.myCConf,
165-
Const.ENV_KEY_JANTJE_COM_PORT, ""); //$NON-NLS-1$
162+
String message = Messages.Upload_uploading;
163+
message += " \"" + this.myProject.getName() + "\" "; //$NON-NLS-1$//$NON-NLS-2$
164+
message += this.myNAmeTag + Const.SPACE;
165+
// message+= this.+Const.SPACE;
166+
monitor.beginTask(message, 2);
167+
comPort = Common.getBuildEnvironmentVariable(this.myProject, this.myCConf,
168+
Const.ENV_KEY_JANTJE_COM_PORT, Const.EMPTY_STRING);
169+
String programmer = Common.getBuildEnvironmentVariable(this.myProject, this.myCConf,
170+
Const.get_Jantje_KEY_PROTOCOL(Const.ACTION_UPLOAD), Const.DEFAULT);
166171

167172
try {
168-
WeStoppedTheComPort = Common.StopSerialMonitor(myComPort);
173+
WeStoppedTheComPort = Common.StopSerialMonitor(comPort);
169174
} catch (Exception e) {
170175
Common.log(new Status(IStatus.WARNING, Const.CORE_PLUGIN_ID, Messages.Upload_Error_com_port, e));
171176
}
172177
IFile hexFile = this.myProject
173178
.getFile(new Path(this.myCConf).append(this.myProject.getName() + ".hex")); //$NON-NLS-1$
174-
if (this.myUploader.uploadUsingPreferences(hexFile, false, monitor)) {
179+
if (this.myUploader.uploadUsingPreferences(hexFile, !programmer.equalsIgnoreCase(Const.DEFAULT),
180+
monitor)) {
175181
UploadSketchWrapper.this.myHighLevelConsoleStream.println(Messages.Upload_Done);
176182
} else {
177183
UploadSketchWrapper.this.myHighLevelConsoleStream.println(Messages.Upload_failed_upload);
@@ -182,7 +188,7 @@ protected IStatus run(IProgressMonitor monitor) {
182188
} finally {
183189
try {
184190
if (WeStoppedTheComPort) {
185-
Common.StartSerialMonitor(myComPort);
191+
Common.StartSerialMonitor(comPort);
186192
}
187193
} catch (Exception e) {
188194
Common.log(new Status(IStatus.WARNING, Const.CORE_PLUGIN_ID,

it.baeyens.arduino.core/src/it/baeyens/arduino/tools/uploaders/arduinoUploader.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,11 @@ public boolean uploadUsingPreferences(IFile hexFile, boolean usingProgrammer, IP
5454
.getValue().equalsIgnoreCase(Const.TRUE);
5555
} catch (Exception e) {// ignore all errors
5656
}
57-
String NewSerialPort = ArduinoSerial.makeArduinoUploadready(this.myConsole.newMessageStream(), this.myProject,
58-
this.mycConf, MComPort);
57+
String NewSerialPort = MComPort;
58+
if (!usingProgrammer) {
59+
NewSerialPort = ArduinoSerial.makeArduinoUploadready(this.myConsole.newMessageStream(), this.myProject,
60+
this.mycConf, MComPort);
61+
}
5962

6063
IEnvironmentVariable var = new EnvironmentVariable(Const.ENV_KEY_JANTJE_COM_PORT, NewSerialPort);
6164
contribEnv.addVariable(var, configurationDescription);

0 commit comments

Comments
 (0)