remove convenient method

Author: jantje

io.sloeber.core/src/io/sloeber/core/api/SloeberProject.java

@@ -477,16 +477,6 @@ private static void setEnvVars(ICConfigurationDescription confDesc, Map<String,
         }
     }
 
-    /**
-     * get the Arduino project description based on a project description
-     * Convenience method for getSloeberProject(project, false);
-     * 
-     * @param project
-     * @return
-     */
-    public static synchronized SloeberProject getSloeberProject(IProject project) {
-        return getSloeberProject(project, false);
-    }
 
     /**
      * get the Arduino project description based on a project description

io.sloeber.core/src/io/sloeber/core/tools/Libraries.java

@@ -113,7 +113,7 @@ private static Map<String, IPath> findAllSubFolders(IPath ipath) {
     private static Map<String, IPath> findAllHarwareLibraries(ICConfigurationDescription confDesc) {
         Map<String, IPath> ret = new HashMap<>();
         IProject project = confDesc.getProjectDescription().getProject();
-        SloeberProject sProject = SloeberProject.getSloeberProject(project);
+        SloeberProject sProject = SloeberProject.getSloeberProject(project, false);
         BoardDescription boardDescriptor = sProject.getBoardDescription(confDesc, false);
         // first add the referenced
         IPath libPath = boardDescriptor.getReferencedLibraryPath();

io.sloeber.core/src/io/sloeber/core/tools/uploaders/UploadSketchWrapper.java

@@ -56,7 +56,7 @@ static public Job upload(IProject Project,
     private Job internalUpload(IProject project,
 			ICConfigurationDescription confDesc) {
 
-        SloeberProject sProject = SloeberProject.getSloeberProject(project);
+        SloeberProject sProject = SloeberProject.getSloeberProject(project, false);
         BoardDescription boardDescriptor = sProject.getBoardDescription(confDesc, false);
 
         String UpLoadTool = boardDescriptor.getActualUploadTool();

io.sloeber.tests/src/io/sloeber/core/RegressionTest.java

@@ -104,7 +104,7 @@ public void issue555() {
             e.printStackTrace();
             fail("Failed to compile the project:" + unoBoardid.getBoardName() + " as uno exception");
         }
-        SloeberProject arduinoProject = SloeberProject.getSloeberProject(theTestProject);
+        SloeberProject arduinoProject = SloeberProject.getSloeberProject(theTestProject, false);
         ICProjectDescription cProjectDescription = CCorePlugin.getDefault().getProjectDescription(theTestProject);
         arduinoProject.setBoardDescription(cProjectDescription.getActiveConfiguration(), teensyBoardid, true);
 
@@ -348,7 +348,7 @@ public void openAndClosePreservesSettings() throws Exception {
 
         // Read the data we want to test
         Shared.waitForAllJobsToFinish(); // for the indexer
-        SloeberProject sloeberDesc = SloeberProject.getSloeberProject(theTestProject);
+        SloeberProject sloeberDesc = SloeberProject.getSloeberProject(theTestProject, false);
         ICProjectDescription projDesc = CoreModel.getDefault().getProjectDescription(theTestProject);
         ICConfigurationDescription confDesc = projDesc.getActiveConfiguration();
         BoardDescription createdBoardDesc = sloeberDesc.getBoardDescription(confDesc, false);
@@ -363,7 +363,7 @@ public void openAndClosePreservesSettings() throws Exception {
         Shared.waitForAllJobsToFinish();
 
         // read the data we want to test
-        sloeberDesc = SloeberProject.getSloeberProject(theTestProject);
+        sloeberDesc = SloeberProject.getSloeberProject(theTestProject, false);
         projDesc = CoreModel.getDefault().getProjectDescription(theTestProject);
         confDesc = projDesc.getActiveConfiguration();
         BoardDescription reopenedBoardDesc = sloeberDesc.getBoardDescription(confDesc, false);
@@ -448,13 +448,13 @@ public void openAndCloseUsesSavedSettings() throws Exception {
 
         // Read the data we want to test
         Shared.waitForAllJobsToFinish(); // for the indexer
-        SloeberProject proj1SloeberDesc = SloeberProject.getSloeberProject(proj1);
+        SloeberProject proj1SloeberDesc = SloeberProject.getSloeberProject(proj1, false);
         ICProjectDescription proj1Desc = CoreModel.getDefault().getProjectDescription(proj1);
         ICConfigurationDescription proj1ConfDesc = proj1Desc.getActiveConfiguration();
         BoardDescription proj1CreatedBoardDesc = proj1SloeberDesc.getBoardDescription(proj1ConfDesc, false);
         CompileDescription proj1CreatedCompileDesc = proj1SloeberDesc.getCompileDescription(proj1ConfDesc, false);
 
-        SloeberProject proj2SloeberDesc = SloeberProject.getSloeberProject(proj2);
+        SloeberProject proj2SloeberDesc = SloeberProject.getSloeberProject(proj2, false);
         ICProjectDescription proj2Desc = CoreModel.getDefault().getProjectDescription(proj2);
         ICConfigurationDescription proj2ConfDesc = proj2Desc.getActiveConfiguration();
         BoardDescription proj2CreatedBoardDesc = proj2SloeberDesc.getBoardDescription(proj2ConfDesc, false);
@@ -482,7 +482,7 @@ public void openAndCloseUsesSavedSettings() throws Exception {
         Shared.waitForAllJobsToFinish();
 
         // reread project 2
-        proj2SloeberDesc = SloeberProject.getSloeberProject(proj2);
+        proj2SloeberDesc = SloeberProject.getSloeberProject(proj2, false);
         proj2Desc = CoreModel.getDefault().getProjectDescription(proj2);
         proj2ConfDesc = proj2Desc.getActiveConfiguration();
         BoardDescription proj2OpenedBoardDesc = proj2SloeberDesc.getBoardDescription(proj2ConfDesc, false);

io.sloeber.ui/src/io/sloeber/ui/actions/OpenSerialMonitorHandler.java

@@ -43,13 +43,15 @@ public Object execute(ExecutionEvent event) throws ExecutionException {
 				for (IProject curproject : SelectedProjects) {
 					int baud = Sketch.getCodeBaudRate(curproject);
 					if (baud > 0) {
-						SloeberProject sProject=SloeberProject.getSloeberProject(curproject);
-						ICConfigurationDescription activeConf = CoreModel.getDefault().getProjectDescription(curproject)
-								.getActiveConfiguration();
-						BoardDescription boardDescription = sProject.getBoardDescription(activeConf, false);
-						String comPort = boardDescription.getUploadPort();
-						if (!comPort.isEmpty()) {
-							io.sloeber.ui.monitor.SerialConnection.add(comPort, baud);
+						SloeberProject sProject = SloeberProject.getSloeberProject(curproject, true);
+						if (sProject != null) {
+							ICConfigurationDescription activeConf = CoreModel.getDefault()
+									.getProjectDescription(curproject).getActiveConfiguration();
+							BoardDescription boardDescription = sProject.getBoardDescription(activeConf, false);
+							String comPort = boardDescription.getUploadPort();
+							if (!comPort.isEmpty()) {
+								io.sloeber.ui.monitor.SerialConnection.add(comPort, baud);
+							}
 						}
 					}
 				}

io.sloeber.ui/src/io/sloeber/ui/project/properties/SloeberCpropertyTab.java

@@ -48,7 +48,7 @@ public void createControls(Composite parent, ICPropertyProvider provider) {
 		// This is needed so that when a copy is made
 		// the root compile description is known
 		ICProjectDescription projDesc = getConfdesc().getProjectDescription();
-		mySloeberProject = SloeberProject.getSloeberProject(projDesc.getProject());
+		mySloeberProject = SloeberProject.getSloeberProject(projDesc.getProject(), false);
 		for (ICConfigurationDescription curConfig : projDesc.getConfigurations()) {
 			Object description = getFromSloeber(curConfig);
 			if (description == null) {