fix(ci): Fix tier pattern analysis workflow shell errors

Resolves bash conditional errors in tier-pattern-analysis.yml:
- Fixed "[: too many arguments" error by removing bc dependency
- Use awk for floating point comparison instead of bc
- Add head -n1 to ensure single value extraction
- Add regex validation for SAVINGS variable
- Properly quote $GITHUB_OUTPUT variable references
- Add fallback to 0 if extraction fails

This fixes the workflow errors:
- "Error: Unable to process file command 'output' successfully"
- "Error: Invalid format '81.2'"
- "[: too many arguments" on line 55

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>

Author: 2 people

.github/workflows/tier-pattern-analysis.yml

@@ -47,16 +47,23 @@ jobs:
         id: check
         run: |
           # Extract savings percentage from report
-          SAVINGS=$(grep "Savings percentage:" pattern_analysis_report.txt | awk '{print $3}' | tr -d '%')
+          SAVINGS=$(grep "Savings percentage:" pattern_analysis_report.txt | awk '{print $3}' | tr -d '%' | head -n1)
+
+          # Validate SAVINGS is a number
+          if ! [[ "$SAVINGS" =~ ^[0-9]+\.?[0-9]*$ ]]; then
+            echo "Warning: Could not extract valid savings percentage, defaulting to 0"
+            SAVINGS="0"
+          fi
+
           echo "Current savings: $SAVINGS%"
-          echo "savings=$SAVINGS" >> $GITHUB_OUTPUT
+          echo "savings=$SAVINGS" >> "$GITHUB_OUTPUT"
 
-          # Set alert if savings drop below 85%
-          if [ $(echo "$SAVINGS < 85" | bc) -eq 1 ]; then
-            echo "alert=true" >> $GITHUB_OUTPUT
+          # Set alert if savings drop below 85% (using awk for floating point comparison)
+          if awk "BEGIN {exit !($SAVINGS < 85)}"; then
+            echo "alert=true" >> "$GITHUB_OUTPUT"
             echo "⚠️  Savings dropped below 85%!"
           else
-            echo "alert=false" >> $GITHUB_OUTPUT
+            echo "alert=false" >> "$GITHUB_OUTPUT"
             echo "✅ Savings healthy at $SAVINGS%"
           fi