Skip to content
This repository was archived by the owner on Jan 11, 2019. It is now read-only.

Commit fca667d

Browse files
committed
upgraded swagger dependencies and fixed bug creating sample responses when no produces was specified at the operation level
1 parent 4edca13 commit fca667d

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@
5252

5353
<properties>
5454
<jackson-version>2.4.2</jackson-version>
55-
<swagger-version>1.5.9</swagger-version>
56-
<swagger-parser.version>1.0.21</swagger-parser.version>
57-
<swagger-inflector.version>1.0.8</swagger-inflector.version>
55+
<swagger-version>1.5.10</swagger-version>
56+
<swagger-parser.version>1.0.22</swagger-parser.version>
57+
<swagger-inflector.version>1.0.10</swagger-inflector.version>
5858
<readyapi-version>1.9.0</readyapi-version>
5959
</properties>
6060

src/main/groovy/com/smartbear/swagger/Swagger2Importer.groovy

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import com.eviware.soapui.impl.rest.support.RestParameter
2727
import com.eviware.soapui.impl.rest.support.RestParamsPropertyHolder.ParameterStyle
2828
import com.eviware.soapui.impl.wsdl.WsdlProject
2929
import com.eviware.soapui.support.StringUtils
30+
import com.eviware.soapui.support.xml.XmlUtils
3031
import com.fasterxml.jackson.databind.ObjectMapper
3132
import com.fasterxml.jackson.databind.module.SimpleModule
3233
import io.swagger.inflector.examples.ExampleBuilder
@@ -216,7 +217,7 @@ class Swagger2Importer implements SwaggerImporter {
216217

217218
def consumes = operation.consumes
218219
if (consumes == null || consumes.empty) {
219-
consumes = ["application/json"]
220+
consumes = swagger.consumes
220221
}
221222

222223
consumes.each {
@@ -255,6 +256,10 @@ class Swagger2Importer implements SwaggerImporter {
255256
operation.responses?.each {
256257
def response = it
257258

259+
if (operation.produces == null || operation.produces.empty){
260+
operation.produces = swagger.produces
261+
}
262+
258263
if (operation.produces == null || operation.produces.empty) {
259264
def representation = method.addNewRepresentation(RestRepresentation.Type.RESPONSE)
260265

@@ -307,13 +312,13 @@ class Swagger2Importer implements SwaggerImporter {
307312
def mapper = null
308313

309314
switch (mediaType) {
310-
case "application/xml": sampleValue = new XmlExampleSerializer().serialize(output); break;
315+
case "application/xml": sampleValue = XmlUtils.prettyPrintXml(new XmlExampleSerializer().serialize(output)); break;
311316
case "application/yaml": mapper = yamlMapper; break;
312317
case "application/json": mapper = jsonMapper; break;
313318
}
314319

315320
if (mapper != null) {
316-
sampleValue = mapper.writer().writeValueAsString(output)
321+
sampleValue = mapper.writerWithDefaultPrettyPrinter().writeValueAsString(output)
317322
}
318323
return sampleValue
319324
}

0 commit comments

Comments
 (0)