New characteristic updated signature (Supports async)

Author: jdomnitz

ExampleClient/Program.cs

@@ -42,10 +42,11 @@ private static async Task Main(string[] args)
         Console.ReadLine();
     }
 
-    private static void ConfiguredName_Updated(object? sender, string? newValue)
+    private static Task ConfiguredName_Updated(Service service, StringCharacteristic characteristic, string? newValue)
     {
-        Console.WriteLine("Previous Name: " + ((ConfiguredName)sender!).LastValue);
+        Console.WriteLine("Previous Name: " + ((ConfiguredName)characteristic).LastValue);
         Console.WriteLine("New Value: " + newValue);
         //After this event is handled, LastValue is set to newValue
+        return Task.CompletedTask;
     }
 }

HomeKitDotNet/Models/Characteristic.cs

@@ -17,7 +17,8 @@ namespace HomeKitDotNet.Models
 {
     public class Characteristic<T> : CharacteristicBase where T : struct
     {
-        public event EventHandler<T?>? Updated;
+        public delegate Task AsyncEventHandler<TEventArgs>(Service service, Characteristic<TEventArgs> characteristic, TEventArgs? newValue) where TEventArgs : struct;
+        public event AsyncEventHandler<T>? Updated;
         protected Characteristic(Service service, CharacteristicJSON json) : base(service, json)
         {
             this.LastValue = MapValue(json.Value);
@@ -52,6 +53,8 @@ protected async Task<bool> Write(T value)
         {
             if (value.HasValue)
             {
+                if (typeof(T).IsEnum && Enum.GetUnderlyingType(typeof(T)) == typeof(byte) && value.Value.ValueKind == JsonValueKind.Number)
+                    return (T)(object)value.Value.GetByte();
                 if (typeof(T) == typeof(float) && value.Value.ValueKind == JsonValueKind.Number)
                     return (T)(object)value.Value.GetSingle();
                 else if (typeof(T) == typeof(int) && value.Value.ValueKind == JsonValueKind.Number)
@@ -81,7 +84,7 @@ internal override void FireUpdate(JsonElement? value)
         {
             T? newVal = MapValue(value);
             if (Updated != null)
-                Updated.Invoke(this, newVal);
+                Updated.Invoke(service, this, newVal);
             LastValue = newVal;
         }
 

HomeKitDotNet/Models/StringCharacteristic.cs

@@ -5,7 +5,8 @@ namespace HomeKitDotNet.Models
 {
     public class StringCharacteristic : CharacteristicBase
     {
-        public event EventHandler<string?>? Updated;
+        public delegate Task AsyncEventHandler(Service service, StringCharacteristic characteristic, string? newValue);
+        public event AsyncEventHandler? Updated;
         protected StringCharacteristic(Service service, CharacteristicJSON json) : base(service, json)
         {
             LastValue = MapValue(json.Value);
@@ -53,7 +54,7 @@ internal override void FireUpdate(JsonElement? value)
         {
             string? newVal = MapValue(value);
             if (Updated != null)
-                Updated.Invoke(this, newVal);
+                Updated.Invoke(service, this, newVal);
             LastValue = newVal;
         }