Skip to content

Commit 099f0ec

Browse files
authored
fix the settings for terminal timeout (RooCodeInc#4153)
* base * changeset
1 parent e35428a commit 099f0ec

File tree

4 files changed

+5
-42
lines changed

4 files changed

+5
-42
lines changed

.changeset/real-clouds-act.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"claude-dev": patch
3+
---
4+
5+
fix menu for setting terminal timeout

proto/state.proto

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ service StateService {
1111
rpc toggleFavoriteModel(StringRequest) returns (Empty);
1212
rpc resetState(EmptyRequest) returns (Empty);
1313
rpc togglePlanActMode(TogglePlanActModeRequest) returns (Empty);
14-
rpc updateTerminalConnectionTimeout(Int64Request) returns (Int64);
1514
rpc updateAutoApprovalSettings(AutoApprovalSettingsRequest) returns (Empty);
1615
rpc updateSettings(UpdateSettingsRequest) returns (Empty);
1716
}

src/core/controller/state/updateTerminalConnectionTimeout.ts

Lines changed: 0 additions & 27 deletions
This file was deleted.

webview-ui/src/components/settings/TerminalSettingsSection.tsx

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
import React, { useState } from "react"
22
import { VSCodeTextField, VSCodeCheckbox } from "@vscode/webview-ui-toolkit/react"
33
import { useExtensionState } from "@/context/ExtensionStateContext"
4-
import { StateServiceClient } from "@/services/grpc-client"
5-
import { Int64, Int64Request } from "@shared/proto/common"
64

75
export const TerminalSettingsSection: React.FC = () => {
86
const { shellIntegrationTimeout, setShellIntegrationTimeout, terminalReuseEnabled, setTerminalReuseEnabled } =
@@ -27,18 +25,6 @@ export const TerminalSettingsSection: React.FC = () => {
2725

2826
// Update local state
2927
setShellIntegrationTimeout(timeout)
30-
31-
// Send to extension using gRPC
32-
StateServiceClient.updateTerminalConnectionTimeout({
33-
value: timeout,
34-
} as Int64Request)
35-
.then((response: Int64) => {
36-
setShellIntegrationTimeout(response.value)
37-
setInputValue((response.value / 1000).toString())
38-
})
39-
.catch((error) => {
40-
console.error("Failed to update terminal connection timeout:", error)
41-
})
4228
}
4329

4430
const handleInputBlur = () => {

0 commit comments

Comments
 (0)