Terminal profile setting (RooCodeInc#4079)

* feat: Added a configurable default terminal profile setting

* chore: format

* refactor: migrate terminal profiles to gRPC and remove legacy message handling

- rename AvailableTerminalProfilesResponse to TerminalProfiles in proto
- remove duplicate TerminalProfile type from terminal_types.ts
- update all imports to use TerminalProfile from proto/state
- remove legacy availableTerminalProfiles message handling from ExtensionStateContext
- clean up ExtensionMessage type by removing unused availableTerminalProfiles
- translate Spanish comment to English in TerminalSettingsSection
- update server-side getAvailableTerminalProfiles to use new proto type

* chore: lint

* fix: merge main

* fix: resolve errors

* chore: notify terminal profile settings

* chore: merge main

* feat: improve default terminal profile changes

* fix: update changes on save

Author: valinha

.changeset/nice-trees-ring.md

@@ -0,0 +1,5 @@
+---
+"claude-dev": minor
+---
+
+Added a configurable default terminal profile setting

proto/state.proto

@@ -7,6 +7,10 @@ import "common.proto";
 
 service StateService {
   rpc getLatestState(EmptyRequest) returns (State);
+  rpc updateTerminalConnectionTimeout(Int64Request) returns (Int64);
+  rpc updateTerminalReuseEnabled(BooleanRequest) returns (Empty);
+  rpc updateDefaultTerminalProfile(StringRequest) returns (TerminalProfileUpdateResponse);
+  rpc getAvailableTerminalProfiles(EmptyRequest) returns (TerminalProfiles);
   rpc subscribeToState(EmptyRequest) returns (stream State);
   rpc toggleFavoriteModel(StringRequest) returns (Empty);
   rpc resetState(EmptyRequest) returns (Empty);
@@ -19,6 +23,23 @@ message State {
   string state_json = 1;
 }
 
+message TerminalProfiles {
+  repeated TerminalProfile profiles = 1;
+}
+
+message TerminalProfile {
+  string id = 1;
+  string name = 2;
+  optional string path = 3;
+  optional string description = 4;
+}
+
+message TerminalProfileUpdateResponse {
+  int32 closed_count = 1;
+  int32 busy_terminals_count = 2;
+  bool has_busy_terminals = 3;
+}
+
 message TogglePlanActModeRequest {
   Metadata metadata = 1;
   ChatSettings chat_settings = 2;
@@ -42,10 +63,8 @@ message ChatContent {
   repeated string files = 3;
 }
 
-// Message for auto approval settings
 message AutoApprovalSettingsRequest {
   Metadata metadata = 1;
-
   message Actions {
     bool read_files = 1;
     bool read_files_externally = 2;
@@ -56,7 +75,6 @@ message AutoApprovalSettingsRequest {
     bool use_browser = 7;
     bool use_mcp = 8;
   }
-
   int32 version = 2;
   bool enabled = 3;
   Actions actions = 4;

src/core/controller/index.ts

@@ -135,6 +135,7 @@ export class Controller {
 			chatSettings,
 			shellIntegrationTimeout,
 			terminalReuseEnabled,
+			defaultTerminalProfile,
 			enableCheckpointsSetting,
 			isNewUser,
 			taskHistory,
@@ -170,6 +171,7 @@ export class Controller {
 			chatSettings,
 			shellIntegrationTimeout,
 			terminalReuseEnabled ?? true,
+			defaultTerminalProfile ?? "default",
 			enableCheckpointsSetting ?? true,
 			task,
 			images,
@@ -220,6 +222,7 @@ export class Controller {
 				await this.postStateToWebview()
 				break
 			}
+
 			case "clearAllTaskHistory": {
 				const answer = await vscode.window.showWarningMessage(
 					"What would you like to delete?",
@@ -952,6 +955,7 @@ export class Controller {
 			globalWorkflowToggles,
 			shellIntegrationTimeout,
 			terminalReuseEnabled,
+			defaultTerminalProfile,
 			isNewUser,
 			mcpResponsesCollapsed,
 		} = await getAllExtensionState(this.context)
@@ -997,6 +1001,7 @@ export class Controller {
 			globalWorkflowToggles: globalWorkflowToggles || {},
 			shellIntegrationTimeout,
 			terminalReuseEnabled,
+			defaultTerminalProfile,
 			isNewUser,
 			mcpResponsesCollapsed,
 		}

src/core/controller/state/getAvailableTerminalProfiles.ts

@@ -0,0 +1,19 @@
+import { Controller } from "../index"
+import * as proto from "@/shared/proto"
+import { getAvailableTerminalProfiles as getTerminalProfilesFromShell } from "../../../utils/shell"
+
+export async function getAvailableTerminalProfiles(
+	controller: Controller,
+	request: proto.cline.EmptyRequest,
+): Promise<proto.cline.TerminalProfiles> {
+	const profiles = getTerminalProfilesFromShell()
+
+	return proto.cline.TerminalProfiles.create({
+		profiles: profiles.map((profile) => ({
+			id: profile.id,
+			name: profile.name,
+			path: profile.path || "",
+			description: profile.description || "",
+		})),
+	})
+}

src/core/controller/state/updateDefaultTerminalProfile.ts

@@ -0,0 +1,50 @@
+import * as vscode from "vscode"
+import { Controller } from "../index"
+import * as proto from "@/shared/proto"
+import { updateGlobalState } from "../../storage/state"
+import { TerminalInfo } from "@/integrations/terminal/TerminalRegistry"
+
+export async function updateDefaultTerminalProfile(
+	controller: Controller,
+	request: proto.cline.StringRequest,
+): Promise<proto.cline.TerminalProfileUpdateResponse> {
+	const profileId = request.value
+
+	// Update the terminal profile in the state
+	await updateGlobalState(controller.context, "defaultTerminalProfile", profileId)
+
+	let closedCount = 0
+	let busyTerminals: TerminalInfo[] = []
+
+	// Update the terminal manager of the current task if it exists
+	if (controller.task) {
+		// Call the updated setDefaultTerminalProfile method that returns closed terminal info
+		const result = controller.task.terminalManager.setDefaultTerminalProfile(profileId)
+		closedCount = result.closedCount
+		busyTerminals = result.busyTerminals
+
+		// Show information message if terminals were closed
+		if (closedCount > 0) {
+			vscode.window.showInformationMessage(
+				`Closed ${closedCount} ${closedCount === 1 ? "terminal" : "terminals"} with different profile.`,
+			)
+		}
+
+		// Show warning if there are busy terminals that couldn't be closed
+		if (busyTerminals.length > 0) {
+			vscode.window.showWarningMessage(
+				`${busyTerminals.length} busy ${busyTerminals.length === 1 ? "terminal has" : "terminals have"} a different profile. ` +
+					`Close ${busyTerminals.length === 1 ? "it" : "them"} to use the new profile for all commands.`,
+			)
+		}
+	}
+
+	// Broadcast state update to all webviews
+	await controller.postStateToWebview()
+
+	return proto.cline.TerminalProfileUpdateResponse.create({
+		closedCount,
+		busyTerminalsCount: busyTerminals.length,
+		hasBusyTerminals: busyTerminals.length > 0,
+	})
+}

src/core/controller/state/updateTerminalConnectionTimeout.ts

@@ -0,0 +1,18 @@
+import { Controller } from "../index"
+import * as proto from "@/shared/proto"
+import { updateGlobalState } from "../../storage/state"
+
+export async function updateTerminalConnectionTimeout(
+	controller: Controller,
+	request: proto.cline.Int64Request,
+): Promise<proto.cline.Int64> {
+	const timeoutValue = request.value
+
+	// Update the terminal connection timeout setting in the state
+	await updateGlobalState(controller.context, "shellIntegrationTimeout", timeoutValue)
+
+	// Broadcast state update to all webviews
+	await controller.postStateToWebview()
+
+	return proto.cline.Int64.create({ value: timeoutValue })
+}

src/core/controller/state/updateTerminalReuseEnabled.ts

@@ -0,0 +1,18 @@
+import { Controller } from "../index"
+import * as proto from "@/shared/proto"
+import { updateGlobalState } from "../../storage/state"
+
+export async function updateTerminalReuseEnabled(
+	controller: Controller,
+	request: proto.cline.BooleanRequest,
+): Promise<proto.cline.Empty> {
+	const enabled = request.value
+
+	// Update the terminal reuse setting in the state
+	await updateGlobalState(controller.context, "terminalReuseEnabled", enabled)
+
+	// Broadcast state update to all webviews
+	await controller.postStateToWebview()
+
+	return proto.cline.Empty.create({})
+}

src/core/storage/state-keys.ts

@@ -67,6 +67,7 @@ export type GlobalStateKey =
 	| "shellIntegrationTimeout"
 	| "mcpResponsesCollapsed"
 	| "terminalReuseEnabled"
+	| "defaultTerminalProfile"
 	| "isNewUser"
 
 export type LocalStateKey =

src/core/storage/state.ts

@@ -237,6 +237,7 @@ export async function getAllExtensionState(context: vscode.ExtensionContext) {
 		mcpResponsesCollapsedRaw,
 		globalWorkflowToggles,
 		terminalReuseEnabled,
+		defaultTerminalProfile,
 	] = await Promise.all([
 		getGlobalState(context, "isNewUser") as Promise<boolean | undefined>,
 		getSecret(context, "apiKey") as Promise<string | undefined>,
@@ -300,6 +301,7 @@ export async function getAllExtensionState(context: vscode.ExtensionContext) {
 		getGlobalState(context, "mcpResponsesCollapsed") as Promise<boolean | undefined>,
 		getGlobalState(context, "globalWorkflowToggles") as Promise<ClineRulesToggles | undefined>,
 		getGlobalState(context, "terminalReuseEnabled") as Promise<boolean | undefined>,
+		getGlobalState(context, "defaultTerminalProfile") as Promise<string | undefined>,
 	])
 
 	const localClineRulesToggles = (await getWorkspaceState(context, "localClineRulesToggles")) as ClineRulesToggles
@@ -496,6 +498,7 @@ export async function getAllExtensionState(context: vscode.ExtensionContext) {
 		enableCheckpointsSetting: enableCheckpointsSetting,
 		shellIntegrationTimeout: shellIntegrationTimeout || 4000,
 		terminalReuseEnabled: terminalReuseEnabled ?? true,
+		defaultTerminalProfile: defaultTerminalProfile ?? "default",
 		globalWorkflowToggles: globalWorkflowToggles || {},
 	}
 }

src/core/task/index.ts

@@ -113,7 +113,7 @@ import { isInTestMode } from "../../services/test/TestMode"
 import { processFilesIntoText } from "@integrations/misc/extract-text"
 import { featureFlagsService } from "@services/posthog/feature-flags/FeatureFlagsService"
 import { StreamingJsonReplacer, ChangeLocation } from "@core/assistant-message/diff-json"
-import { isClaude4ModelFamily } from "@/utils/model-utils"
+import { isClaude4ModelFamily } from "@utils/model-utils"
 import { saveClineMessagesAndUpdateHistory } from "./message-state"
 
 export const USE_EXPERIMENTAL_CLAUDE4_FEATURES = false
@@ -141,7 +141,7 @@ export class Task {
 	readonly taskId: string
 	private taskIsFavorited?: boolean
 	api: ApiHandler
-	private terminalManager: TerminalManager
+	terminalManager: TerminalManager
 	private urlContentFetcher: UrlContentFetcher
 	browserSession: BrowserSession
 	contextManager: ContextManager
@@ -204,6 +204,7 @@ export class Task {
 		chatSettings: ChatSettings,
 		shellIntegrationTimeout: number,
 		terminalReuseEnabled: boolean,
+		defaultTerminalProfile: string,
 		enableCheckpointsSetting: boolean,
 		task?: string,
 		images?: string[],
@@ -223,6 +224,7 @@ export class Task {
 		this.terminalManager = new TerminalManager()
 		this.terminalManager.setShellIntegrationTimeout(shellIntegrationTimeout)
 		this.terminalManager.setTerminalReuseEnabled(terminalReuseEnabled ?? true)
+		this.terminalManager.setDefaultTerminalProfile(defaultTerminalProfile)
 		this.urlContentFetcher = new UrlContentFetcher(context)
 		this.browserSession = new BrowserSession(context, browserSettings)
 		this.contextManager = new ContextManager()