proto migration for testBrowserConnection.ts (RooCodeInc#2922)

* proto migration for testBrowserConnection.ts

* format fix

---------

Co-authored-by: Andrei Edell <[email protected]>

Author: Garoth

proto/browser.proto

@@ -6,10 +6,17 @@ import "common.proto";
 
 service BrowserService {
   rpc getBrowserConnectionInfo(EmptyRequest) returns (BrowserConnectionInfo);
+  rpc testBrowserConnection(StringRequest) returns (BrowserConnection);
 }
 
 message BrowserConnectionInfo {
   bool is_connected = 1;
   bool is_remote = 2;
-  string host = 3; // Optional, may be empty
+  optional string host = 3;
+}
+
+message BrowserConnection {
+  bool success = 1;
+  string message = 2;
+  optional string endpoint = 3;
 }

proto/common.proto

@@ -11,3 +11,30 @@ message EmptyRequest {
 
 message Empty {
 }
+
+message StringRequest {
+  Metadata metadata = 1;
+  string value = 2;
+}
+
+message String {
+  string value = 1;
+}
+
+message Int64Request {
+  Metadata metadata = 1;
+  int64 value = 2;
+}
+
+message Int64 {
+  int64 value = 1;
+}
+
+message BytesRequest {
+  Metadata metadata = 1;
+  bytes value = 2;
+}
+
+message Bytes {
+  bytes value = 1;
+}

src/core/controller/browser/methods.ts

@@ -4,9 +4,11 @@
 // Import all method implementations
 import { registerMethod } from "./index"
 import { getBrowserConnectionInfo } from "./getBrowserConnectionInfo"
+import { testBrowserConnection } from "./testBrowserConnection"
 
 // Register all browser service methods
 export function registerAllMethods(): void {
 	// Register each method with the registry
 	registerMethod("getBrowserConnectionInfo", getBrowserConnectionInfo)
+	registerMethod("testBrowserConnection", testBrowserConnection)
 }

src/core/controller/browser/testBrowserConnection.ts

@@ -0,0 +1,63 @@
+import { BrowserConnection } from "../../../shared/proto/browser"
+import { StringRequest } from "../../../shared/proto/common"
+import { Controller } from "../index"
+import { getAllExtensionState } from "../../storage/state"
+import { BrowserSession } from "../../../services/browser/BrowserSession"
+import { discoverChromeInstances } from "../../../services/browser/BrowserDiscovery"
+
+/**
+ * Test connection to a browser instance
+ * @param controller The controller instance
+ * @param request The request message
+ * @returns The browser connection result
+ */
+export async function testBrowserConnection(controller: Controller, request: StringRequest): Promise<BrowserConnection> {
+	try {
+		const { browserSettings } = await getAllExtensionState(controller.context)
+		const browserSession = new BrowserSession(controller.context, browserSettings)
+		const text = request.value || ""
+
+		// If no text is provided, try auto-discovery
+		if (!text) {
+			try {
+				const discoveredHost = await discoverChromeInstances()
+				if (discoveredHost) {
+					// Test the connection to the discovered host
+					const result = await browserSession.testConnection(discoveredHost)
+					return {
+						success: result.success,
+						message: `Auto-discovered and tested connection to Chrome at ${discoveredHost}: ${result.message}`,
+						endpoint: result.endpoint || "",
+					}
+				} else {
+					return {
+						success: false,
+						message:
+							"No Chrome instances found on the network. Make sure Chrome is running with remote debugging enabled (--remote-debugging-port=9222).",
+						endpoint: "",
+					}
+				}
+			} catch (error) {
+				return {
+					success: false,
+					message: `Error during auto-discovery: ${error instanceof Error ? error.message : String(error)}`,
+					endpoint: "",
+				}
+			}
+		} else {
+			// Test the provided URL
+			const result = await browserSession.testConnection(text)
+			return {
+				success: result.success,
+				message: result.message,
+				endpoint: result.endpoint || "",
+			}
+		}
+	} catch (error) {
+		return {
+			success: false,
+			message: `Error testing connection: ${error instanceof Error ? error.message : String(error)}`,
+			endpoint: "",
+		}
+	}
+}

src/core/controller/index.ts

@@ -311,58 +311,6 @@ export class Controller {
 					await this.postStateToWebview()
 				}
 				break
-			case "testBrowserConnection":
-				try {
-					const { browserSettings } = await getAllExtensionState(this.context)
-					const browserSession = new BrowserSession(this.context, browserSettings)
-					// If no text is provided, try auto-discovery
-					if (!message.text) {
-						try {
-							const discoveredHost = await discoverChromeInstances()
-							if (discoveredHost) {
-								// Test the connection to the discovered host
-								const result = await browserSession.testConnection(discoveredHost)
-								// Send the result back to the webview
-								await this.postMessageToWebview({
-									type: "browserConnectionResult",
-									success: result.success,
-									text: `Auto-discovered and tested connection to Chrome at ${discoveredHost}: ${result.message}`,
-									endpoint: result.endpoint,
-								})
-							} else {
-								await this.postMessageToWebview({
-									type: "browserConnectionResult",
-									success: false,
-									text: "No Chrome instances found on the network. Make sure Chrome is running with remote debugging enabled (--remote-debugging-port=9222).",
-								})
-							}
-						} catch (error) {
-							await this.postMessageToWebview({
-								type: "browserConnectionResult",
-								success: false,
-								text: `Error during auto-discovery: ${error instanceof Error ? error.message : String(error)}`,
-							})
-						}
-					} else {
-						// Test the provided URL
-						const result = await browserSession.testConnection(message.text)
-
-						// Send the result back to the webview
-						await this.postMessageToWebview({
-							type: "browserConnectionResult",
-							success: result.success,
-							text: result.message,
-							endpoint: result.endpoint,
-						})
-					}
-				} catch (error) {
-					await this.postMessageToWebview({
-						type: "browserConnectionResult",
-						success: false,
-						text: `Error testing connection: ${error instanceof Error ? error.message : String(error)}`,
-					})
-				}
-				break
 			case "discoverBrowser":
 				try {
 					const discoveredHost = await discoverChromeInstances()

src/shared/WebviewMessage.ts

@@ -40,8 +40,6 @@ export interface WebviewMessage {
 		| "autoApprovalSettings"
 		| "browserSettings"
 		| "discoverBrowser"
-		| "testBrowserConnection"
-		| "browserConnectionResult"
 		| "browserRelaunchResult"
 		| "togglePlanActMode"
 		| "checkpointDiff"