fetchOpenGraphData protobus migration (RooCodeInc#3549)

Author: canvrno

.changeset/good-ducks-teach.md

@@ -0,0 +1,5 @@
+---
+"claude-dev": patch
+---
+
+fetchOpenGraphData protobus migration

proto/web.proto

@@ -8,9 +8,19 @@ import "common.proto";
 
 service WebService {
   rpc checkIsImageUrl(StringRequest) returns (IsImageUrl);
+  rpc fetchOpenGraphData(StringRequest) returns (OpenGraphData);
 }
 
 message IsImageUrl {
   bool is_image = 1;
   string url = 2;
 }
+
+message OpenGraphData {
+  string title = 1;
+  string description = 2;
+  string image = 3;
+  string url = 4;
+  string site_name = 5;
+  string type = 6;
+}

src/core/controller/index.ts

@@ -338,9 +338,6 @@ export class Controller {
 					vscode.env.openExternal(vscode.Uri.parse(message.url))
 				}
 				break
-			case "fetchOpenGraphData":
-				this.fetchOpenGraphData(message.text!)
-				break
 			case "openMention":
 				openMention(message.text)
 				break
@@ -1475,30 +1472,6 @@ export class Controller {
 
 	// secrets
 
-	// Open Graph Data
-
-	async fetchOpenGraphData(url: string) {
-		try {
-			// Use the fetchOpenGraphData function from link-preview.ts
-			const ogData = await fetchOpenGraphData(url)
-
-			// Send the data back to the webview
-			await this.postMessageToWebview({
-				type: "openGraphData",
-				openGraphData: ogData,
-				url: url,
-			})
-		} catch (error) {
-			console.error(`Error fetching Open Graph data for ${url}:`, error)
-			// Send an error response
-			await this.postMessageToWebview({
-				type: "openGraphData",
-				error: `Failed to fetch Open Graph data: ${error}`,
-				url: url,
-			})
-		}
-	}
-
 	// Git commit message generation
 
 	async generateGitCommitMessage() {

src/core/controller/web/fetchOpenGraphData.ts

@@ -0,0 +1,26 @@
+import { Controller } from ".."
+import { StringRequest } from "../../../shared/proto/common"
+import { OpenGraphData } from "../../../shared/proto/web"
+import { fetchOpenGraphData as fetchOGData } from "../../../integrations/misc/link-preview"
+import { convertDomainOpenGraphDataToProto } from "../../../shared/proto-conversions/web/open-graph-conversion"
+
+/**
+ * Fetches Open Graph metadata from a URL
+ * @param controller The controller instance
+ * @param request The request containing the URL to fetch metadata from
+ * @returns Promise resolving to OpenGraphData
+ */
+export async function fetchOpenGraphData(controller: Controller, request: StringRequest): Promise<OpenGraphData> {
+	try {
+		const url = request.value || ""
+		// Fetch open graph data using the existing utility
+		const ogData = await fetchOGData(url)
+
+		// Convert domain model to proto model
+		return convertDomainOpenGraphDataToProto(ogData)
+	} catch (error) {
+		console.error(`Error fetching Open Graph data: ${request.value}`, error)
+		// Return empty OpenGraphData object
+		return OpenGraphData.create({})
+	}
+}

src/core/controller/web/methods.ts

@@ -4,9 +4,11 @@
 // Import all method implementations
 import { registerMethod } from "./index"
 import { checkIsImageUrl } from "./checkIsImageUrl"
+import { fetchOpenGraphData } from "./fetchOpenGraphData"
 
 // Register all web service methods
 export function registerAllMethods(): void {
 	// Register each method with the registry
 	registerMethod("checkIsImageUrl", checkIsImageUrl)
+	registerMethod("fetchOpenGraphData", fetchOpenGraphData)
 }

src/shared/WebviewMessage.ts

@@ -39,7 +39,6 @@ export interface WebviewMessage {
 		| "fetchLatestMcpServersFromHub"
 		| "telemetrySetting"
 		| "openSettings"
-		| "fetchOpenGraphData"
 		| "invoke"
 		| "updateSettings"
 		| "clearAllTaskHistory"

src/shared/proto-conversions/web/open-graph-conversion.ts

@@ -0,0 +1,18 @@
+import { OpenGraphData as DomainOpenGraphData } from "@integrations/misc/link-preview"
+import { OpenGraphData as ProtoOpenGraphData } from "@shared/proto/web"
+
+/**
+ * Converts domain OpenGraphData objects to proto OpenGraphData objects
+ * @param ogData Domain OpenGraphData object
+ * @returns Proto OpenGraphData object
+ */
+export function convertDomainOpenGraphDataToProto(ogData: DomainOpenGraphData): ProtoOpenGraphData {
+	return ProtoOpenGraphData.create({
+		title: ogData.title || "",
+		description: ogData.description || "",
+		image: ogData.image || "",
+		url: ogData.url || "",
+		siteName: ogData.siteName || "",
+		type: ogData.type || "",
+	})
+}

src/shared/proto/web.ts

@@ -67,6 +67,7 @@ import { taskFeedback } from "../core/controller/task/taskFeedback"
 
 // Web Service
 import { checkIsImageUrl } from "../core/controller/web/checkIsImageUrl"
+import { fetchOpenGraphData } from "../core/controller/web/fetchOpenGraphData"
 
 export function addServices(
 	server: grpc.Server,
@@ -157,5 +158,6 @@ export function addServices(
 	// Web Service
 	server.addService(proto.cline.WebService.service, {
 		checkIsImageUrl: wrapper(checkIsImageUrl, controller),
+		fetchOpenGraphData: wrapper(fetchOpenGraphData, controller),
 	})
 }