Migrate refreshClineRules protobus (RooCodeInc#3690)

* migrate refreshClineRules

* changeset

---------

Co-authored-by: Elephant Lumps <[email protected]>

Author: celestial-vault

.changeset/eight-sheep-remember.md

@@ -0,0 +1,5 @@
+---
+"claude-dev": minor
+---
+
+Migrate refreshClineRules to protobus

proto/file.proto

@@ -46,6 +46,18 @@ service FileService {
 
   // Toggle a Windsurf rule (enable or disable)
   rpc toggleWindsurfRule(ToggleWindsurfRuleRequest) returns (ClineRulesToggles);
+  
+  // Refreshes all rule toggles (Cline, External, and Workflows)
+  rpc refreshRules(EmptyRequest) returns (RefreshedRules);
+}
+
+// Response for refreshRules operation
+message RefreshedRules {
+  ClineRulesToggles global_cline_rules_toggles = 1;
+  ClineRulesToggles local_cline_rules_toggles = 2;
+  ClineRulesToggles local_cursor_rules_toggles = 3;
+  ClineRulesToggles local_windsurf_rules_toggles = 4;
+  ClineRulesToggles workflow_toggles = 5;
 }
 
 // Request to toggle a Windsurf rule

src/core/controller/file/methods.ts

@@ -10,6 +10,7 @@ import { getRelativePaths } from "./getRelativePaths"
 import { openFile } from "./openFile"
 import { openImage } from "./openImage"
 import { openMention } from "./openMention"
+import { refreshRules } from "./refreshRules"
 import { searchCommits } from "./searchCommits"
 import { searchFiles } from "./searchFiles"
 import { selectImages } from "./selectImages"
@@ -27,6 +28,7 @@ export function registerAllMethods(): void {
 	registerMethod("openFile", openFile)
 	registerMethod("openImage", openImage)
 	registerMethod("openMention", openMention)
+	registerMethod("refreshRules", refreshRules)
 	registerMethod("searchCommits", searchCommits)
 	registerMethod("searchFiles", searchFiles)
 	registerMethod("selectImages", selectImages)

src/core/controller/file/refreshRules.ts

@@ -0,0 +1,32 @@
+import { EmptyRequest } from "@shared/proto/common"
+import { RefreshedRules } from "@shared/proto/file"
+import type { Controller } from "../index"
+import { refreshClineRulesToggles } from "@core/context/instructions/user-instructions/cline-rules"
+import { refreshExternalRulesToggles } from "@core/context/instructions/user-instructions/external-rules"
+import { refreshWorkflowToggles } from "@core/context/instructions/user-instructions/workflows"
+import { cwd } from "@core/task"
+
+/**
+ * Refreshes all rule toggles (Cline, External, and Workflows)
+ * @param controller The controller instance
+ * @param _request The empty request
+ * @returns RefreshedRules containing updated toggles for all rule types
+ */
+export async function refreshRules(controller: Controller, _request: EmptyRequest): Promise<RefreshedRules> {
+	try {
+		const { globalToggles, localToggles } = await refreshClineRulesToggles(controller.context, cwd)
+		const { cursorLocalToggles, windsurfLocalToggles } = await refreshExternalRulesToggles(controller.context, cwd)
+		const workflowToggles = await refreshWorkflowToggles(controller.context, cwd)
+
+		return {
+			globalClineRulesToggles: { toggles: globalToggles },
+			localClineRulesToggles: { toggles: localToggles },
+			localCursorRulesToggles: { toggles: cursorLocalToggles },
+			localWindsurfRulesToggles: { toggles: windsurfLocalToggles },
+			workflowToggles: { toggles: workflowToggles },
+		}
+	} catch (error) {
+		console.error("Failed to refresh rules:", error)
+		throw error
+	}
+}

src/core/controller/index.ts

@@ -321,12 +321,6 @@ export class Controller {
 				await updateGlobalState(this.context, "lastShownAnnouncementId", this.latestAnnouncementId)
 				await this.postStateToWebview()
 				break
-			case "refreshClineRules":
-				await refreshClineRulesToggles(this.context, cwd)
-				await refreshExternalRulesToggles(this.context, cwd)
-				await refreshWorkflowToggles(this.context, cwd)
-				await this.postStateToWebview()
-				break
 			case "openInBrowser":
 				if (message.url) {
 					vscode.env.openExternal(vscode.Uri.parse(message.url))

src/shared/WebviewMessage.ts

@@ -17,7 +17,6 @@ export interface WebviewMessage {
 		| "didShowAnnouncement"
 		| "openInBrowser"
 		| "showChatView"
-		| "refreshClineRules"
 		| "openMcpSettings"
 		| "autoApprovalSettings"
 		| "togglePlanActMode"

src/shared/proto/file.ts

@@ -34,6 +34,7 @@ import { searchFiles } from "../core/controller/file/searchFiles"
 import { toggleClineRule } from "../core/controller/file/toggleClineRule"
 import { toggleCursorRule } from "../core/controller/file/toggleCursorRule"
 import { toggleWindsurfRule } from "../core/controller/file/toggleWindsurfRule"
+import { refreshRules } from "../core/controller/file/refreshRules"
 
 // Mcp Service
 import { toggleMcpServer } from "../core/controller/mcp/toggleMcpServer"
@@ -130,6 +131,7 @@ export function addServices(
 		toggleClineRule: wrapper(toggleClineRule, controller),
 		toggleCursorRule: wrapper(toggleCursorRule, controller),
 		toggleWindsurfRule: wrapper(toggleWindsurfRule, controller),
+		refreshRules: wrapper(refreshRules, controller),
 	})
 
 	// Mcp Service

src/standalone/server-setup.ts

@@ -8,7 +8,8 @@ import { VSCodeButton } from "@vscode/webview-ui-toolkit/react"
 import RulesToggleList from "./RulesToggleList"
 import Tooltip from "@/components/common/Tooltip"
 import styled from "styled-components"
-import { ClineRulesToggles, ToggleWindsurfRuleRequest } from "@shared/proto/file"
+import { ClineRulesToggles, RefreshedRules, ToggleWindsurfRuleRequest } from "@shared/proto/file"
+import { EmptyRequest } from "@shared/proto/common"
 
 const ClineRulesToggleModal: React.FC = () => {
 	const {
@@ -21,6 +22,7 @@ const ClineRulesToggleModal: React.FC = () => {
 		setLocalClineRulesToggles,
 		setLocalCursorRulesToggles,
 		setLocalWindsurfRulesToggles,
+		setWorkflowToggles,
 	} = useExtensionState()
 	const [isVisible, setIsVisible] = useState(false)
 	const buttonRef = useRef<HTMLDivElement>(null)
@@ -32,7 +34,28 @@ const ClineRulesToggleModal: React.FC = () => {
 
 	useEffect(() => {
 		if (isVisible) {
-			vscode.postMessage({ type: "refreshClineRules" })
+			FileServiceClient.refreshRules({} as EmptyRequest)
+				.then((response: RefreshedRules) => {
+					// Update state with the response data using all available setters
+					if (response.globalClineRulesToggles?.toggles) {
+						setGlobalClineRulesToggles(response.globalClineRulesToggles.toggles)
+					}
+					if (response.localClineRulesToggles?.toggles) {
+						setLocalClineRulesToggles(response.localClineRulesToggles.toggles)
+					}
+					if (response.localCursorRulesToggles?.toggles) {
+						setLocalCursorRulesToggles(response.localCursorRulesToggles.toggles)
+					}
+					if (response.localWindsurfRulesToggles?.toggles) {
+						setLocalWindsurfRulesToggles(response.localWindsurfRulesToggles.toggles)
+					}
+					if (response.workflowToggles?.toggles) {
+						setWorkflowToggles(response.workflowToggles.toggles)
+					}
+				})
+				.catch((error) => {
+					console.error("Failed to refresh rules:", error)
+				})
 		}
 	}, [isVisible])
 

webview-ui/src/components/cline-rules/ClineRulesToggleModal.tsx

@@ -55,6 +55,7 @@ interface ExtensionStateContextType extends ExtensionState {
 	setLocalClineRulesToggles: (toggles: Record<string, boolean>) => void
 	setLocalCursorRulesToggles: (toggles: Record<string, boolean>) => void
 	setLocalWindsurfRulesToggles: (toggles: Record<string, boolean>) => void
+	setWorkflowToggles: (toggles: Record<string, boolean>) => void
 	setMcpMarketplaceCatalog: (value: McpMarketplaceCatalog) => void
 
 	// Navigation state setters
@@ -540,6 +541,11 @@ export const ExtensionStateContextProvider: React.FC<{
 				...prevState,
 				localWindsurfRulesToggles: toggles,
 			})),
+		setWorkflowToggles: (toggles) =>
+			setState((prevState) => ({
+				...prevState,
+				workflowToggles: toggles,
+			})),
 		setMcpTab,
 	}