Spring cleaning (RooCodeInc#3723)

* Spring cleaning

* changeset

* Fixed incorrect return on ScrollToSettings proto

* cleanup

Author: canvrno

.changeset/honest-boats-fix.md

@@ -0,0 +1,5 @@
+---
+"claude-dev": patch
+---
+
+Spring cleaning

proto/common.proto

@@ -63,3 +63,8 @@ message StringArrays {
   repeated string values1 = 1;
   repeated string values2 = 2;
 }
+
+message KeyValuePair {
+  string key = 1;
+  string value = 2;
+}

proto/ui.proto

@@ -221,7 +221,7 @@ message ClineMessage {
 // UiService provides methods for managing UI interactions
 service UiService {
   // Scrolls to a specific settings section in the settings view
-  rpc scrollToSettings(StringRequest) returns (Empty);
+  rpc scrollToSettings(StringRequest) returns (KeyValuePair);
 
   // Marks the current announcement as shown and returns whether an announcement should still be shown
   rpc onDidShowAnnouncement(EmptyRequest) returns (Boolean);

src/core/controller/index.ts

@@ -7,8 +7,6 @@ import pWaitFor from "p-wait-for"
 import * as path from "path"
 import * as vscode from "vscode"
 import { handleGrpcRequest, handleGrpcRequestCancel } from "./grpc-handler"
-import { handleModelsServiceRequest } from "./models"
-import { EmptyRequest } from "@shared/proto/common"
 import { buildApiHandler } from "@api/index"
 import { cleanupLegacyCheckpoints } from "@integrations/checkpoints/CheckpointMigration"
 import { downloadTask } from "@integrations/misc/export-markdown"
@@ -44,8 +42,6 @@ import { sendStateUpdate } from "./state/subscribeToState"
 import { sendAddToInputEvent } from "./ui/subscribeToAddToInput"
 import { sendAuthCallbackEvent } from "./account/subscribeToAuthCallback"
 import { sendMcpMarketplaceCatalogEvent } from "./mcp/subscribeToMcpMarketplaceCatalog"
-import { sendOpenRouterModelsEvent } from "./models/subscribeToOpenRouterModels"
-import { OpenRouterCompatibleModelInfo } from "@/shared/proto/models"
 
 /*
 https://github.com/microsoft/vscode-webview-ui-toolkit-samples/blob/main/default/weather-webview/src/providers/WeatherViewProvider.ts
@@ -207,17 +203,6 @@ export class Controller {
 				await this.setUserInfo(message.user || undefined)
 				await this.postStateToWebview()
 				break
-			case "newTask":
-				// Code that should run in response to the hello message command
-				//vscode.window.showInformationMessage(message.text!)
-
-				// Send a message to our webview.
-				// You can send any JSON serializable data.
-				// Could also do this in extension .ts
-				//this.postMessageToWebview({ type: "text", text: `Extension: ${Date.now()}` })
-				// initializing new instance of Cline will make sure that any agentically running promises in old instance don't affect our new task. this essentially creates a fresh slate for the new task
-				await this.initTask(message.text, message.images, message.files)
-				break
 			case "apiConfiguration":
 				if (message.apiConfiguration) {
 					await updateApiConfiguration(this.context, message.apiConfiguration)

src/core/controller/ui/scrollToSettings.ts

@@ -1,15 +1,15 @@
 import { Controller } from ".."
-import { StringRequest } from "../../../shared/proto/common"
+import { StringRequest, KeyValuePair } from "../../../shared/proto/common"
 
 /**
  * Executes a scroll to settings action
  * @param controller The controller instance
  * @param request The request containing the ID of the settings section to scroll to
- * @returns An object with action and value fields for the UI to process
+ * @returns KeyValuePair with action and value fields for the UI to process
  */
-export async function scrollToSettings(controller: Controller, request: StringRequest): Promise<Record<string, string>> {
-	return {
-		action: "scrollToSettings",
+export async function scrollToSettings(controller: Controller, request: StringRequest): Promise<KeyValuePair> {
+	return KeyValuePair.create({
+		key: "scrollToSettings",
 		value: request.value || "",
-	}
+	})
 }

src/shared/ExtensionMessage.ts

@@ -17,21 +17,15 @@ export interface ExtensionMessage {
 		| "action"
 		| "state"
 		| "selectedImages"
-		| "ollamaModels"
-		| "lmStudioModels"
 		| "workspaceUpdated"
-		| "openAiModels"
 		| "requestyModels"
 		| "mcpServers"
 		| "relinquishControl"
 		| "mcpDownloadDetails"
-		| "commitSearchResults"
-		| "openGraphData"
 		| "didUpdateSettings"
 		| "userCreditsBalance"
 		| "userCreditsUsage"
 		| "userCreditsPayments"
-		| "fileSearchResults"
 		| "grpc_response" // New type for gRPC responses
 	text?: string
 	action?: "didBecomeVisible" | "accountLogoutClicked" | "focusChatInput"
@@ -50,14 +44,6 @@ export interface ExtensionMessage {
 	error?: string
 	mcpDownloadDetails?: McpDownloadResponse
 	commits?: GitCommit[]
-	openGraphData?: {
-		title?: string
-		description?: string
-		image?: string
-		url?: string
-		siteName?: string
-		type?: string
-	}
 	url?: string
 	isImage?: boolean
 	userCreditsBalance?: BalanceResponse

src/shared/WebviewMessage.ts

@@ -9,7 +9,6 @@ import { McpViewTab } from "./mcp"
 export interface WebviewMessage {
 	type:
 		| "apiConfiguration"
-		| "newTask"
 		| "condense"
 		| "reportBug"
 		| "requestVsCodeLmModels"
@@ -21,7 +20,6 @@ export interface WebviewMessage {
 		| "updateSettings"
 		| "clearAllTaskHistory"
 		| "fetchUserCreditsData"
-		| "searchFiles"
 		| "grpc_request"
 		| "grpc_request_cancel"
 		| "toggleWorkflow"

webview-ui/src/components/chat/ChatTextArea.tsx

@@ -345,22 +345,6 @@ const ChatTextArea = forwardRef<HTMLTextAreaElement, ChatTextAreaProps>(
 			}
 		}, [selectedType, searchQuery])
 
-		const handleMessage = useCallback((event: MessageEvent) => {
-			const message: ExtensionMessage = event.data
-			switch (message.type) {
-				case "fileSearchResults": {
-					// Only update results if they match the current query or if there's no mentionsRequestId - better UX
-					if (!message.mentionsRequestId || message.mentionsRequestId === currentSearchQueryRef.current) {
-						setFileSearchResults(message.results || [])
-						setSearchLoading(false)
-					}
-					break
-				}
-			}
-		}, [])
-
-		useEvent("message", handleMessage)
-
 		const queryItems = useMemo(() => {
 			return [
 				{ type: ContextMenuOptionType.Problems, value: "problems" },