Skip to content

Commit c6dbbdb

Browse files
celestial-vaultElephant Lumps
andauthored
Migrate openSettings protobus (RooCodeInc#3684)
* use navigation directly for openSettings * changeset --------- Co-authored-by: Elephant Lumps <[email protected]>
1 parent 1a66f64 commit c6dbbdb

File tree

5 files changed

+12
-14
lines changed

5 files changed

+12
-14
lines changed

.changeset/cold-rice-exist.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"claude-dev": minor
3+
---
4+
5+
Migrate openSettings message to use state navigation handlers

src/core/controller/index.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -423,13 +423,6 @@ export class Controller {
423423
break
424424
}
425425
// telemetry
426-
case "openSettings": {
427-
await this.postMessageToWebview({
428-
type: "action",
429-
action: "settingsButtonClicked",
430-
})
431-
break
432-
}
433426
case "telemetrySetting": {
434427
if (message.telemetrySetting) {
435428
await this.updateTelemetrySetting(message.telemetrySetting)

src/shared/WebviewMessage.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ export interface WebviewMessage {
3030
| "searchCommits"
3131
| "fetchLatestMcpServersFromHub"
3232
| "telemetrySetting"
33-
| "openSettings"
3433
| "invoke"
3534
| "updateSettings"
3635
| "clearAllTaskHistory"

webview-ui/src/components/browser/BrowserSettingsMenu.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ interface ConnectionInfo {
1313
}
1414

1515
export const BrowserSettingsMenu = () => {
16-
const { browserSettings } = useExtensionState()
16+
const { browserSettings, navigateToSettings } = useExtensionState()
1717
const containerRef = useRef<HTMLDivElement>(null)
1818
const [showInfoPopover, setShowInfoPopover] = useState(false)
1919
const [connectionInfo, setConnectionInfo] = useState<ConnectionInfo>({
@@ -65,10 +65,8 @@ export const BrowserSettingsMenu = () => {
6565
}, [showInfoPopover])
6666

6767
const openBrowserSettings = () => {
68-
// First open the settings panel
69-
vscode.postMessage({
70-
type: "openSettings",
71-
})
68+
// First open the settings panel using direct navigation
69+
navigateToSettings()
7270

7371
// After a short delay, send a message to scroll to browser settings
7472
setTimeout(async () => {

webview-ui/src/components/common/TelemetryBanner.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { VSCodeButton, VSCodeLink } from "@vscode/webview-ui-toolkit/react"
22
import { memo, useState } from "react"
33
import styled from "styled-components"
4+
import { useExtensionState } from "@/context/ExtensionStateContext"
45
import { vscode } from "@/utils/vscode"
56
import { TelemetrySetting } from "@shared/TelemetrySetting"
67

@@ -45,9 +46,11 @@ const ButtonContainer = styled.div`
4546
`
4647

4748
const TelemetryBanner = () => {
49+
const { navigateToSettings } = useExtensionState()
50+
4851
const handleOpenSettings = () => {
4952
handleClose()
50-
vscode.postMessage({ type: "openSettings" })
53+
navigateToSettings()
5154
}
5255

5356
const handleClose = () => {

0 commit comments

Comments
 (0)