Migrate openMcpSettings protobus (RooCodeInc#3778)

* migrate openMcpSettings

* changeset

---------

Co-authored-by: Elephant Lumps <[email protected]>

Author: celestial-vault

.changeset/popular-wombats-tap.md

@@ -0,0 +1,5 @@
+---
+"claude-dev": minor
+---
+
+Migrate openMcpSettings to protobus

proto/mcp.proto

@@ -15,6 +15,7 @@ service McpService {
   rpc deleteMcpServer(StringRequest) returns (McpServers);
   rpc toggleToolAutoApprove(ToggleToolAutoApproveRequest) returns (McpServers);
   rpc refreshMcpMarketplace(EmptyRequest) returns (McpMarketplaceCatalog);
+  rpc openMcpSettings(EmptyRequest) returns (Empty);
 }
 
 message ToggleMcpServerRequest {

src/core/controller/index.ts

@@ -316,13 +316,6 @@ export class Controller {
 				await this.fetchUserCreditsData()
 				break
 			}
-			case "openMcpSettings": {
-				const mcpSettingsFilePath = await this.mcpHub?.getMcpSettingsFilePath()
-				if (mcpSettingsFilePath) {
-					await handleFileServiceRequest(this, "openFile", { value: mcpSettingsFilePath })
-				}
-				break
-			}
 			case "fetchMcpMarketplace": {
 				await this.fetchMcpMarketplace(message.bool)
 				break

src/core/controller/mcp/openMcpSettings.ts

@@ -0,0 +1,17 @@
+import { Controller } from ".."
+import { Empty, EmptyRequest } from "@shared/proto/common"
+import { openFile as openFileIntegration } from "@integrations/misc/open-file"
+
+/**
+ * Opens the MCP settings file in the editor
+ * @param controller The controller instance
+ * @param _request Empty request
+ * @returns Empty response
+ */
+export async function openMcpSettings(controller: Controller, _request: EmptyRequest): Promise<Empty> {
+	const mcpSettingsFilePath = await controller.mcpHub?.getMcpSettingsFilePath()
+	if (mcpSettingsFilePath) {
+		await openFileIntegration(mcpSettingsFilePath)
+	}
+	return Empty.create()
+}

src/shared/WebviewMessage.ts

@@ -15,7 +15,6 @@ export interface WebviewMessage {
 		| "reportBug"
 		| "openInBrowser"
 		| "showChatView"
-		| "openMcpSettings"
 		| "openExtensionSettings"
 		| "requestVsCodeLmModels"
 		| "showAccountViewClicked"

webview-ui/src/components/mcp/configuration/tabs/add-server/AddLocalServerForm.tsx

@@ -1,7 +1,7 @@
 import { VSCodeButton, VSCodeLink } from "@vscode/webview-ui-toolkit/react"
-import { vscode } from "@/utils/vscode"
 import styled from "styled-components"
 import { LINKS } from "@/constants"
+import { McpServiceClient } from "@/services/grpc-client"
 
 type AddLocalServerFormProps = {
 	onServerAdded: () => void
@@ -22,7 +22,9 @@ const AddLocalServerForm = ({ onServerAdded }: AddLocalServerFormProps) => {
 				appearance="primary"
 				style={{ width: "100%", marginBottom: "5px", marginTop: 8 }}
 				onClick={() => {
-					vscode.postMessage({ type: "openMcpSettings" })
+					McpServiceClient.openMcpSettings({}).catch((error) => {
+						console.error("Error opening MCP settings:", error)
+					})
 				}}>
 				Open cline_mcp_settings.json
 			</VSCodeButton>

webview-ui/src/components/mcp/configuration/tabs/add-server/AddRemoteServerForm.tsx

@@ -1,5 +1,4 @@
 import { useRef, useState } from "react"
-import { vscode } from "@/utils/vscode"
 import { VSCodeButton, VSCodeLink, VSCodeTextField } from "@vscode/webview-ui-toolkit/react"
 import { LINKS } from "@/constants"
 import { McpServiceClient } from "@/services/grpc-client"
@@ -116,7 +115,9 @@ const AddRemoteServerForm = ({ onServerAdded }: { onServerAdded: () => void }) =
 					appearance="secondary"
 					style={{ width: "100%", marginBottom: "5px", marginTop: 15 }}
 					onClick={() => {
-						vscode.postMessage({ type: "openMcpSettings" })
+						McpServiceClient.openMcpSettings({}).catch((error) => {
+							console.error("Error opening MCP settings:", error)
+						})
 					}}>
 					Edit Configuration
 				</VSCodeButton>

webview-ui/src/components/mcp/configuration/tabs/installed/InstalledServersView.tsx

@@ -1,8 +1,7 @@
 import { VSCodeButton, VSCodeLink } from "@vscode/webview-ui-toolkit/react"
-import { vscode } from "@/utils/vscode"
 import { useExtensionState } from "@/context/ExtensionStateContext"
 
-import { UiServiceClient } from "@/services/grpc-client"
+import { UiServiceClient, McpServiceClient } from "@/services/grpc-client"
 
 import ServersToggleList from "./ServersToggleList"
 const InstalledServersView = () => {
@@ -40,7 +39,9 @@ const InstalledServersView = () => {
 					appearance="secondary"
 					style={{ width: "100%", marginBottom: "5px" }}
 					onClick={() => {
-						vscode.postMessage({ type: "openMcpSettings" })
+						McpServiceClient.openMcpSettings({}).catch((error) => {
+							console.error("Error opening MCP settings:", error)
+						})
 					}}>
 					<span className="codicon codicon-server" style={{ marginRight: "6px" }}></span>
 					Configure MCP Servers