Permissions issue when initializing checkpoints (RooCodeInc#2354)

* initial

* More error handling and git option

* Cleanup and tweaks

* one small change

* Update src/integrations/checkpoints/CheckpointUtils.ts

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

---------

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

Author: canvrno

.changeset/yellow-moose-bathe.md

@@ -0,0 +1,5 @@
+---
+"claude-dev": patch
+---
+
+Added permissions checks, error handling, and git options to deal with cases where the entire workspace or specific files within it cannot be accessed. These issues were preventing checkpoints from working correctly, or causing checkpoints to hang.

src/integrations/checkpoints/CheckpointGitOperations.ts

@@ -90,7 +90,11 @@ export class GitOperations {
 		const lfsPatterns = await getLfsPatterns(cwd)
 		await writeExcludesFile(gitPath, lfsPatterns)
 
-		await this.addCheckpointFiles(git)
+		const addFilesResult = await this.addCheckpointFiles(git)
+		if (!addFilesResult.success) {
+			console.error("Failed to add at least one file(s) to checkpoints shadow git")
+			throw new Error("Failed to add at least one file(s) to checkpoints shadow git")
+		}
 
 		// Initial commit only on first repo creation
 		await git.commit("initial commit", { "--allow-empty": null })
@@ -142,6 +146,7 @@ export class GitOperations {
 			ignore: [".git"], // Ignore root level .git
 			dot: true,
 			markDirectories: false,
+			suppressErrors: true,
 		})
 
 		// For each nested .git directory, rename it based on operation
@@ -190,18 +195,18 @@ export class GitOperations {
 			await this.renameNestedGitRepos(true)
 			console.info("Starting checkpoint add operation...")
 
+			// Attempt to add all files. Any files with permissions errors will not be added,
+			// but the process will proceed and add the rest (--ignore-errors).
 			try {
-				await git.add(".")
+				await git.add([".", "--ignore-errors"])
 				const durationMs = Math.round(performance.now() - startTime)
 				console.debug(`Checkpoint add operation completed in ${durationMs}ms`)
 				return { success: true }
 			} catch (error) {
-				console.error("Checkpoint add operation failed:", error)
-				throw error
+				return { success: false }
 			}
 		} catch (error) {
-			console.error("Failed to add files to checkpoint", error)
-			throw error
+			return { success: false }
 		} finally {
 			await this.renameNestedGitRepos(false)
 		}

src/integrations/checkpoints/CheckpointTracker.ts

@@ -165,7 +165,10 @@ class CheckpointTracker {
 
 			console.info(`Using shadow git at: ${gitPath}`)
 
-			await this.gitOperations.addCheckpointFiles(git)
+			const addFilesResult = await this.gitOperations.addCheckpointFiles(git)
+			if (!addFilesResult.success) {
+				console.error("Failed to add at least one file(s) to checkpoints shadow git")
+			}
 
 			const commitMessage = "checkpoint-" + this.cwdHash + "-" + this.taskId
 

src/integrations/checkpoints/CheckpointUtils.ts

@@ -1,4 +1,4 @@
-import { mkdir } from "fs/promises"
+import { mkdir, access, constants } from "fs/promises"
 import * as path from "path"
 import * as vscode from "vscode"
 import os from "os"
@@ -31,7 +31,9 @@ export async function getShadowGitPath(globalStoragePath: string, taskId: string
 /**
  * Gets the current working directory from the VS Code workspace.
  * Validates that checkpoints are not being used in protected directories
- * like home, Desktop, Documents, or Downloads.
+ * like home, Desktop, Documents, or Downloads. Checks to confirm that the workspace
+ * is accessible and that we will not encounter breaking permissions issues when
+ * creating checkpoints.
  *
  * Protected directories:
  * - User's home directory
@@ -40,13 +42,23 @@ export async function getShadowGitPath(globalStoragePath: string, taskId: string
  * - Downloads
  *
  * @returns Promise<string> The absolute path to the current working directory
- * @throws Error if no workspace is detected or if in a protected directory
+ * @throws Error if no workspace is detected, if in a protected directory, or if no read access
  */
 export async function getWorkingDirectory(): Promise<string> {
 	const cwd = vscode.workspace.workspaceFolders?.map((folder) => folder.uri.fsPath).at(0)
 	if (!cwd) {
 		throw new Error("No workspace detected. Please open Cline in a workspace to use checkpoints.")
 	}
+
+	// Check if directory exists and we have read permissions
+	try {
+		await access(cwd, constants.R_OK)
+	} catch (error) {
+		throw new Error(
+			`Cannot access workspace directory. Please ensure VS Code has permission to access your workspace. Error: ${error instanceof Error ? error.message : String(error)}`,
+		)
+	}
+
 	const homedir = os.homedir()
 	const desktopPath = path.join(homedir, "Desktop")
 	const documentsPath = path.join(homedir, "Documents")