Flash download progress

Author: tjvandam

functions.js

@@ -639,6 +639,9 @@ function renderInputControl(key, setting, value) {
     // 1) Custom input renderers
     else if (customInputRenderers[key]) {
         html += customInputRenderers[key](setting, value);
+        if (key === 'device_pin') {
+            value = normalizeDevicePinStorageValue(value);
+        }
     }
 
     // 2) If it's one of the bitmask settings -> render custom or port checkboxes
@@ -1644,7 +1647,10 @@ function validateInput(key, setting, value) {
             throw new Error(`Must be 'true' or 'false'`);
         }
     } else if (setting.conversion === 'byte_array') {
-        stringToUint8Array(value, setting.length);
+        const byteArrayValue = key === 'device_pin'
+            ? normalizeDevicePinStorageValue(value)
+            : value;
+        stringToUint8Array(byteArrayValue, setting.length);
     } else if (setting.conversion === 'string') {
         if (value.length > setting.length) {
             throw new Error(`Max length is ${setting.length} characters`);

index.html

@@ -148,18 +148,14 @@
       <div class="section-card-body">
         <div class="status-header">
           <div class="status-item"><span class="icon messages"></span>Flash log</div>
-          <a href="#" onclick="requestFlashLogCount()">
+          <a href="#" onclick="requestFlashLogCount(); return false;">
             <div class="status-item"><span class="icon refresh"></span>refresh</div>
           </a>
         </div>
         <div class="data-item">
           <span>Flash messages</span>
           <span id="flash-log-count">Not loaded</span>
         </div>
-        <div class="data-item">
-          <span>Status</span>
-          <span id="flash-log-status">Waiting for settings...</span>
-        </div>
         <div class="log-actions">
           <button type="button" class="log-action-button scan-button" onclick="requestFlashLogDownloadAll()">Download all logs</button>
         </div>
@@ -637,6 +633,8 @@ <h3 id="import-preview-title">Import preview</h3>
       active: false,
       lines: [],
       buffer: '',
+      frameBuffer: new Uint8Array(0),
+      decodedMessages: 0,
       startedAt: null,
       deviceName: '',
       logTypeLabel: 'all',
@@ -1788,6 +1786,8 @@ <h3 id="import-preview-title">Import preview</h3>
         active: true,
         lines: [],
         buffer: '',
+        frameBuffer: new Uint8Array(0),
+        decodedMessages: 0,
         startedAt: new Date(),
         deviceName: device && device.name ? device.name : '',
         logTypeLabel,
@@ -1813,6 +1813,35 @@ <h3 id="import-preview-title">Import preview</h3>
       log(`Starting flash log download (${logTypeLabel})...`);
     }
 
+    function parseFlashLogRecordCount(packetBytes, carryBuffer) {
+      const incoming = packetBytes.slice(1); // strip transport port byte
+      const merged = new Uint8Array((carryBuffer ? carryBuffer.length : 0) + incoming.length);
+      if (carryBuffer && carryBuffer.length) {
+        merged.set(carryBuffer, 0);
+      }
+      merged.set(incoming, carryBuffer ? carryBuffer.length : 0);
+
+      let index = 0;
+      let count = 0;
+      while (index + 2 < merged.length) {
+        const payloadLen = merged[index + 2];
+        const frameStart = index + 3;
+        const frameEnd = frameStart + payloadLen;
+        const metadataLen = 4;
+        const recordEnd = frameEnd + metadataLen;
+        if (recordEnd > merged.length) {
+          break;
+        }
+        count += 1;
+        index = recordEnd;
+      }
+
+      return {
+        count,
+        remainder: merged.slice(index)
+      };
+    }
+
     function finishFlashLogCapture(reason) {
       if (!flashLogState.active) {
         return;
@@ -1878,7 +1907,16 @@ <h3 id="import-preview-title">Import preview</h3>
 
       const base64Line = bytesToBase64(payload);
       flashLogState.lines.push(base64Line);
-      const receivedCount = flashLogState.lines.length;
+
+      const parsed = parseFlashLogRecordCount(data, flashLogState.frameBuffer);
+      flashLogState.frameBuffer = parsed.remainder;
+      if (parsed.count > 0) {
+        flashLogState.decodedMessages += parsed.count;
+      }
+
+      const receivedCount = flashLogState.decodedMessages > 0
+        ? flashLogState.decodedMessages
+        : flashLogState.lines.length;
       const elapsedSeconds = Math.max(1, Math.round((Date.now() - flashLogState.startedAt.getTime()) / 1000));
       const rate = (receivedCount / elapsedSeconds).toFixed(1);
       const hasTotal = Number.isFinite(flashLogState.expectedTotal) && flashLogState.expectedTotal > 0;