Fixed all the warnings from the Luacheck linter tool

Author: daveylib-abb

drivers/SmartThings/abb-scu200/src/abb/device_manager.lua

@@ -104,7 +104,7 @@ end
 -- Method for monitoring the connection of the bridge devices
 function device_manager.bridge_monitor(driver, device, bridge_info)
     local child_devices = device:get_child_list()
-    
+
     for _, thing_device in ipairs(child_devices) do
         device.thread:call_with_delay(0, function()  -- Run within bridge thread to use the same connection
             device_manager.refresh(driver, thing_device)

drivers/SmartThings/abb-scu200/src/abb/device_refresher.lua

@@ -12,7 +12,7 @@ local device_refresher = {}
 local function refresh_current_sensor(driver, device, values)
     local dni = utils.get_dni_from_device(device)
     log.info("refresh_current_sensor(): Refreshing data of Current Sensor, dni = " .. dni)
-    
+
     -- Refresh Current Measurement
     local current = values.current
 
@@ -36,13 +36,13 @@ local function refresh_current_sensor(driver, device, values)
         -- Refresh Active Energy
         log.trace("refresh_current_sensor(): Refreshing Active Energy, dni = " .. dni)
         device.profile.components["main"]:emit_event(caps.energyMeter.energy({value=activeEnergy, unit="kWh"}))
-    
+
         -- Verify whether the appropriate time have elapsed to report the energy values
         local last_energy_report = device:get_field(fields.LAST_ENERGY_REPORT) or 0.0
 
         if (os.time() - last_energy_report) >= config.EDGE_CHILD_ENERGY_REPORT_INTERVAL then  -- Report the energy consumption/production periodically
             local current_consumption_production_report = device:get_latest_state("main", caps.powerConsumptionReport.ID, caps.powerConsumptionReport.powerConsumption.NAME)
-        
+
             -- Calculate delta consumption/production energy
             local delta_consumption_production_report = 0.0
             if current_consumption_production_report ~= nil then
@@ -119,15 +119,15 @@ local function refresh_energy_meter(driver, device, values)
         -- Refresh Active Energy Import Total
         log.trace("refresh_energy_meter(): Refreshing Active Energy Import Total, dni = " .. dni)
         device.profile.components["consumptionMeter"]:emit_event(caps.energyMeter.energy({value=activeEnergyImportTotal, unit="kWh"}))
-        
+
         -- Refresh Active Energy Export Total
         log.trace("refresh_energy_meter(): Refreshing Active Energy Export Total, dni = " .. dni)
         device.profile.components["productionMeter"]:emit_event(caps.energyMeter.energy({value=activeEnergyExportTotal, unit="kWh"}))
 
         -- Refresh Active Energy Net Negative
         log.trace("refresh_energy_meter(): Refreshing Active Energy Net Negative, dni = " .. dni)
         device.profile.components["surplus"]:emit_event(caps.energyMeter.energy({value=activeEnergyNetNegative, unit="kWh"}))
-    
+
         -- Verify whether the appropriate time have elapsed to report the energy net, consumption and production
         local last_energy_report = device:get_field(fields.LAST_ENERGY_REPORT) or 0.0
 
@@ -246,7 +246,7 @@ local function refresh_water_meter(driver, device, values)
         log.trace("refresh_water_meter(): Refreshing Water Meter: last hour, dni = " .. dni)
         device:emit_event(caps.waterMeter.lastHour({value=lastHourFlow, unit=unit}))
     end
-    
+
     -- Refresh Water Meter: last 24 hours
     local lastTwentyFourHoursFlow = values.lastTwentyFourHoursFlow
 
@@ -262,7 +262,7 @@ local function refresh_water_meter(driver, device, values)
         log.trace("refresh_water_meter(): Refreshing Water Meter: last 7 days, dni = " .. dni)
         device:emit_event(caps.waterMeter.lastSevenDays({value=lastSevenDaysFlow, unit=unit}))
     end
-    
+
     return true
 end
 
@@ -283,7 +283,7 @@ local function refresh_gas_meter(driver, device, values)
 
     -- Refresh Gas Meter
     local gasMeterVolume = values.gasMeterVolume
-    
+
     if gasMeterVolume ~= nil then
         log.trace("refresh_gas_meter(): Refreshing Gas Meter, dni = " .. dni)
         device:emit_event(caps.gasMeter.gasMeterVolume({value=gasMeterVolume, unit=gasMeterVolumeUnit}))

drivers/SmartThings/abb-scu200/src/commands.lua

@@ -1,6 +1,5 @@
 local caps = require('st.capabilities')
 local log = require('log')
-local cosock = require "cosock"
 local json = require('dkjson')
 
 -- Local imports
@@ -19,7 +18,7 @@ local function post_payload(device, payload)
     local communication_device = device:get_parent_device() or device
     local conn_info = communication_device:get_field(fields.CONN_INFO)
 
-    local response, err, status = conn_info:post_device_by_id(dni, payload)
+    local _, err, status = conn_info:post_device_by_id(dni, payload)
     if not err and status == 200 then
         log.info("post_payload(): Success, dni = " .. dni)
 
@@ -36,7 +35,7 @@ end
 
 -- Switch on command
 function commands.switch_on(driver, device, cmd)
-    local dni, device_type = utils.get_dni_from_device(device)
+    local dni, _ = utils.get_dni_from_device(device)
     log.info("commands.switch_on(): Switching on capablity within dni = " .. dni)
 
     local device_model = utils.get_device_model(device)
@@ -62,7 +61,7 @@ end
 
 -- Switch off commands
 function commands.switch_off(driver, device, cmd)
-    local dni, device_type = utils.get_dni_from_device(device)
+    local dni, _ = utils.get_dni_from_device(device)
     log.info("commands.switch_off(): Switching off capablity within dni = " .. dni)
 
     local device_model = utils.get_device_model(device)

drivers/SmartThings/abb-scu200/src/discovery.lua

@@ -17,17 +17,17 @@ local joined_thing = {}
 -- Method for setting the device fields
 function discovery.set_device_fields(driver, device)
     local dni = utils.get_dni_from_device(device)
-  
+
     if joined_bridge[dni] ~= nil then
         log.info("discovery.set_device_field(): Setting device field for bridge: " .. dni)
         local bridge_cache_value = driver.datastore.bridge_discovery_cache[dni]
-  
+
         device:set_field(fields.BRIDGE_IPV4, bridge_cache_value.ip, {persist = true})
         device:set_field(fields.DEVICE_TYPE, fields.DEVICE_TYPE_BRIDGE, {persist = true})
     elseif joined_thing[dni] ~= nil then
         log.info("discovery.set_device_field(): Setting device field for thing: " .. dni)
         local thing_cache_value = driver.datastore.thing_discovery_cache[dni]
-    
+
         device:set_field(fields.PARENT_BRIDGE_DNI, thing_cache_value.parent_bridge_dni, {persist = true})
         device:set_field(fields.THING_INFO, thing_cache_value.thing_info, {persist = true})
         device:set_field(fields.DEVICE_TYPE, fields.DEVICE_TYPE_THING, {persist = true})
@@ -146,8 +146,8 @@ local function parse_ssdp(data)
     res.status = data:sub(0, data:find('\r\n'))
 
     for line in data:gmatch("[^\r\n]+") do
-        _, _, header, value = string.find(line, "([%w-]+):%s*([%a+-:_ /=?]*)")
-        
+        local _, _, header, value = string.find(line, "([%w-]+):%s*([%a+-:_ /=?]*)")
+
         if header ~= nil and value ~= nil then
             res[header:lower()] = value
         end
@@ -226,7 +226,7 @@ local function discover_bridges(driver)
 
         log.debug("discover_bridges(): Known devices: " .. dni .. " with type: " .. device_type)
     end
-  
+
     -- Find new devices
     local found_devices = discovery.find_devices()
 
@@ -238,8 +238,6 @@ local function discover_bridges(driver)
                 if not joined_bridge[dni] then
                     if try_add_bridge(driver, dni, device) then
                         joined_bridge[dni] = true
-
-                        bridge_ip = device["ip"]
                     end
                 else
                     log.debug("discover_bridges(): Bridge already joined: " .. dni)
@@ -272,7 +270,7 @@ local function discover_things(driver)
 
         if known_devices[bridge_dni] ~= nil and known_devices[bridge_dni]:get_field(fields.CONN_INFO) ~= nil then
             local thing_infos = api.get_thing_infos(bridge_ip, bridge_dni)
-        
+
             if thing_infos and thing_infos.devices ~= nil then
                 for _, thing_info in pairs(thing_infos.devices) do
                     if thing_info ~= nil then

drivers/SmartThings/abb-scu200/src/eventsource_handler.lua

@@ -47,7 +47,7 @@ function eventsource_handler.handle_sse_event(driver, bridge, msg)
                 device:online()
             else
                 log.error("eventsource_handler.handle_sse_event(): Failed to update the device's values")
-    
+
                 -- Set device as offline
                 device:offline()
             end

drivers/SmartThings/abb-scu200/src/fields.lua

@@ -12,5 +12,5 @@ local fields = {
     DEVICE_TYPE_BRIDGE = "bridge",
     DEVICE_TYPE_THING = "thing"
 }
-  
+
 return fields

drivers/SmartThings/abb-scu200/src/lifecycles.lua

@@ -6,7 +6,6 @@ local utils = require('utils')
 local discovery = require('discovery')
 local commands = require('commands')
 local connection_monitor = require('connection_monitor')
-local device_manager = require('abb.device_manager')
 local eventsource_handler = require("eventsource_handler")
 
 -- Lifecycles handlers for the driver
@@ -40,15 +39,15 @@ function lifecycles.init(driver, device)
         end
 
         -- Refresh the device manually
-        commands.refresh(driver, device, _)
-        
+        commands.refresh(driver, device, nil)
+
         -- Refresh schedule
         local refresh_period = utils.get_thing_refresh_period(device)
 
         device.thread:call_on_schedule(
             refresh_period,
             function ()
-                return commands.refresh(driver, device, _)
+                return commands.refresh(driver, device, nil)
             end,
             "Refresh schedule")
     end

drivers/SmartThings/abb-scu200/src/utils.lua

@@ -18,7 +18,7 @@ function utils.get_dni_from_device(device)
     else
         local bridge_dni = device.device_network_id
 
-        return bridge_dni, fields.DEVICE_TYPE_BRIDGE 
+        return bridge_dni, fields.DEVICE_TYPE_BRIDGE
     end
 end
 
@@ -41,7 +41,7 @@ end
 -- Get the device IP address
 function utils.get_device_ip_address(device)
     local _, device_type = utils.get_dni_from_device(device)
-    
+
     if device_type == fields.DEVICE_TYPE_BRIDGE then
         return device:get_field(fields.BRIDGE_IPV4)
     else
@@ -145,56 +145,56 @@ function utils.backoff_builder(max, inc, rand)
         if rand then
             randval = math.random() * rand * 2 - rand
         end
-    
+
         local base = inc * (2 ^ count - 1)
         count = count + 1
-    
+
         -- ensure base backoff (not including random factor) is less than max
         if max then base = math.min(base, max) end
-    
+
         -- ensure total backoff is >= 0
         return math.max(base + randval, 0)
     end
 end
 
 -- Method for creating a labeled socket
-function utils.labeled_socket_builder(label, ssl_config)  
+function utils.labeled_socket_builder(label, ssl_config)
     label = (label or "")
     if #label > 0 then
         label = label .. " "
     end
-  
+
     if not ssl_config then
         ssl_config = { mode = "client", protocol = "any", verify = "none", options = "all" }
     end
-  
+
     local function make_socket(host, port, wrap_ssl)
         log.info("utils.labeled_socket_builder(): Creating TCP socket for REST Connection: " .. label)
         local _ = nil
         local sock, err = socket.tcp()
-  
+
         if err ~= nil or (not sock) then
             return nil, (err or "unknown error creating TCP socket")
         end
-  
+
         log.debug("utils.labeled_socket_builder(): Setting TCP socket timeout for REST Connection: " .. label)
         _, err = sock:settimeout(60)
         if err ~= nil then
             return nil, "settimeout error: " .. err
         end
-  
+
         log.debug("utils.labeled_socket_builder(): Connecting TCP socket for REST Connection: " .. label)
         _, err = sock:connect(host, port)
         if err ~= nil then
             return nil, "Connect error: " .. err
         end
-  
+
         log.debug("utils.labeled_socket_builder(): Set Keepalive for TCP socket for REST Connection: " .. label)
         _, err = sock:setoption("keepalive", true)
         if err ~= nil then
             return nil, "Setoption error: " .. err
         end
-  
+
         if wrap_ssl then
             log.debug("utils.labeled_socket_builder(): Creating SSL wrapper for REST Connection: " .. label)
             sock, err = ssl.wrap(sock, ssl_config)
@@ -208,7 +208,7 @@ function utils.labeled_socket_builder(label, ssl_config)
                 return nil, "Error with SSL handshake: " .. err
             end
         end
-  
+
         log.info("utils.labeled_socket_builder(): Successfully created TCP connection: " .. label)
         return sock, err
     end