fix-an-issue-of-window-covering-status-inconsistency #1679
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Channel deleted. |
Test Results 63 files 396 suites 0s ⏱️ For more details on these failures, see this check. Results for commit 447740d. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 447740d |
| device:emit_event_for_endpoint(ib.endpoint_id, capabilities.windowShade.windowShade.unknown()) | ||
| end | ||
| end | ||
| if device:get_field(First_Time_Onboarding) == true then |
There was a problem hiding this comment.
this will probably emit event twice, will else if here better?
pInksenberg
force-pushed
the
fix-an-issue-of-window-covering-status-inconsistency
branch
from
c84e68b to
447740d
Compare
Contributor
|
Hello @pInksenberg - I am assuming due to inactivity that this PR can be closed. Could you please confirm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
The previous matter-window-covering edge driver use CurrentPositionLiftPercent100ths and OperationalStatus to decide window covering status (opening/open/closing/closed/partially open). However, sometimes operational status event comes first and sometimes position event comes first, makes the code logic complex.
To simplify the code, TargetPositionLiftPercent100ths and CurrentPositionLiftPercent100ths are now used to decide the status of window covering without considering which attribute event comes first.
Summary of Completed Tests