Skip to content

Commit 9f9a3f2

Browse files
committed
fix: iconImage in an app response is optional
1 parent a725307 commit 9f9a3f2

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

.changeset/perfect-ravens-guess.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@smartthings/core-sdk": patch
3+
---
4+
5+
mark iconImage field as optional in app response

CONTRIBUTING.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,11 @@ We're always looking for more opinions on discussions in the issue tracker. It's
2525
- Non-trivial changes are often best discussed in an issue first, to prevent you from doing unnecessary work.
2626
- For ambitious tasks, you should try to get your work in front of the community for feedback as soon as possible. Open a pull request as soon as you have done the minimum needed to demonstrate your idea. At this early stage, don't worry about making things perfect, or 100% complete. Describe what you still need to do and submit a [draft pull request](https://github.blog/2019-02-14-introducing-draft-pull-requests/). This lets reviewers know not to nit-pick small details or point out improvements you already know you need to make.
2727
- Don't include unrelated changes
28+
- Pull requests should include only a single commit. You can use `git rebase -i main` to combine multiple commits into a single one if necessary.
2829
- New features should be accompanied with tests and documentation
2930
- Commit messages
30-
- Use a clear and descriptive title for the pull request and commits
31+
- Use a clear and descriptive title for the pull request and commits.
32+
- Commit messages must be formatted properly using [conventional commit format](https://www.conventionalcommits.org/en/v1.0.0/).
3133
- We use changesets to automatically version and publish releases, and generate release notes.
3234
Please include one with your pull request by following the instructions to
3335
[add a changeset](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md).

src/endpoint/apps.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ export interface PagedApp extends AppBase {
186186
/**
187187
* A default icon image for the app.
188188
*/
189-
iconImage: Required<IconImage>
189+
iconImage?: Required<IconImage>
190190

191191
/**
192192
* A typed model which provides information around ownership of a specific domain.

0 commit comments

Comments
 (0)