Skip to content

Commit 122e273

Browse files
code cleanup
1 parent 0c3c740 commit 122e273

File tree

6 files changed

+83
-85
lines changed

6 files changed

+83
-85
lines changed

colorpicker/src/main/java/com/smarttoolfactory/colorpicker/selector/SelectorRingHue.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import androidx.compose.ui.layout.*
1616
import androidx.compose.ui.platform.LocalDensity
1717
import androidx.compose.ui.unit.Dp
1818
import androidx.compose.ui.unit.dp
19+
import com.smarttoolfactory.colorpicker.ui.gradientColorScaleHSV
1920
import com.smarttoolfactory.colorpicker.util.calculateAngleFomLocalCoordinates
2021
import com.smarttoolfactory.colorpicker.util.calculateDistanceFromCenter
2122
import com.smarttoolfactory.colorpicker.ui.gradientColorScaleRGB
@@ -148,7 +149,7 @@ private fun HueSelectorRingImpl(
148149

149150
// Draw hue selection circle with sweep gradient
150151
drawCircle(
151-
brush = Brush.sweepGradient(colors = gradientColorScaleRGB, center = center),
152+
brush = Brush.sweepGradient(colors = gradientColorScaleHSV, center = center),
152153
radius = radiusInner + strokeWidth / 2,
153154
style = Stroke(
154155
width = strokeWidth

colorpicker/src/main/java/com/smarttoolfactory/colorpicker/slider/SliderDisplay.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ import androidx.compose.ui.graphics.Color
1313
import androidx.compose.ui.text.font.FontWeight
1414
import androidx.compose.ui.unit.dp
1515
import androidx.compose.ui.unit.sp
16+
import com.smarttoolfactory.colorpicker.ui.Grey400
1617
import com.smarttoolfactory.colorpicker.util.fractionToPercent
1718
import com.smarttoolfactory.colorpicker.util.fractionToRGBString
18-
import com.smarttoolfactory.colorpicker.ui.Grey400
1919

2020
/*
2121
HSV Slider Displays

colorpicker/src/main/java/com/smarttoolfactory/colorpicker/ui/Color.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ val BlueGrey400 = Color(0xff78909C)
1414
val Grey400 = Color(0xffBDBDBD)
1515

1616
val Grey600 = Color(0xff757575)
17+
val Grey800 = Color(0xff424242)
18+
val Grey900 = Color(0xff212121)
1719

1820
val Gray = Color(0xff808080)
1921
val WhiteTransparent = Color(0x00ffffff)
Lines changed: 77 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,77 @@
1+
package com.smarttoolfactory.colorpicker.widget
2+
3+
import androidx.compose.material.*
4+
import androidx.compose.runtime.*
5+
import androidx.compose.ui.Modifier
6+
import androidx.compose.ui.graphics.Color
7+
import androidx.compose.ui.text.TextStyle
8+
import androidx.compose.ui.text.font.FontWeight
9+
import androidx.compose.ui.unit.sp
10+
11+
@OptIn(ExperimentalMaterialApi::class)
12+
@Composable
13+
fun ExposedSelectionMenu(
14+
modifier: Modifier = Modifier,
15+
index: Int,
16+
title: String? = null,
17+
options: List<String>,
18+
onSelected: (Int) -> Unit
19+
) {
20+
21+
var expanded by remember { mutableStateOf(false) }
22+
var selectedOptionText by remember { mutableStateOf(options[index]) }
23+
24+
ExposedDropdownMenuBox(
25+
modifier = modifier,
26+
expanded = expanded,
27+
onExpandedChange = {
28+
expanded = !expanded
29+
}
30+
) {
31+
TextField(
32+
modifier =modifier,
33+
readOnly = true,
34+
value = selectedOptionText,
35+
onValueChange = { },
36+
label = {
37+
title?.let {
38+
Text(it)
39+
}
40+
},
41+
trailingIcon = {
42+
ExposedDropdownMenuDefaults.TrailingIcon(
43+
expanded = expanded
44+
)
45+
},
46+
colors = ExposedDropdownMenuDefaults.textFieldColors(
47+
backgroundColor = Color.White,
48+
focusedIndicatorColor = Color.Transparent,
49+
unfocusedIndicatorColor = Color.Transparent,
50+
disabledIndicatorColor = Color.Transparent,
51+
),
52+
textStyle = TextStyle(
53+
fontWeight = FontWeight.W600,
54+
fontSize = 14.sp
55+
)
56+
)
57+
ExposedDropdownMenu(
58+
expanded = expanded,
59+
onDismissRequest = {
60+
expanded = false
61+
62+
}
63+
) {
64+
options.forEachIndexed { index: Int, selectionOption: String ->
65+
DropdownMenuItem(
66+
onClick = {
67+
selectedOptionText = selectionOption
68+
expanded = false
69+
onSelected(index)
70+
}
71+
) {
72+
Text(text = selectionOption)
73+
}
74+
}
75+
}
76+
}
77+
}

colorpicker/src/main/java/com/smarttoolfactory/colorpicker/widget/HexDisplay.kt

Lines changed: 1 addition & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -153,66 +153,4 @@ private fun ColorText(modifier: Modifier = Modifier, title: String, value: Strin
153153
Spacer(modifier = Modifier.height(4.dp))
154154
Text(text = value, fontSize = 14.sp)
155155
}
156-
}
157-
158-
@OptIn(ExperimentalMaterialApi::class)
159-
@Composable
160-
private fun ExposedSelectionMenu(
161-
modifier: Modifier = Modifier,
162-
index: Int,
163-
options: List<String>,
164-
onSelected: (Int) -> Unit
165-
) {
166-
167-
var expanded by remember { mutableStateOf(false) }
168-
var selectedOptionText by remember { mutableStateOf(options[index]) }
169-
170-
ExposedDropdownMenuBox(
171-
modifier = modifier,
172-
expanded = expanded,
173-
onExpandedChange = {
174-
expanded = !expanded
175-
}
176-
) {
177-
TextField(
178-
modifier = Modifier.wrapContentWidth(),
179-
readOnly = true,
180-
value = selectedOptionText,
181-
onValueChange = { },
182-
trailingIcon = {
183-
ExposedDropdownMenuDefaults.TrailingIcon(
184-
expanded = expanded
185-
)
186-
},
187-
colors = ExposedDropdownMenuDefaults.textFieldColors(
188-
backgroundColor = Color.White,
189-
focusedIndicatorColor = Color.Transparent,
190-
unfocusedIndicatorColor = Color.Transparent,
191-
disabledIndicatorColor = Color.Transparent,
192-
),
193-
textStyle = TextStyle(
194-
fontWeight = FontWeight.W600,
195-
fontSize = 14.sp
196-
)
197-
)
198-
ExposedDropdownMenu(
199-
expanded = expanded,
200-
onDismissRequest = {
201-
expanded = false
202-
203-
}
204-
) {
205-
options.forEachIndexed { index: Int, selectionOption: String ->
206-
DropdownMenuItem(
207-
onClick = {
208-
selectedOptionText = selectionOption
209-
expanded = false
210-
onSelected(index)
211-
}
212-
) {
213-
Text(text = selectionOption)
214-
}
215-
}
216-
}
217-
}
218-
}
156+
}

slider/src/main/java/com/smarttoolfactory/slider/ui/Color.kt

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,3 @@ import androidx.compose.ui.graphics.Color
55
val ThumbColor = Color(0xfff0f0f0)
66
val ActiveTrackColor = Color(0xff489cef)
77
val InactiveTrackColor = Color(0xffcccccc)
8-
9-
val gradientColors = listOf(
10-
Color.Red,
11-
Color.Magenta,
12-
Color.Blue,
13-
Color.Cyan,
14-
Color.Green,
15-
Color.Yellow,
16-
Color.Red
17-
)
18-
19-
val gradientColorsReversed = listOf(
20-
Color.Red,
21-
Color.Yellow,
22-
Color.Green,
23-
Color.Cyan,
24-
Color.Blue,
25-
Color.Magenta,
26-
Color.Red
27-
)

0 commit comments

Comments
 (0)