Fix PHP notice triggered when an observer is disabled

Author: guvra

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All notable changes to this project will be documented in this file.
 
+## WIP
+
+  * Fix PHP notice triggered when an observer is disabled
+
 ## [4.0.2] - 2019-02-06
 [4.0.2]: https://github.com/Smile-SA/magento2-module-debug-toolbar/compare/4.0.1...4.0.2
 

Plugin/Event/Invoker.php

@@ -7,6 +7,7 @@
  */
 namespace Smile\DebugToolbar\Plugin\Event;
 
+use Closure;
 use Magento\Framework\Event\InvokerInterface as MagentoInvoker;
 use Magento\Framework\Event\Observer as MagentoObserver;
 use Smile\DebugToolbar\Helper\Observer as HelperObserver;
@@ -37,18 +38,22 @@ public function __construct(HelperObserver $helperObserver)
      * Plugin on dispatch.
      *
      * @param MagentoInvoker $subject
-     * @param \Closure $closure
+     * @param Closure $closure
      * @param array $configuration
      * @param MagentoObserver $observer
      * @return mixed
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function aroundDispatch(
         MagentoInvoker $subject,
-        \Closure $closure,
+        Closure $closure,
         array $configuration,
         MagentoObserver $observer
     ) {
+        if (array_key_exists('disabled', $configuration) && $configuration['disabled'] === true) {
+            return $closure($configuration, $observer);
+        }
+
         $eventName = $observer->getEvent()->getName();
         $observerInstance = $configuration['instance'];
         $observerName = array_key_exists('name', $configuration) ? $configuration['name'] : $observerInstance;