Skip to content

libinput 1.23, Add accel config for pointer acceleration #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

libinput 1.23, Add accel config for pointer acceleration #72

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dfb72b1
Add accel config for pointer acceleration
rockerBOO Jul 27, 2024
b27e7cb
Cleanup, unnecessary unsafe
rockerBOO Jul 27, 2024
61e0b84
Update custom AccelProfile doc
rockerBOO Jul 27, 2024
e0dae11
Remove 1.26.1, add 1.23. Fix pointer/reference
rockerBOO Aug 15, 2024
cd7b786
Remove poor comment
rockerBOO Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,14 @@ optional = true
rustix = { version = "0.38", features = ["event"] }

[features]
default = ["udev", "log", "libinput_1_21"]
default = ["udev", "log", "libinput_1_26"]
use_bindgen = ["input-sys/use_bindgen"]
libinput_1_11 = ["input-sys/libinput_1_11"]
libinput_1_14 = ["input-sys/libinput_1_14", "libinput_1_11"]
libinput_1_15 = ["input-sys/libinput_1_15", "libinput_1_14"]
libinput_1_19 = ["input-sys/libinput_1_19", "libinput_1_15"]
libinput_1_21 = ["input-sys/libinput_1_21", "libinput_1_19"]
libinput_1_26 = ["input-sys/libinput_1_26", "libinput_1_21"]
Copy link
Member

@Drakulix Drakulix Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this feature was added in 1.23 already, the feature should be named accordingly and the corresponding header file of it's tar-archive should be used for generating.

Copy link
Author

@rockerBOO rockerBOO Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. Are we implying we should have a 1.23 version here instead of the 1.26 version? I'm not 100% sure what this is pointing out as a feature. Thanks.

Copy link
Member

@Drakulix Drakulix Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general these features are meant to be activated for the minimum-version of libinput users of these bindings want to support. So if you care to enable 1_21 because you need some methods introduced with that version, 1.21 is the minimum libinput version on any target system your crate needs.

Which is why this should be libinput_1_23, so that it signifies, that pointer acceleration profiles were added in that version and requiring these options, requires that version of libinput to be available.

Copy link
Author

@rockerBOO rockerBOO Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed libinput_1_26 and added libinput_1_23


[workspace]
members = [
Expand Down
1 change: 1 addition & 0 deletions input-sys/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,4 @@ libinput_1_14 = []
libinput_1_15 = []
libinput_1_19 = []
libinput_1_21 = []
libinput_1_26 = []
1 change: 1 addition & 0 deletions input-sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ extern crate bindgen;
use std::{env, path::Path};

const LIB_VERSIONS: &[(u8, u8, u8)] = &[
(1, 26, 1),
(1, 21, 0),
(1, 19, 0),
(1, 15, 0),
Expand Down
Loading