Decide how Layup should handle observations before January 20th 1962 #133
Description
While testing orbit fit, the following three observations were in our input file:
provID,actualProvID,ra,dec,obstime,stn,rmsra,rmsdec,rmstime,rmscorr,unctime
9946,1990 ON2,69.45933,27.26058,1950-12-11T06:02:00.096Z,675,,,,,
9946,1990 ON2,13.63929,8.08961,1953-10-31T06:15:29.664Z,675,,,,,
9946,1990 ON2,13.63450,8.08792,1953-10-31T06:49:00.192Z,675,,,,,
However our oldest configs for the position of Earth only go back to 1962.
earth_historical: str = "earth_620120_240827.bpc"
"""filename of earth_histoical"""
earth_historical_url: str = f"{naif_base_url}/pck/earth_620120_240827.bpc"
"""url for earth_historical"""
And there don't seem to be older kernels available at https://naif.jpl.nasa.gov/pub/naif/generic_kernels/pck/
We should either be able to handle this case, or provide more helpful error messaging. At the latter we should decide at what point to check and handle the failure.
The full stacktrace of the current failure, which will probably just confuse users.
Traceback (most recent call last):
File "/Users/wilsonbb/lincc/layup/src/layup/utilities/data_processing_utilities.py", line 165, in obscodes_to_barycentric
et, barycentricObservatoryRates(et, obscode, self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/wilsonbb/miniconda3/envs/layup/lib/python3.11/site-packages/sorcha/ephemeris/simulation_geometry.py", line 198, in barycentricObservatoryRates
m = spice.pxform("ITRF93", "J2000", et)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/wilsonbb/miniconda3/envs/layup/lib/python3.11/site-packages/spiceypy/spiceypy.py", line 139, in with_errcheck
check_for_spice_error(f)
File "/Users/wilsonbb/miniconda3/envs/layup/lib/python3.11/site-packages/spiceypy/spiceypy.py", line 122, in check_for_spice_error
raise dynamically_instantiate_spiceyerror(
spiceypy.utils.exceptions.SpiceFRAMEDATANOTFOUND:
================================================================================
Toolkit version: CSPICE_N0067
SPICE(FRAMEDATANOTFOUND) --
PCK data required to compute the orientation of the body-fixed frame ITRF93 for epoch 1950 DEC 11 06:02:41.279 TDB were not found. If these data were to be provided by a binary PCK file, then it is possible that the PCK file does not have coverage for the specified body-fixed frame at the time of interest. If the data were to be provided by a text PCK file, then possibly the file does not contain data for the specified body-fixed frame. In either case it is possible that a required PCK file was not loaded at all.
pxform_c --> PXFORM --> REFCHG --> ROTGET --> TIPBOD --> TISBOD
================================================================================
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Users/wilsonbb/miniconda3/envs/layup/bin/layup-orbitfit", line 8, in <module>
sys.exit(main())
^^^^^^
File "/Users/wilsonbb/lincc/layup/src/layup_cmdline/orbitfit.py", line 102, in main
return execute(args)
^^^^^^^^^^^^^
File "/Users/wilsonbb/lincc/layup/src/layup_cmdline/orbitfit.py", line 131, in execute
orbitfit_cli(
File "/Users/wilsonbb/lincc/layup/src/layup/orbitfit.py", line 207, in orbitfit_cli
fit_orbits = orbitfit(
^^^^^^^^^
File "/Users/wilsonbb/lincc/layup/src/layup/orbitfit.py", line 120, in orbitfit
pos_vel = layup_observatory.obscodes_to_barycentric(data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/wilsonbb/lincc/layup/src/layup/utilities/data_processing_utilities.py", line 169, in obscodes_to_barycentric
raise ValueError(
ValueError: Error calculating barycentric coordinates for 675 at et: -1548136638.7206495 from obstime: 1950-12-11T06:02:00.096Z
================================================================================
Toolkit version: CSPICE_N0067
SPICE(FRAMEDATANOTFOUND) --
PCK data required to compute the orientation of the body-fixed frame ITRF93 for epoch 1950 DEC 11 06:02:41.279 TDB were not found. If these data were to be provided by a binary PCK file, then it is possible that the PCK file does not have coverage for the specified body-fixed frame at the time of interest. If the data were to be provided by a text PCK file, then possibly the file does not contain data for the specified body-fixed frame. In either case it is possible that a required PCK file was not loaded at all.
pxform_c --> PXFORM --> REFCHG --> ROTGET --> TIPBOD --> TISBOD
================================================================================
Error: Command 'layup-orbitfit' failed with exit code 1.