errors test in progress

Author: Smoren

src/Views/ArrayView.php

@@ -268,7 +268,11 @@ public function offsetSet($offset, $value): void
             throw new ReadonlyError("Cannot modify a readonly view.");
         }
 
-        if (\is_numeric($offset) && $this->numericOffsetExists($offset)) {
+        if (\is_numeric($offset)) {
+            if (!$this->numericOffsetExists($offset)) {
+                throw new IndexError("Index {$offset} is out of range.");
+            }
+
             // @phpstan-ignore-next-line
             $this->source[$this->convertIndex(\intval($offset))] = $value;
             return;

tests/unit/ArrayView/ErrorsTest.php

@@ -2,11 +2,44 @@
 
 namespace Smoren\ArrayView\Tests\Unit\ArrayView;
 
+use Smoren\ArrayView\Exceptions\IndexError;
 use Smoren\ArrayView\Exceptions\ValueError;
 use Smoren\ArrayView\Views\ArrayView;
 
 class ErrorsTest extends \Codeception\Test\Unit
 {
+    /**
+     * @dataProvider dataProviderForOutOfRangeIndexes
+     */
+    public function testReadIndexError(array $source, array $indexes)
+    {
+        $view = ArrayView::toView($source);
+        foreach ($indexes as $index) {
+            try {
+                $_ = $view[$index];
+                $this->fail();
+            } catch (IndexError $e) {
+                $this->assertSame("Index {$index} is out of range.", $e->getMessage());
+            }
+        }
+    }
+
+    /**
+     * @dataProvider dataProviderForOutOfRangeIndexes
+     */
+    public function testWriteIndexError(array $source, array $indexes)
+    {
+        $view = ArrayView::toView($source);
+        foreach ($indexes as $index) {
+            try {
+                $view[$index] = 1;
+                $this->fail();
+            } catch (IndexError $e) {
+                $this->assertSame("Index {$index} is out of range.", $e->getMessage());
+            }
+        }
+    }
+
     /**
      * @dataProvider dataProviderForNonSequentialError
      */
@@ -17,6 +50,15 @@ public function testNonSequentialError(callable $arrayGetter)
         ArrayView::toView($nonSequentialArray);
     }
 
+    public function dataProviderForOutOfRangeIndexes(): array
+    {
+        return [
+            [[], [-2, -1, 0, 1]],
+            [[1], [-3, -2, 1, 2]],
+            [[1, 2, 3], [-100, -5, 4, 100]],
+        ];
+    }
+
     public function dataProviderForNonSequentialError(): array
     {
         return [