Optimization.

Author: Smoren

src/Views/ArrayIndexListView.php

@@ -54,8 +54,7 @@ public function __construct(&$source, array $indexes, ?bool $readonly = null)
      */
     public function toArray(): array
     {
-        /** @var Array<T> */
-        return array_map(fn(int $index) => $this[$index], array_keys($this->indexes));
+        return array_map(fn (int $index) => $this->source[$index], $this->indexes);
     }
 
     /**

tests/unit/ArrayIndexListView/ReadTest.php

@@ -119,16 +119,21 @@ public function dataProviderForRead(): array
             [[1], [], []],
             [[1, 2, 3], [], []],
             [[1], [0], [1]],
+            [[1], [-1], [1]],
             [[1], [0, 0], [1, 1]],
+            [[1], [0, -1], [1, 1]],
             [[1], [0, 0, 0], [1, 1, 1]],
             [[1, 2], [0], [1]],
             [[1, 2], [1], [2]],
+            [[1, 2], [-1], [2]],
+            [[1, 2], [-2], [1]],
             [[1, 2], [0, 1], [1, 2]],
             [[1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 3, 5, 7], [2, 4, 6, 8]],
             [[1, 2, 3, 4, 5, 6, 7, 8, 9], [7, 5, 3, 1], [8, 6, 4, 2]],
             [[1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 5, 3, 7], [2, 6, 4, 8]],
             [[1, 2, 3, 4, 5, 6, 7, 8, 9], [0, 1, 7, 8], [1, 2, 8, 9]],
             [[1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 1, 5, 5, 3], [2, 2, 6, 6, 4]],
+            [[1, 2, 3, 4, 5, 6, 7, 8, 9], [-1, -1, 5, 5, 3], [9, 9, 6, 6, 4]],
         ];
     }
 }

tests/unit/Examples/BenchTest.php

@@ -10,6 +10,39 @@ class BenchTest extends \Codeception\Test\Unit
 {
     private $n = 10000;
 
+    public function testReadIndexListView()
+    {
+        $n = $this->n;
+        $originalArray = range(0, $n);
+        $indexes = range(0, $n, 2);
+
+        $ts = \microtime(true);
+        $view = ArrayView::toView($originalArray);
+        $result = $view[$indexes];
+        $spent = \round(\microtime(true) - $ts, 4);
+
+        echo " [testReadIndexListView] SPENT: {$spent} s\n";
+        ob_flush();
+    }
+
+    public function testReadIndexListPure()
+    {
+        $n = $this->n;
+        $originalArray = range(0, $n);
+        $indexes = range(0, $n, 2);
+        $n_2 = \count($indexes);
+
+        $ts = \microtime(true);
+        $result = [];
+        for ($i = 0; $i < $n_2; $i++) {
+            $result[$i] = $originalArray[$indexes[$i]];
+        }
+        $spent = \round(\microtime(true) - $ts, 4);
+
+        echo " [testReadIndexListPure] SPENT: {$spent} s\n";
+        ob_flush();
+    }
+
     public function testReadSliceView()
     {
         $n = $this->n;
@@ -20,7 +53,7 @@ public function testReadSliceView()
         $result = $view['::2'];
         $spent = \round(\microtime(true) - $ts, 4);
 
-        echo "[testReadSliceView] SPENT: {$spent} s\n";
+        echo " [testReadSliceView] SPENT: {$spent} s\n";
         ob_flush();
     }
 
@@ -37,9 +70,10 @@ public function testReadSlicePure()
         }
         $spent = \round(\microtime(true) - $ts, 4);
 
-        echo "[testReadSlicePure] SPENT: {$spent} s\n";
+        echo " [testReadSlicePure] SPENT: {$spent} s\n";
         ob_flush();
     }
+
     public function testWriteSliceView()
     {
         $n = $this->n;
@@ -52,7 +86,7 @@ public function testWriteSliceView()
         $view['::2'] = $toWrite;
         $spent = \round(\microtime(true) - $ts, 4);
 
-        echo "[testWriteSliceView] SPENT: {$spent} s\n";
+        echo " [testWriteSliceView] SPENT: {$spent} s\n";
         ob_flush();
     }
 
@@ -69,7 +103,7 @@ public function testWriteSlicePure()
         }
         $spent = \round(\microtime(true) - $ts, 4);
 
-        echo "[testWriteSlicePure] SPENT: {$spent} s\n";
+        echo " [testWriteSlicePure] SPENT: {$spent} s\n";
         ob_flush();
     }
 }